gravity00/simpleexceptionhandling

Library that helps developers to handle exceptions outside catch blocks. Typical usages are global exception handlers.

Hi there 👋

simpleexceptionhandling's Issues

Catch with an options class as an argument

The catch method could also receive an options class as an argument. Example:

var result = 
    Handling.Prepare()
        .Catch(context.Exception, null, new CatchOptions
        {
            ThrowIfNotHandled = false
        });

Asynchronous handlers

Allowing the execution of asynchronous handlers for IO intensive operations.

Finalization code

Since the framework replicates the try-catch block, adding a finalization function could be useful, allowing for a try-catch-finally block.

Example to replicate:

try
{
    throw new ArgumentNullException();
}
catch (ArgumentNullException)
{
    Console.WriteLine("ArgumentNullException thrown");
}
catch (Exception)
{
    Console.WriteLine("Exception thrown");
}
finally
{
    Console.WriteLine("Finally code executed");
}

IHandlingConfiguration - Single responsibility principle

At the present moment, the interface IHandlingConfiguration is responsible for storing handling configurations and running the handling logic itself. This could be considered a violation of the single responsibility principle.

To resolve this question, it could be split, at least, in two interfaces:

• IHandlingConfiguration - stores the collection of handlers and other handling properties;
• IHandlingService - contains the logic for handling exceptions, and uses an IHandlingConfiguration to decide his behavior;

This implementation should allow a more decoupled handling logic.

Library stong signed

Strong signing the library

Handling.Prepare() not returning a IHandlingConfiguration

The method Handling.Prepare() is returning an IHandlingConfiguration<object, object> instead of an IHandlingConfiguration, as indicated by the documentation.

Example:

IHandlingConfiguration conf = Handling.Prepare(); // error, can´t implicit convert the result
IHandlingConfiguration<object, object> conf = Handling.Prepare(); // success

Update package for new Monikers

Make the NuGet package compatible with the new moniker targets. Examples:

• netcoreapp
• netstandard

Stack trace being rewritten when thrown in Catch method

Example code:

      var result = Handling.Prepare()
                .On<ValidationException>(ex =>
                {
                    var messages = new List<string>();
                    foreach (var error in ex.ValidationErrors)
                    {
                        messages.AddRange(error.Messages);
                    }

                    context.CreateBadRequestResult(
                        IsLocalhost(context),
                        new[]
                        {
                            new KeyValuePair<string, string[]>(string.Empty, messages.ToArray())
                        });
                })
                .On<BusinessException>(ex =>
                {
                    context.CreateConflictResult(ex.Message, IsLocalhost(context));
                })
                .On<GenericException>((ex) =>
                {
                    context.TransformResultIntoInternalServerError(ex.Message, IsLocalhost(context));
                })
                .On<TimeoutException>((ex) =>
                {
                    context.CreateGatewayTimeoutResult(IsLocalhost(context));
                })
                .On<NotImplementedException>(ex =>
                {
                    context.CreateNotImplementedResult(IsLocalhost(context));
                })
                .Catch(context.Exception, null, true);

hello, could you please explain/demonstrate how to plug this into an .net core mvc app? thx.