greatehop/serversmanagement

serversmanagement's Issues

models: avoid using of PickleType

Use VARCHAR storing serialized JSON strings, e.g. this snippet:

https://github.com/openstack/oslo.db/blob/master/oslo_db/sqlalchemy/types.py#L18-L51

PickleType is Python-specific (in case you want to work with the DB from CLI or another programming language) and has security issues (if someone can modify the sqlite database stored in a file, he/she will be able to run an arbitrary code on behalf of your application).

models: redundant code

Code here https://github.com/greatehop/serversmanagement/blob/master/app/models.py#L59-L62 :

        if server_id is not None:
            self.server_id = server_id
        if cmd_out is not None:
            self.cmd_out = cmd_out

makes little sense as both server_id and cmd_out columns already default to None, if not set to some other values.

Overall models accept keyword arguments in __init__() by default, so you must not need to override it for such simple cases.

r = Run(server_id=1, cmd_out='test')

would work.

Ищу DevOPs (возможна удаленка). OpenStack + Kube - 15-20K контейнеров

Дай знать если интересно.
https://www.linkedin.com/in/belokonm/

Use .gitignore to remove redundant files from the repo

You should use .gitignore file to not track changes at least in binary files, e.g.:

*.pyc

The same probably goes for the sqlite db file and pydev stuff.

More details: https://git-scm.com/docs/gitignore

Consider using alembic instead of sqlalchemy-migrate

alembic (https://alembic.readthedocs.org/en/latest/) is a modern alternative of sqlalchemy-migrate, which hasn't been updated for a while now.

Add a pep8 environment and run flake8 on all your source files

Use tox for management virtual environments and running tests

https://tox.readthedocs.org/en/latest/