greenaddress/elements

Feature experiments to advance the art of Bitcoin

elements's Issues

System notification show L-BTC even when sending/receiving assets

When sending/receiving an asset, notifications show the amount with L-BTC units.

Note also the "(GUI node for bitcoin)" in the second screenshot.

Screenshots.

• macOS 10.14

• Windows 10

Version

1164cc4

Machine specs:

Tested on a physical machine running macOS 10.14 Mojave and a virtual machine running Windows 10

Receive Tab - Show button disabled

Show button on the receive screen is disabled.

Double clicking on the address correctly brings up the request payment address details dialog. This is what should be shown then the Show button is functional.

Changing l-BTC units causes a crash

Description

Changing l-BTC causes a crash. At the next start, units are updated.

Steps to reproduce

1. Start liquid-qt
2. Change l-BTC units

Expected behaviour

Units updated across the app

Actual behaviour

Crash

Version

3.14.1.22 aff772d

Machine specs:

• OS: macos 10.14

Any extra information that might be useful in the debugging process.

Abort trap: 6 printed after the crash

Minus sign after decimal point in overview tab and transactions tab

Description

Minus sign shown after decimal point in amounts (tx overview tab and transactions tab). Seems to happen only for very low amounts. Attached screenshot

Screenshot

In overview tab:

In transactions tab:

Version

3.14.1.22 aff772d

Machine specs:

• OS: macos 10.14

Qt Windows10 - Application does not ask for default folder at first start

Can you reliably reproduce the issue?

If so, please list the steps to reproduce below:

1. Create a default Liquid datadir at: %homepath%\AppData\Roaming\Liquid
2. Create a liquid.conf file with validatepegin=0
3. Download binaries, extract to default folder and run liquid-qt.ext

Expected behaviour

Application on first start should ask for default datadir location.

Actual behaviour

It uses the folder where liquid-qt.exe is located at.

Transaction id not available

After 1afe9ce, there is no way to see a transaction ID beside exporting a .csv file.

Expected behaviour

It would nice to have the tx id shown somewhere in the app. Or allowing copy to clipboard.

It could be an additional column in the transaction list tab or copying directly to the clipboard the txid when clicking on an entry in the table.

Version

2e82bda

Machine specs:

• OS: macOS 10.14

Liquid logo and icon distorted in osx and windows

Description

The icon and the logo look distorted in Windows and macos versions

Steps to reproduce:

Start liquid-qt

Expected behaviour

Icon showed as in Linux version

Screenshots.

REMOVED AS NOT APPLICABLE

Version

3.14.1.22 aff772d

Startup error shown if bitcoind RPC unavailable is unclear to newbies

Describe the issue

Once the liquid-qt is launched, if the bitcoin server is not correctly configured, the app displays an ambiguous error message. A user may not adequately understand the need to install a bitcoin node.

If so, please list the steps to reproduce below:

Start liquid-qt app without other arguments (and without a configuration file).

Expected behaviour

Suggest to install bitcoin core (maybe with a link to bitcoincore.org) and to configure liquid appropriately.

Actual behaviour

Show an error message and halt the app.

Screenshots

Machine specs:

MacOSX 10.14.3

Sent amount in transaction details is always shown in L-BTC units

Description

If the asset sent is not L-BTC, amount units are still shown in L-BTC.

Steps to reproduce:

Go to transactions tab and double click on a transaction

Expected behaviour

Apply units only for L-BTC and show asset id

Screenshots.

Version

3.14.1.22 aff772d

Machine specs:

• OS: macos 10.14

Splash Screen - Change Copyright Years

Change copyright years from 2015-2017 to 2015-2019

Recent Transactions Dialog - Change text from Bitcoin to Liquid

1. "This information will be correct once your wallet has finished synchronizing with the Liquid network, as detailed below."
2. "Attempting to spend assets that are affected by not-yet-displayed transactions will not be accepted by the network."

6 Confirmations is used for warning, should be 2.

When I receive a transaction in Liquid QT, it shows a pie chart of confirmations needed, with 6 as the target. For Liquid, this should be 2.

Non-deterministic block validity state cached

IsValidPeginWitness is used from at least GetTransactionSigOpCost and CheckTxInputs to determine block validity, the result of which can cause a block to be marked invalid permanently, and never reconsidered later.

But this is a problem because it calls IsConfirmedBitcoinBlock which can return true or false depending on the state of the linked Bitcoin node. The Bitcoin node might be behind, causing the block to be marked as invalid, and never reconsidered later when the Bitcoin node catches up. (Or an actually-invalid block might become valid as the Bitcoin blockchain grows, but this shouldn't happen in reality.)

Receive Tab - Remove button disabled

Similar to #12 but with remove button. Unsure if this disabling is intentional or bug.

ApplyTxInUndo probably shouldn't check IsConfirmedBitcoinBlock

ApplyTxInUndo is used to disconnect a block being reorganised out. When undoing peg-ins, it checks IsConfirmedBitcoinBlock via IsValidPeginWitness. But if such a reorg were to happen, it would likely be because a peg-in is no longer valid on the Bitcoin side, and this failure would be fatal to Liquid nodes trying to sync to the new best chain.

Maybe a non-issue if Liquid functionaries are expected never to reorg. But at the very least, there is no apparent reason to re-check here, and it only has the potential to create unnecessary problems. Even if there are no problems, it can slow down the reorg.

SubtractFeeFromAmount checkbox shown when sending asset

Description

The SubtractFeeFromAmount checkbox is shown even when choosing an asset different than L-BTC

Steps to reproduce below:

1. Go to send tab
2. Select an asset different from L-BTC from the dropdown

Expected behaviour

Checkbox greyed out or hidden

Actual behaviour

Checkbox is shown and can be enabled

Screenshot

Version

3.14.1.22 aff772d

Machine specs:

• OS: macos 10.14

Status bar - Connections tooltip - Change Bitcoin to Liquid

Change "Bitcoin" network to "Liquid" in the connections status bar tooltip.

Wrong storage requirements claimed in GUI Intro

Describe the issue

Text strings from Core are included and don't match the storage requirements for Elements / Liquid.

If so, please list the steps to reproduce below:

1. Start -QT for the first time.

Expected behaviour

Should more accurately state the storage requirements (~600 MB on my machine).

Actual behaviour

The GUI displays the storage requirements as ~120 GB, which isn't accurate.

Screenshots

If the issue is related to the GUI, screenshots can be added to this issue via drag & drop.

Machine specs:

• OS: macOS Mojave

Transaction Tab - No Transaction Details Dialog on double click

In Bitcoin Core, a user can double click on a transaction and get details. Like this:

However in Liquid-qt no such details are available.