gretchenfitze/billing-form

Demo page for user-friendly billing form features

billing-form's Issues

Use Autoprefixer

  -webkit-transition: background 0.6s, color 0.6s;
  transition: background 0.6s, color 0.6s;

should be replaced just to:

  transition: background 0.6s, color 0.6s;

Add README

Better BEM

Awesome that you use BEM-like isolation. But using real BEM naming could improve readability.

1. You should use different separator for block/element and between words. card_bank-name instead of card-bank-name. What if you will add card-bank block in future? :D
2. Avoid nested elements. .card_label instead of .card_date_label.
3. Avoid global unprefixed styles. .card_label.is-invalid instead of .invalid.

Add inputmode="numeric" to number inputs

Although browser support at time of writing is very poor - this feature is in development for Chrome and under consideration for Microsoft Edge. I think it's worth adding for future-proofness.
https://caniuse.com/#search=inputmode

Better index.html title

Billing Form Example is better

WOFF/WOFF2 for font

Halter archive contains only .ttf font file format. But WOFF and WOFF2 has less size.

I like that current font section in article is so simple. Maybe we could show simple .ttf example in article, but use better woff and woff2 files in repository?

But I ma not sure, up to you.

Use US bank in example image

Better contrast

Current light-gray placeholder has very low contrast with white from background.