greycorbel/admpwd

AdmPwd project

admpwd's Issues

Custom password

We use same password for each group of computers, so admins can remember which password to use. Would be possible to modify LAPS policy to enable custom password (entered by admin) or use the same password for a group of computers?

Automatically reset password on install

It'd be really handy if the MSI could expire the password and force a new one to be generated on installing the CSE. I know this can be done with Clear-PasswordTimestamp.ps1, but not everyone does and it means reimaged machines don't have a LAPS password configured until their next expiry time, which feels like a gotcha. I think it should be reset by default, possibly with an option to not do so.

small issues

checking wrong variable : reading &_pwdComplexity but checking _pwdLength

	GetRegistryDWORD(hPolicyKey, PWD_COMPLEXITY_REG_VALUE, &_pwdComplexity);
	if (_pwdLength > MAX_PWD_LENGTH || _pwdLength < PWD_LENGTH) _pwdLength = PWD_LENGTH;

same for next _pwdAge

Expanding the #defines can be an issue, because it will append the text //default ?

#define MAX_PWD_COMPLEXITY	4	//default
#define PWD_LENGTH		12	//default
#define PWD_AGE_DAYS	30	//default

AdmPwd source code version

Hi Jiri,

First, thanks a lot for sharing your code.

I forked admpwd CSE last year to make it work through a VPN client called 'Ercom Cryptosmart PC'.
I had to rewrite some parts of your original code to avoid RPC requests (not allowed in my society's VPN channel), and built it as a console application to launch it on demand via a windows service (for some reasons, remote laptops can't perform gpupdates through the VPN channel).
I called it "LAPS mobile", and it works great.

"LAPS mobile" was originaly based on LAPS 5.2.0.0, so i wanted to update it with the lastest version of your code.
My society's desktop computers are equiped whith version 6.0.1.0, and the lastest version i found on Microsoft website is 6.2.x, released in september 2016.

But, according to the assembly infos of the VS project, the version you share on github is 5.2.1.0.
However, it seems that you updated the project on 4th of july 2017, so later than the 6.2.x release.

So can you tell me/us if there is an error/oversight on the assembly infos, or i you decided to stop sharing the source code since the 5.2.1.0 version ?

Thanks a lot.

Bertrand

Uneven password distribution

When using LAPS I noticed that the passwords had too many numbers. I checked the frequency of characters for ~800 computers, which confirmed that this was the case.

Using equal possibilities for each dict gives letters 1/4*1/26 chance, special characters 1/4*1/20 chance while numbers have 1/4*1/10 chance. In addition the plus sign is repeated in the special dictionary.

All of these problems are in PasswordGenerator.h in the Generate function.