griffinht/scribbleshare

Realtime collaborative whiteboard

scribbleshare's Issues

License

This project needs to have some sort of written license.

Trim netty

Currently the fat jar produced by the project is 10mb ish in size - this can be reduced if only necessary Netty components are included.

Fix Docker not properly caching Maven dependencies

Currently Docker will sometimes decide Maven dependencies are out of date, where it will then proceed to download the entire internet to update the dependencies. Perhaps set up a local Maven repository server that will do all the caching?

javax.activation dependency

The javax.activation dependency is only used for the mime file types. Additionally, it has been removed in Java 9. Thus, a replacement should be provided.

Electron client/interface

because why not?

how hard could it be?

maybe even offline support?

Wrong length cookies will throw exceptions with no response

Set bad cookies to fuzz this in the future

Better Logging System

There should be better ways to log things such as console output as well as network throughput, with the option to save to file?

Unify BufferReader and BufferWriter

Turn them in to a ByteBuffer class

Documents with the same name will not work in the sidebar

SidebarItem.js should use ids instead of names.

User display names

Users should have names

Improved session management

Session management is currently poor - sessions are not revoked properly, nothing is tracked etc

Inconsistent quotation marks in JS files

Both " and ' are found in JS files

Zoom/pan

Currently there is no way to zoom in and out, or pan across the board.

Rename feature

documents should be renamable

Fix console arguments

The current format is --key value
Change this to --key=value

Netty has a Redis codec

Why not implement this to replace Jedis? Might be a little tricky.

Variable length integer and string

The frontend and backend should be able to utilize variable length integers (for array sizes) and strings. Currently there is limited and hacky support for these.

HTTPS/WSS SSL support

The server should be modified to support https:// and wss:// protocols

Sometimes persisted drawings will be removed when new items are drawn

NPE when board-web-client does not send OPEN packet before DRAW packets

Can be reproduced by modifying board-web-client to send DRAW packets before OPEN is sent.
Should be replaced with a warning in the console.
In the future clients that misbehave like this should possibly be disconnected.

WARNING: An exceptionCaught() event was fired, and it reached at the tail of the pipeline. It usually means the last handler in the pipeline did not handle the exception.
java.lang.NullPointerException
	at net.stzups.board.room.PacketHandler.channelRead0(PacketHandler.java:30)

https://github.com/stzups/Board/blob/71001322ef76b4b6a586511173f63ec0476bfeb2/board-server/src/main/java/net/stzups/board/room/PacketHandler.java#L30

Drawings are different sizes on different screens

Currently, the coordinate system is based on a user's screen resolution. This needs to be standardized and scaled across different resolutions.

Shrinking the window introduces scroll bars

Shrinking the window after the page has loaded will introduce scroll bars because the canvas does not shrink enough. However, the canvas is still able to resize properly when the page loads.

Better curve interpolation

The current system displays curves as many smaller straight paths between two points. Using some sort of actual curve would help with looks and compression.

Google Protocol Buffer

Why not use Google's Protocol Buffer library? https://github.com/protobufjs/protobuf.js

Automatic reconnect

Clients that are disconnected from the server should keep retrying the WebSocket connection

HTTP/2

The HTTP server should be upgraded to use HTTP/2 (see stackoverflow.com/questions/53488601/)

Readme is ugly

please fix

Better state management with connections

Currently the server will attempt to handle any message from the client assuming the client has already sent a proper handshake and has opened a document. If the client sends these packets out of order, the server will throw some NPE.

Maybe some kind of state machine?

Typescript

convert the whole project into typescript

Using multiple tabs at once causes problems

Currently using multiple tabs can cause problems with user identity - either allow for multiple of the same user or log out old users?

Better config system

Messy program arguments may not be the best way to handle configuring, perhaps switch to a config file or use better documentation?

Remove ConsoleManager

This class is unused and unnecessary. Without this class, a proper shutdown mechanism may be added for netty

More CSS/JS documentation

board-web-client has little documentation explaining various CSS and JavaScript quirks and functionalities.
Descriptive and helpful comments should be added to explain structure and hard to understand code.

Mouse synchronization

The mouse of other users should be visible, along with their name.

CORS

origin and referer needs to be checked for certain requests

Code should be minified

There should be some sort of tool (uglify? gulp?) added to the development pipeline to minify the code that will be served to the client. This should also combine the various JavaScript various files and modules into one .js file

Holding down while drawing can also select text

Sometimes when drawing out of bounds text will be selected. Fix by disabled text selection while drawing.

Long strokes will get off over time

When drawing a long enough stroke, the offset will be messed up if it is long enough. This is due to certain rounding errors.

Possibly can be fixed by sending a full update every so often.

Room ids less than 6 digits in length are possible

Room ids should be 123456 (6 long), but if the number is less than 100000 the id will be less than 6 characters (eg 245). Note that this bug does not seem to cause functionality problems, but should still be fixed.

stop command doesn't stop the server

Running stop in the terminal with the server running won't close the server - probably because of netty not being shut down properly.

Upload gets stuck when the upload file is not an image

Expanding the canvas always loads white space instead of drawings

Some sort of mechanism needs to be implemented to store lines that appear off the page, then draw them when the page comes into view