grimadas/blockchainengineering

Learn to think like a blockchain designer by solving practical challenges

blockchainengineering's Issues

get_graph undefined for the Simulation class

It seems that on line G = sim.get_graph() in the third notebook, get_graph() is not defined in the Simulation class.

Windows is missing C++ compiler for Numpy

When running pip install with the requirements file. It crashes on Windows...
The error that is thrown is during the installation of Numpy:
The " Microsoft Visual C++ 14.0 or greater is required. Get it with "Microsoft C++ Build Tools": https://visualstudio.microsoft.com/visual-cpp-build-tools/"

Could be nice to have mentioned in the README

Typo in GitHub about

Currently says: Lean to think like a blockchain designer by solving practical challenges

Should be learn 😉

Typo in master

In the Jupyter notebook 02_Gossip_Services, the cell Average time contains the following piece of code.

def show_avg_time(df):
    plt.figu

re(figsize=(10, 5))
ax = sns.boxplot(data=df, )
ax.set_title('Average time to arrival', fontsize= 20 )
ax.set_ylabel('Time (ms)', fontsize=12)
ax.set_xlabel('Peer id', fontsize=12)
plt.show()
show_avg_time(df)

This should be changed to the following:

def show_avg_time(df):
    plt.figure(figsize=(10, 5))
    ax = sns.boxplot(data=df, )
    ax.set_title('Average time to arrival', fontsize= 20 )
    ax.set_ylabel('Time (ms)', fontsize=12)
    ax.set_xlabel('Peer id', fontsize=12)
    plt.show()

show_avg_time(df)

It seems to be already updated (or not broken) in changes-to-text. However, that branch seems to be stale. The typo was introduced in e4301b6d33f119e3e1ff56ac67c7e659fcd62e92.