grootpiano/easegress

A Cloud Native traffic orchestration system

easegress's Issues

[Bug]: wasm apply data command not worked

Describe the bug
Hi guys, I found two kind of issues when walking through our Flash Sale demo.

Issue 1: Parameters' type error in section 6.1 example spec

According to WasmHost filter's spec declaration, parameters' value type should be string:

type Spec struct {

    Parameters     map[string]string `json:"parameters" jsonschema:"omitempty"`

}

But the example in section 6.1 6.1 Parameters used a number value:

filters:
  - name: wasm
    kind: WasmHost
    parameters:                                        # +
      startTime: "2021-08-08T00:00:00+00:00"           # +
      blockRatio: 0.4                                  # +
      maxPermission: 3                                 # +

So egctl client returned error:

Error: 400: {"generalErrs":["*pipeline.Spec: filters: json: cannot unmarshal number into Go struct field Spec.parameters of type string"]}

---

Issue 2: Wasm apply-data command not worked

When executing the command blow, I got this error:

$ echo '
id/user4: "true"
id/user5: "true"' | egctl wasm apply-data flash-sale-pipeline wasm
Error: name is empty:
id/user4: "true"
id/user5: "true"

I found that we used SpecVisitor to get spec doc:

Run: func(cmd *cobra.Command, args []string) {
    visitor := buildSpecVisitor(specFile, cmd)

}

But SpecVisitor did not allow empty name:

func (v *specVisitor) Visit(fn func(*spec) error) error {

	err := v.v.Visit(func(yamlDoc []byte) error {

		if s.Name == "" {
			return fmt.Errorf("name is empty: %s", doc)
		}

	})

}

And another issue I found in the same command is that we used createObject handler to hanle apply data request instead of wasmApplyData handler:

Run: func(cmd *cobra.Command, args []string) {

    visitor.Visit(func(s *spec) error {
        handleRequest(http.MethodPost, makeURL(objectsURL), []byte(s.doc), cmd)

    })

}