teacozy's People
teacozy's Issues
Classes and IDs
https://github.com/GRudinsky/teacozy/blob/master/index.html#L32-L56
It'd be best to use the tag that best represents the type of content you're writing. For example:
If you're using an image, use an img
tag. If you're using a paragraph, use a p
tag. There's no need to write "image" or "paragraph" in class names when the HTML tag already indicates this purpose.
You've also got your IDs and Classes mixed up. Use an ID for an element that needs to be identified individually. Use a class to group multiple similar elements. If you're going to use "featured"
for every tea, you should use it as a class. Then "berry"
, "spiced"
, etc. can be the IDs that identify a single tea element on the page.
Same for your locations section.
Semantic markup
https://github.com/GRudinsky/teacozy/blob/master/index.html#L10-L18
Nice job using header
, nav
, and footer
here to make your markup more semantic. ๐
Try to go the extra mile and add a couple more semantic elements, like: main
, section
, menu
, figure
, etc. These can all make your markup a lot easier to read and reason about than just using div
.
Images
https://github.com/GRudinsky/teacozy/blob/master/index.html#L33-L34
Why use an empty div
tag with a class of "image"
instead of a regular img
tag? This is exactly what the img
tag is for.
https://github.com/GRudinsky/teacozy/blob/master/resources/css/style.css#L92-L106
Nice job including your website's assets (in this case images) in your project and providing a relative file path to them in your img
tags. ๐
It's always better to provide static assets up front instead of depending on external URLs that could fail or otherwise become unavailable.
`head`
https://github.com/GRudinsky/teacozy/blob/master/index.html#L3-L7
Nicely done providing a relative file path to your stylesheet and giving your your webpage a relevant title
๐
Summary
Satisfactory ๐
Good job reproducing the web page according to the design mock.
You've demonstrated adequate understanding of both basic CSS properties and advanced properties like flexbox and have these concepts to implement your site layout.
CSS and Flexbox
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
๐ Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. ๐๐๐
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google โค๏ธ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.