Convenient way to end a session

[gschup]

Convenient way to end a session

[johanhelsing]

Btw, my workaround for this is to create a newtype around an Arc<RwLock>, so i don't actually give the socket to ggrs

[johanhelsing]

Thanks for reporting, I'd like a convenient way to do this as well.

I think it's best if session starting and closing mirrors each other. So perhaps best to change how we start from inserting a resource to commands as well. Perhaps:

let session = session_builder
    .start_p2p_session(socket)
    .expect("failed to start session, check config");

commands.start_session(session);

Or perhaps take a session_builder and socket instead?

commands.start_p2p_session(session_builder, socket);

[ndev-rs]

I think it's best if session starting and closing mirrors each other. So perhaps best to change how we start from inserting a resource to commands as well. Perhaps:

let session = session_builder
    .start_p2p_session(socket)
    .expect("failed to start session, check config");

commands.start_session(session);

That would be a nice abstraction. Would it be possible to have the socket returned to us when we end the session? Something like:

let socket = commands.end_p2p_session()
    .expect("failed to return socket");

[johanhelsing]

Not with commands, no. It could perhaps be put into a resource where we could collect it... Not the nicest api, though

[ndev-rs]

Not with commands, no. It could perhaps be put into a resource where we could collect it... Not the nicest api, though

Yeah, that sounds pretty ugly. I like your idea of having the api work entirely thru commands, but perhaps there could be a separate way to take the socket which would make the session inactive until we clean it up via commands. Though that's probably a separate Issue.

let socket = session.take_socket();
commands.end_p2p_session();