gsomoza/baleen-cli

A standalone migrations framework that can also work as the foundation for your own PHP migrations library.

Hi there 👋, my name is Gabriel

I'm a Ecommerce Solution Architect based in Belgium. I enjoy staying up-to-date with the latest web and Ecommerce development best practices, such as domain-driven design (DDD), event sourcing, continuous integration & deployment (CI/CD), automated testing, and more.

I'm also a proficient developer, with knowledge and hands-on experience in most layers of the web stack: from DevOps, all the way to the front-end, and numerous contributions to open-source projects in the Zend Framework & Magento ecosystems.

Skills: Ecommerce Solution Architecture, Engineering Management & Coaching, Magento 2 & almost everything PHP, DevOps, Public Speaking

baleen-cli's Issues

StatusHandler Diff Issue

On StatusHandler::handle() line 67 we're assuming that by finding the difference between the count of available migrations vs migrated versions we'll know if there are migrations pending. That doesn't consider the following use-case:

1. Two branches "featureA" and "featureB" exist. They branch off the same commit in "master", which already has migration "1".
2. A user without migrations in the database is on branch "featureA" which has migration "1" "2". The migration is executed UP. Baleen records that "1" and "2" were migrated.
3. The user goes to branch "featureB" which has migrations "1" and "3".
4. At this point, running "git status" will say that the database is at version "2" and is up-to-date, which is incorrect because version 3 hasn't been executed yet.

The issue in the example above is because StatusHandler::handle() counts that there are two migrations in the database and two migrations available in the repository (filesystem), and therefore assumes there's nothing new to migrate.