gucio321/d2d2s

Diablo II save files (.d2s) editor written in golang.

d2d2s's Issues

linters: add wrapcheck linter

for clearity, it could be cool, to add wrapcheck linter

d2sitems/itemdata/magic_modifiers.go/MagicSuffix: name cosntants

`d2sstats`: unittests

d2swidget: complete d2s editor

d2sitems/itemdata: remove `nolint` directive

hmm, this giant nolint directive over the d2sitems/itemdata/item.go looks.... strange
I think, that it should be cut.
IMO gomnd could be left.

d2sstats: fix data size

For now, all data in Stats structure are uint64s or float64s
I think, that it could be something smaller

`d2sstatus`: unittest

`d2scorpse`: add unittest

Item list encoding

currently, items.go wrapps d2s/d2s.go:ParseItemsList
We need to verify, if it is possible to encode this structure or it is needed to create a new decoder/encoder

d2sitems: cannot parse some itm's daat

getting strange issue while parsing data of the following items:

• Grand Charm of life
• Chipped Ruby

Currently no info about frequency of the behaviour

checksum: calculating a save's checksum

the save files has to contain a 32-bit checksum, because the game will not read them.

what do we know about this field?

• documentation
  

checksum needs to be calculated in the same way as file size.

pkg structure: update to use golang-standards

https://github.com/golang-standards/project-layout

d2smercenary/Mercenary.Type: add merc types

Hi
currently, app stores merc code in an uint16 format, but there are known merc types and we need to enumerate them.
see here

data reader/writer

OpenDiablo2/OpenDiablo2 dependency is a wrong idea. there are 2 alternatives:

• use internal data reader (internal/datautils)
• use OpenDiablo2/bitstream

d2snpc: parse npc data to a human-readable structure

for more details, see here

split long methods to avoid `nolint` directive (d2sitems, d2s.go)

also need to split some long methods to avoid nolint directives

Originally posted by @gucio321 in #8 (comment)

`d2snpc`: unittest

d2squests: parse quest data into something useful

each quests has some status notes. We need to parse them into Quest structure.
see more here

cannot read and write created by d2 file properly

Cannot open and write again (with no diff) a new file created by retail d2 lod 1.14d (see test failure).
It seems not working since at least v1.1

`d2sitems/d2smagicattributes` add `String()` method

currently, attribute structure Name field and Values field
String method should join them and instead of +{0} to Strength [5] should print +5 to Strength

possibility to create completely new data files which works with d2.

Currently, when we do:
ioutil.WriteFile("testchar.d2s", New().SetName("testchar").Encode(), 0o644)

full code here

package main

import (
	"io/ioutil"

	"github.com/gucio321/d2d2s/pkg/d2s"
)

func main() {
	data, _ := d2s.New().SetName("testchar").Encode()
	ioutil.WriteFile("testchar.d2s", data, 0o644)
}

we'll get

`d2sitems`: provide easy in use interface for creating items

there is a lot of connections between various fields in item structure. IMO it needs an easy in use API

`d2sskills`: unittest

package structure: put any of project structures in a separated packages

it is a time, to split this d2s package into a several smaller 😀

+ d2s
   + d2sirongolem
    + d2smerc
    + d2sitems
        + itemdata
    + d2sdifficulty

e.t.c.

d2sitems/itemdata/magic_modifiers.go/MagicalPrefix: name constants

IMO names MagicalPrefix0, MagicalPrefix1 aren't correct 😀

d2senums/skill_id.go: complete missing data

Yo!
d2senums/skill_id.go should contain enumeration of all skill IDs with its strings.
for list of them, see here

`d2sdifficulty`: unittests

`d2sitems/itemdata.RareName`: name all constants in file

hmm. RareName1, RareName2 isn't ok

`d2sirongolem`: unittest

datautils: remove data readers/writers from this package, use OpenDiablo2 instead

Yo!
datautils was copied (and modified) from OpenDiablo2. It could be cool to get back to original base (using it as a dependency).
But base doesn't have some methods used here.
see OpenDiablo2/OpenDiablo2#1123

`d2smercenary`: unittest

`d2swaypoints`: unittest

Test template

Hi there, I'd like to describe used in a project tests template.
each _test.go file should look as follows:

1. testdata() map[*TestedType]binaryFormat method.
   this method should specify as much, as possible/necessary test cases in described map form
2. Test_Load(t *testing.T) this method is really easy

// declare testdata
td := testdata()

// testing loop
for key, value := range td {
    // load tested structure using data (value) given
    // in some cases, it could be necessary to create bitmuncher (datautils.CreateBitMuncher(value, 0) ) and pass it as an argument to load
    s := New()
    s.Load(value)

    // then just use `assert` to check results
    assert.Equal(t, key, s, "unexpected structure loaded")
}

3. Test_Encode(t *testing.T) is also really simple

td := testdata()
for key, value := range td {
    // encode tested structure into binary form (value)
    data := key.Encode()

    // use assert to detect differences
    assert.Equal(t, value, data, "unexpected data encoded")
}

`d2sitems`: parse class specific data

there is Item.ClassSpecific substructure. We need to parse Data to something human-readable

`d2sdifficulty`: add some api?

d2sdifficulty.Difficulty is a map-type. So I store pointer to it in main D2S structure, but the problem is, that reffering to a pointer-map is a bit... strange. it looks like `(*p.d2s.Difficulty)[d2enum.DifficultyNormal]. I suggest to add some api for this stuff or reduce this noise in some other way