gustavnikolaj/assetgraph-builder-docker

A wrapper around the assetgraph-builder docker container.

assetgraph-builder-docker's Issues

Specifying which version of node to use.

After landing #2 you'll need a version of the assetgraph-builder docker image with the correct version of node.js installed, if you have any binary optional dependencies.

Specifying which version of assetgraph-builder to use.

I talked to @papandreou today about this POC. We need a way to specify the version of the image that are used with this package.

Option 1:

Adding a version property to the "assetgraph-builder" value in package.json and allowing it to be specified as a commandline argument.

This forces us to move the pulling of the image from postinstall to runtime.

Option 2:

Release assetgraph-builder-docker when releasing assetgraph-builder itself. This means merging this repository to the assetgraph-builder repository.

Picking up on optional dependencies.

When running buildProduction from this package in a project using SystemJs, with a package.json containing the following:

{
  ...,
  "devDependency": {
    "systemjs-builder": "..."
  },
  "assetgraph-builder": {
    "outroot": "http-pub-production",
    "inputFile": "http-pub/index.html"
  }

The following error is thrown:

$ buildProduction
Guessing --root from input files: file:///app/http-pub/
 ✔ 0.000 secs: logEvents
 ✔ 0.001 secs: registerRequireJsConfig
 ✔ 0.002 secs: registerLabelsAsCustomProtocols
 ✔ 0.038 secs: loadAssets
 ✔ 0.074 secs: populate
 ✔ 0.029 secs: assumeRequireJsConfigHasBeenFound
 ✘ ERROR: Error: buildProduction transform: bundleSystemJs transform: The graph contains 2 top-level System.import calls, but systemjs-builder is not available. Please install systemjs-builder 0.14.9+ in the the containing project.
              at bundleSystemJs (/usr/local/lib/node_modules/assetgraph-builder/node_modules/assetgraph/lib/transforms/bundleSystemJs.js:549:19)
              at Object._onImmediate (/usr/local/lib/node_modules/assetgraph-builder/node_modules/assetgraph/lib/index.js:663:35)
              at processImmediate [as _immediateCallback] (timers.js:363:15)

This is because assetgraph-builder is installed at /usr/local/lib/node_modules/assetgraph-builder and thus won't pick up on the systemjs-builder present in /app/node_modules/systemjs-builder.

This could be solved by installing optionalDependencies in the image, but that is suboptimal, as you want it to use the version of less that you have installed in your project, not just some random version shipped with the image...

--stoponwarning flag is not passed on correctly.

A warning about an error in a less file didn't cause the build to fail, even with stoponwarning enabled.