guykh/10bis.slackbot

A slackbot for looking for restaurants in 10bis

Hey 👋, I'm Guy

Passionate backend developer, smart home (dumb) manager, loves to contribute to open-source projects, fixing stuff I need and tinkering hardware. Hiking, Guitaring, Drone-ing, Photographing and more.

• 🛠️ I'm working and devloping various projects including Home Assistant IEC Component, py-iec-api, 10bis-slackbot

• 🔭 I’m currently regularly contributing to projects including SmartCopy, Home Assistant IMS Component

• 🤝 I've previously contributed to popular projects including Home Assistant, Bazarr, Nexmo

• 📊 I worked as a backend software developer at Orsus, Nice, Yahoo and Wix

• 💬 Ask me about java, git, linux, smart home and coffee

• 📫 How to reach me [email protected]

• ⚡ Fun fact I have a baby daughter - Arbel and a dog - Pepper, and often I mix eachother's names.

Connect with me:

Languages and Tools:

10bis.slackbot's Issues

Unittests are failing since Dixie opened a 2nd branch

Expected Behavior

All unittests should pass

Actual Behavior

Some tests fail since when querying for "Dixie" - getting 2 restaurants instead of one

Steps to Reproduce the Problem

1. Run Unittests

Specifications

• Version:
• Platform:
• Subsystem:

Dependency Dashboard

This issue lists Renovate updates and detected dependencies. Read the Dependency Dashboard docs to learn more.

Open

These updates have all been created already. Click a checkbox below to force a retry/rebase of any.

• chore(deps): update dependency eslint to v9
• chore(deps): update dependency nyc to v17
• chore(deps): update github/super-linter action to v6
• fix(deps): update dependency uuid to v10
• Click on this checkbox to rebase all open PRs at once

Detected dependencies

github-actions

.github/workflows/actions.yml

• actions/checkout v4
• github/super-linter v5
• actions/setup-node v4

.github/workflows/codeql-analysis.yml

• actions/checkout v4
• github/codeql-action v3
• github/codeql-action v3
• github/codeql-action v3

npm

package.json

• @types/express 4.17.21
• axios 1.7.2
• body-parser 1.20.2
• errorhandler 1.5.1
• express 4.19.2
• express-rate-limit 7.3.1
• moment-timezone 0.5.45
• node-ts-cache 4.4.0
• node-ts-cache-storage-memory 4.4.0
• redis 4.6.14
• typescript 5.4.5
• uuid 9.0.1
• winston 3.13.0
• @types/chai 4.3.16
• @types/mocha 10.0.6
• @typescript-eslint/eslint-plugin 7.12.0
• @typescript-eslint/parser 7.12.0
• chai 5.1.1
• coveralls 3.1.1
• eslint 8.57.0
• eslint-config-prettier 9.1.0
• eslint-plugin-chai-expect 3.0.0
• eslint-plugin-mocha 10.4.3
• eslint-plugin-prettier 5.1.3
• husky 9.0.11
• mocha 10.4.0
• mock-express-response 0.3.0
• nock ^14.0.0-beta.5
• node-mocks-http ^1.14.1
• nyc 15.1.0
• prettier 3.3.1
• sinon 18.0.0
• ts-node 10.9.2
• npm 10.8.x
• node 20.x

nvm

.nvmrc

• node 20.14.0

---

• Check this box to trigger a request for Renovate to run again on this repository

Multiline Total should include Minimum Delivery Price and Current Total

When total contains more than allowed number of restaurants, the text just describes the restaurant and doesn't contain the Minimum Delivery nor current total.
E.g.

[1] זה סושי : https://www.10bis.co.il/Restaurants/Menu/Delivery?ResId=19355
[2] מזנון אייל שני : https://www.10bis.co.il/Restaurants/Menu/Delivery?ResId=13780
[3] רוזינקא : https://www.10bis.co.il/Restaurants/Menu/Delivery?ResId=16189
[4] סאלם בומביי : https://www.10bis.co.il/Restaurants/Menu/Delivery?ResId=2990
[5] אוקינאווה לבונטין : https://www.10bis.co.il/Restaurants/Menu/Delivery?ResId=22408

An in-range update of mocha is breaking the build 🚨

The devDependency mocha was updated from 6.2.0 to 6.2.1.

🚨 View failing branch.

This version is covered by your current version range and after updating it in your project the build failed.

mocha is a devDependency of this project. It might not break your production code or affect downstream projects, but probably breaks your build or test tools, which may prevent deploying or publishing.

Status Details

• ❌ continuous-integration/travis-ci/push: The Travis CI build failed (Details).

---

Commits

The new version differs by 11 commits.

• ef6c820 Release v6.2.1
• 9524978 updated CHANGELOG for v6.2.1 [ci skip]
• dfdb8b3 Update yargs to v13.3.0 (#3986)
• 18ad1c1 treat '--require esm' as Node option (#3983)
• fcffd5a Update yargs-unparser to v1.6.0 (#3984)
• ad4860e Remove extraGlobals() (#3970)
• b269ad0 Clarify effect of .skip() (#3947)
• 1e6cf3b Add Matomo to website (#3765)
• 91b3a54 fix style on mochajs.org (#3886)
• 0e9d8ad tty.getWindowSize is not a function inside a "worker_threads" worker (#3955)
• 48da42e Remove jsdoc index.html placeholder from eleventy file structure and fix broken link in jsdoc tutorial (#3966)

See the full diff

FAQ and help

There is a collection of frequently asked questions. If those don’t help, you can always ask the humans behind Greenkeeper.

---

Your Greenkeeper Bot 🌴

Action Required: Fix Renovate Configuration

There is an error with this repository's Renovate configuration that needs to be fixed. As a precaution, Renovate will stop PRs until it is resolved.

Error type: undefined. Note: this is a nested preset so please contact the preset author if you are unable to fix it yourself.

An in-range update of eslint is breaking the build 🚨

The devDependency eslint was updated from 6.4.0 to 6.5.0.

🚨 View failing branch.

This version is covered by your current version range and after updating it in your project the build failed.

eslint is a devDependency of this project. It might not break your production code or affect downstream projects, but probably breaks your build or test tools, which may prevent deploying or publishing.

Status Details

• ❌ continuous-integration/travis-ci/push: The Travis CI build failed (Details).

---

Release Notes for v6.5.0

• 73596cb Update: Add enforceForSwitchCase option to use-isnan (#12106) (Milos Djermanovic)
• d592a24 Fix: exclude \u000d so new line won't convert to text (fixes #12027) (#12031) (zamboney)
• e85d27a Fix: no-regex-spaces false positives and invalid autofix (fixes #12226) (#12231) (Milos Djermanovic)
• b349bf7 Fix: prefer-named-capture-group incorrect locations (fixes #12233) (#12247) (Milos Djermanovic)
• 7dc1ea9 Fix: no-useless-return autofix removes comments (#12292) (Milos Djermanovic)
• 0e68677 Fix: no-extra-bind autofix removes comments (#12293) (Milos Djermanovic)
• 6ad7e86 Fix: no-extra-label autofix removes comments (#12298) (Milos Djermanovic)
• acec201 Fix: no-undef-init autofix removes comments (#12299) (Milos Djermanovic)
• d89390b Fix: use async reading of stdin in bin/eslint.js (fixes #12212) (#12230) (Barrie Treloar)
• 334ca7c Update: no-useless-rename also reports default values (fixes #12301) (#12322) (Kai Cataldo)
• 41bfe91 Update: Fix handling of chained new expressions in new-parens (#12303) (Milos Djermanovic)
• 160b7c4 Chore: add autofix npm script (#12330) (Kai Cataldo)
• 04b6adb Chore: enable eslint-plugin-jsdoc (refs #11146) (#12332) (Kai Cataldo)
• 9b86167 Docs: Add new ES environments to Configuring ESLint (#12289) (Milos Djermanovic)
• c9aeab2 Docs: Add supported ECMAScript version to README (#12290) (Milos Djermanovic)
• 8316e7b Fix: no-useless-rename autofix removes comments (#12300) (Milos Djermanovic)
• 29c12f1 Chore: cache results in runtime-info (#12320) (Kai Cataldo)
• f5537b2 Fix: prefer-numeric-literals autofix removes comments (#12313) (Milos Djermanovic)
• 11ae6fc Update: Fix call, new and member expressions in no-extra-parens (#12302) (Milos Djermanovic)
• a7894eb New: add --env-info flag to CLI (#12270) (Kai Cataldo)
• 61392ff Sponsors: Sync README with website (ESLint Jenkins)
• 2c6bf8e Docs: English fix (#12306) (Daniel Nixon)
• 6f11877 Sponsors: Sync README with website (ESLint Jenkins)
• 2e202ca Docs: fix links in array-callback-return (#12288) (Milos Djermanovic)
• e39c631 Docs: add example for CLIEngine#executeOnText 3rd arg (#12286) (Kai Cataldo)
• d4f9a16 Update: add support for JSXFragments in indent rule (fixes #12208) (#12210) (Kai Cataldo)
• c6af95f Sponsors: Sync README with website (ESLint Jenkins)
• 8cadd52 Sponsors: Sync README with website (ESLint Jenkins)
• f9fc695 Chore: enable default-param-last (#12244) (薛定谔的猫)
• 9984c3e Docs: Update README team and sponsors (ESLint Jenkins)

Commits

The new version differs by 32 commits.

• 76fb571 6.5.0
• 7359a80 Build: changelog update for 6.5.0
• 73596cb Update: Add enforceForSwitchCase option to use-isnan (#12106)
• d592a24 Fix: exclude \u000d so new line won't convert to text (fixes #12027) (#12031)
• e85d27a Fix: no-regex-spaces false positives and invalid autofix (fixes #12226) (#12231)
• b349bf7 Fix: prefer-named-capture-group incorrect locations (fixes #12233) (#12247)
• 7dc1ea9 Fix: no-useless-return autofix removes comments (#12292)
• 0e68677 Fix: no-extra-bind autofix removes comments (#12293)
• 6ad7e86 Fix: no-extra-label autofix removes comments (#12298)
• acec201 Fix: no-undef-init autofix removes comments (#12299)
• d89390b Fix: use async reading of stdin in bin/eslint.js (fixes #12212) (#12230)
• 334ca7c Update: no-useless-rename also reports default values (fixes #12301) (#12322)
• 41bfe91 Update: Fix handling of chained new expressions in new-parens (#12303)
• 160b7c4 Chore: add autofix npm script (#12330)
• 04b6adb Chore: enable eslint-plugin-jsdoc (refs #11146) (#12332)

There are 32 commits in total.

See the full diff

FAQ and help

There is a collection of frequently asked questions. If those don’t help, you can always ask the humans behind Greenkeeper.

---

Your Greenkeeper Bot 🌴

An in-range update of eslint-plugin-mocha is breaking the build 🚨

The devDependency eslint-plugin-mocha was updated from 6.1.1 to 6.2.0.

🚨 View failing branch.

This version is covered by your current version range and after updating it in your project the build failed.

eslint-plugin-mocha is a devDependency of this project. It might not break your production code or affect downstream projects, but probably breaks your build or test tools, which may prevent deploying or publishing.

Status Details

• ❌ continuous-integration/travis-ci/push: The Travis CI build failed (Details).

---

Release Notes for 6.2.0

Enhancements

• Startup Performance Optimization (#214)

Commits

The new version differs by 6 commits.

• 8b3841c 6.2.0
• afd749b Update benchmark budget
• fad9229 Merge pull request #214 from lo1tuma/startup-perf
• 5d81cec Run benchmarks as part of npm test
• ed90040 Import only required ramda functions
• de9ef9f Add simple benchmark to measure startup time

See the full diff

FAQ and help

There is a collection of frequently asked questions. If those don’t help, you can always ask the humans behind Greenkeeper.

---

Your Greenkeeper Bot 🌴

Have double quotation to return the exact restaurant name

For example -
`
/10bis ליב

10Bis APP
Found 11 restaurants
[1] פיצה פרגו : https://www.10bis.co.il/Restaurants/Menu/Delivery?ResId=13365
[2] בישולים : https://www.10bis.co.il/Restaurants/Menu/Delivery?ResId=8447
[3] ליב : https://www.10bis.co.il/Restaurants/Menu/Delivery?ResId=5272
[4] בורגרים קרליבך : https://www.10bis.co.il/Restaurants/Menu/Delivery?ResId=7944
[5] אוליברי : https://www.10bis.co.il/Restaurants/Menu/Delivery?ResId=12075 Show more…`

While I wanted exactly "ליב" (the 3rd).

So -- best solution is to use /10bis "ליב" to filter only the exact relevant restaurant

An in-range update of snyk is breaking the build 🚨

The dependency snyk was updated from 1.231.1 to 1.232.0.

🚨 View failing branch.

This version is covered by your current version range and after updating it in your project the build failed.

snyk is a direct dependency of this project, and it is very likely causing it to break. If other packages depend on yours, this update is probably also breaking those in turn.

Status Details

• ❌ continuous-integration/travis-ci/push: The Travis CI build failed (Details).

---

Release Notes for v1.232.0

1.232.0 (2019-10-07)

Features

• convert nodejs to use multi format (468ec63)
• rename sub project to project name (fb43699)

Commits

The new version differs by 5 commits.

• c2b3b82 Merge pull request #798 from snyk/chore/tidy-policy
• 54169eb Merge pull request #773 from snyk/feat/node-js-mutli-project-format
• 30a4198 chore: tidy snyk policy file
• fb43699 feat: rename sub project to project name
• 468ec63 feat: convert nodejs to use multi format

See the full diff

FAQ and help

There is a collection of frequently asked questions. If those don’t help, you can always ask the humans behind Greenkeeper.

---

Your Greenkeeper Bot 🌴