The flowhub from haaksmash

Init should actually do something/be required?

Right now it's just just fluff for running any command for the first time.

At the least, the config prompts should be pulled into their own function - they're not really part of any authing

dicts module tests

Provides tests for the dicts module and adds a few features/fixes while we're at it.

Release: add --direct option

so that you can skip the release branch phase if you really want to

if a repo isn't a fork, feature publish breaks

since it expects a parent.

publish feature should only ever talk to develop

right now you'll PR into the release branch if one exists. Not good!

Quorum on a ballot-by-ballot basis

As opposed to measure-by-measure. Need to bring this up with the VP's.

I think this is because you can abstain from the ballot, and that doesn't get us closer to quorum? Hard to say.

add a `feature accepted` command

There should be a feature accepted command that deletes branch heads from the named or current feature, returning you to the develop branch.

feature publish should present the url of the pull request.

That way we don't have to hunt around for it.

When something bad happens, it's messy

The user has to manually rm their .git/conf.lock if anything happens - say, they type their password in incorrectly. That's a pain in the ass.

switch from print to stdout

right? i think it's better style to use stdout...

AssertionError on feature accepted

hah of course as soon as i decide it's been lost to the sands of time the issue returns:

see #14 for a full traceback. I think this is a bug outside of flowhub's control:

> flowhub feature accepted
Caught exception:
AssertionError - len(["40c05e7277e2f48c1de91249e77beb90e03a6c47\t\tbranch 'feature/14-double-trouble' of https://github.com/haaksmash/flowhub\n", "9e3763c0319a5260211f5582c1211bf0c608c73a\tnot-for-merge\tbranch 'develop' of https://github.com/haaksmash/flowhub\n", "f5bb658bb9340585b40b73b6ad956d8b4bcffaf9\tnot-for-merge\tbranch 'master' of https://github.com/haaksmash/flowhub\n"]) != len(['POST git-upload-pack (961 bytes)', ' = [up to date]      feature/14-double-trouble -> origin/feature/14-double-trouble', '   a49c9fc..9e3763c  develop    -> origin/develop', ' = [up to date]      master     -> origin/master'])

Support other hosts besides GitHub

in particular, GitLab (which I've been using for my own projects recently)

All the commands (except publish) should be available 'offline'

That is, the --no-gh switch should be honored.

Should be able to resume things if interrupted

For example, if there's a problem pushing tags during release publish, you should be able to continue by saying release publish again.

All the docstrings

Most functions in Engine don't have any docstrings; this should be amended. They don't have to be super intense, just adequate.

Handle API exceptions more gracefully

e.g.,

GithubException - 422 {u'documentation_url': u'https://developer.github.com/v3/pulls/#create-a-pull-request', u'message': u'Validation Failed', u'errors': [{u'message': u'No commits between develop and feature/bump-gitpython', u'code': u'custom', u'resource': u'PullRequest'}]}

Should just be surfaced as "whoops, looks like you don't have any commits to publish"

List currently open issues

Maybe default to ones assigned to you, and with a flag for ones that aren't assigned to anyone?

This represents an entirely new way to organize flowhub's internals. That's a little scary, yes -- but remember, flowhub needs to be testable. This (LARGE) change makes it emininently more unit-test friendly (PS - think about switching from unittest to testify), and paves the way for better separation of concerns and extensions.

Release, hotfix, and feature critical dealios all appear to work (though i've been having some trouble with mock behaving properly, so who's to say for sure). Flowhub is creating this pull request, for what it's worth :)

Test Issue

No description provided.

New branch type: collaborative

Prefix: collab/<original-branch-identifier>/<collab-branch-name>

which pull-requests into the original branch, rather than develop. very similar to feature branches.

init doesn't work

exits with the error 'Section' object has not attribute 'prefix'

Feature: if issue specified, assign to this user (if possible)

To reduce accidental duplicated effort, it makes sense for one person starting a feature based on an issue to either assign that issue to themselves or leave a comment saying they're working on it.

This would obviously need a flag to turn off; --no-claim, for example? the default should be to claim.

lol

switch to testify as testing framework?

I like it better than unittest...

hotfixes should be applied to release branches, if they exist.

Right now, they're unilaterally applied to develop

cleanup requires #.#.# naming for hotfix and release to work properly

We should figure out a different way. maybe adding release-contribute/ and hotfix-contribute/ as prefixes to contribution branches?

then release/hotfix contribute can take a branch name as an optional argument and if provided create a new branch with the proper prefix.

dicts module tests

writes tests for the dicts module and implements some features/fixes while we're at it.

Summary missing some info on release start

> flowhub release start 1.1.0                                                    

Summary of actions:
 - New branch release/1.1.0 created, from branch develop
 - Pushed release/1.1.0 to origin
 - Checked out branch {}

that last {} should probably be getting interpolated with release/1.1.0.

When creating a feature from an issue, ask if you want it to be assigned to you

Password required too many times

When release publish is run, you have to input your github password three times. that's at least two times too many, and maybe more times too many than that.

We should see if there's a way to reduce the number of password-entries required, or provide a utility that auto-auths (via public key, for example)

When exceptions are caught, we should be more helpful

Right now we kinda leave the user hanging - just printing the exception and exiting. We can do better than that, especially since some exceptions have very clear causes.

add command for branching off release

flowhub release branch or something.

Then it does a fetch and branches off the head of canon's release if available. Errors if no release found?

Probably do a similar thing for hotfixes - separate issue, though

The latest release is borked.

The last release introduced some untested functionality (which just goes to show that we really ought to be testing more than we are, which is to say "at all"). On the list:

there's a string inside a function call without a format, resulting in a {} being written to the git config file globally. That's messed up.

There's also a config file race condition due to overzealous re-initialization of the config writer.

Among other things, but those are the most important.

Expose pull-requests directly, if desired

something like

flowhub pullrequest [--from <source-branch-name>] <target-branch-identifier>

for arbitrary pull-requesting from the command line.

There should be a better division between the engine and the command line.

Right now, the engine has command liney things going on; these should all be split out and moved to core. The engine should be a normal object whose methods the core happens to utilize.

Feature: have work switch more intelligently

Rather than having to specify the entire name, should only have to specify enough of the name that it is uniquely determinable. If it isn't unique-determining, show the branches that are matched:

> flowhub feature work tank
Possible branches:
 feature/tank_top_wars
 feature/tanks_on_top

> flowhub feature work tanks
Switched to feature/tanks_on_top

haaksmash / flowhub Goto Github PK

flowhub's People

Contributors

Stargazers

Watchers

Forkers

flowhub's Issues

Recommend Projects

Recommend Topics

Recommend Org