hacel/recent

recent's Issues

Creating another .log file

Hi, is it possible to add an option to create another log file?

For example, we will have history.log and favorites.log at the same time. History.log will log as usual. But favorites.log, with a different shortcut, will log whatever user chooses to log.

recent.lua after source removal

Dear developer(s),

Thank you very much for the recent.lua script! Very nice functionality! Thank you so much for making and sharing it!

I encountered a link to this plugin on the mpv user scripts github page and thought it was very useful functionality. Two circumstances that I encountered or can think of:

1. The source file has been deleted/moved/renamed after the creation of the history.log file
2. The source file has been deleted/moved/renamed after displaying the history.log onto the mpv OSD

For my setup this leads to a hard abort of the mpv player (crash?). To me it seems more desirable to in the mpv OSD omit those files from the history log that are no longer available (point 1) and to throw a message/warning onto the OSD when a file is selected that is no longer available (point 2). To achieve this behaviour in my copy of recent.lua I have added the following function (copied from stackoverflow):

function file_exists(name)
    local f=io.open(name,"r")
    if f~=nil then io.close(f) return true else return false end
end

and in the function read_log_table substituted return {title = t, path = p} with:

if file_exists(p) then return {title = t, path = p} else return nil end

and in the function load substituted mp.commandv("loadfile", list[#list-start-choice].path, "replace") with:

if file_exists(list[#list-start-choice].path) then mp.commandv("loadfile", list[#list-start-choice].path, "replace") else mp.osd_message("Failed loading file: "..list[#list-start-choice].title) end

My apologies for posting this comment here as technically it does not concern a script issue, but I just wanted to share this as perhaps you (the developer) or someone else may like this behaviour as well and like to incorporate it in their recent.lua script. If not, please feel free to ignore my comments ;)

Thanks again for sharing your great work!!

With kind regards,
Happy user

[Feature Request] Load video on mouse click

Any way to implement loading a video on mouse click (MBTN_LEFT)?
A somewhat similar script, mpv-chapters is capable of changing chapters on mouse click.
Or is there a limitation preventing this functionality?

[feature request] Adding pages or scrolling to be able to see more recents.

Would be nice if we could view more recents. Best you can do at the moment is change the font size smaller so you can view more on the screen at once.

https://github.com/NurioHin/mpv-bookmarker does this well for example. I don't expect it to be easy but if it could be implemented in some way it'd be great either by pages, or scrolling.

The ‘list_show_amount’ option in the recent.conf file does not work

list_show_amount=10:

list_show_amount=20:

list_show_amount=1:

It always shows ten records.

Add it mplug script directory

Mplug is like a package manager but for mpv scripts.
Please add your script there (if already not there) and also installation instructions in manifest - https://github.com/Nudin/mpv-script-directory/blob/master/HOWTO_ADD_INSTALL_INSTRUCTIONS.md

Streamings and Youtube videos won´t load

When a Youtube video or a magnet link or some streaming link is in the history, when loaded it gives an error "failed loading file". It works fine with local files and .torrent files (with webtorrent script).

Blink and dissapear, when video is playing

It shows last videos only on start video. When video is playing, it blinks on ms and then dissapear when i press key binding. Probably it was not the last version. Is it fixed?

Script does not prompt OSD/ answer to the shortcut

The script prompts OSD properly only the first time after moved into the ~/.config/mpv/scripts directory, and then not anymore. Yet the history.log file keeps uploading. If I delete and readd it to the directory, it works again but still only the first time running.

I'm using IINA on macOS.

A shortcut is assigned to the script in the app's preferences:
script-binding display-recent

Besides, I appended this to the script:
mp.add_forced_key_binding(o.display_bind, "display-recent", display_list)

The other mpv scripts I installed don't have this issue.

mpv log:
[ 0.533][v][cplayer] Running hook: recent/on_unload
[ 0.534][w][recent]
[ 0.534][w][recent] stack traceback:
[ 0.534][w][recent] /Users/axzo51/.config/mpv/scripts/recent.lua:290: in function 'fn'
[ 0.534][w][recent] mp.defaults:544: in function 'handler'
[ 0.534][w][recent] mp.defaults:486: in function 'call_event_handlers'
[ 0.534][w][recent] mp.defaults:520: in function 'dispatch_events'
[ 0.534][w][recent] mp.defaults:479: in function <mp.defaults:478>
[ 0.534][w][recent] [C]: ?
[ 0.534][w][recent] [C]: ?
[ 0.534][f][recent] Lua error: /Users/axzo51/.config/mpv/scripts/recent.lua:290: attempt to compare nil with number
[ 0.535][d][recent] Exiting...

error: can't convert to number!

When I change key bind I get below errors.

error: can't convert to number!
script-opts/recent.conf:3 error converting value '' for key 'auto_save_skip_past'

I have done so far. Changed below lines in two files.

recent.lua

display_bind = "7",

recent.conf

display_bind=7

That would be really awesome if I am able to add

Recent changes break path display.

@dyphire

52f6465 broke show_paths=true for osc. It only displays filename+extension, while uosc still shows full paths correctly:

 

Then next commit (584ac4d) broke displaying paths for both osc and uosc.

And current version just crashes when using show_paths with default osc

[recent] 
[recent] stack traceback:
[recent] 	...op/mpv-x86_64-v3-20240531-git-481e498/scripts/recent.lua:110: in function 'get_filename'
[recent] 	...op/mpv-x86_64-v3-20240531-git-481e498/scripts/recent.lua:278: in function 'draw_list'
[recent] 	...op/mpv-x86_64-v3-20240531-git-481e498/scripts/recent.lua:393: in function 'display_list'
[recent] 	...op/mpv-x86_64-v3-20240531-git-481e498/scripts/recent.lua:444: in function 'prop'
[recent] 	mp.defaults:410: in function 'handler'
[recent] 	mp.defaults:513: in function 'call_event_handlers'
[recent] 	mp.defaults:555: in function 'dispatch_events'
[recent] 	mp.defaults:506: in function <mp.defaults:505>
[recent] 	[C]: at 0x7ff681fa4e80
[recent] 	[C]: at 0x7ff681fa3ce0
[recent] Lua error: ...op/mpv-x86_64-v3-20240531-git-481e498/scripts/recent.lua:110: bad argument #1 to 'split_path' (string expected, got nil)

---

I didn't check how it behaves with mpv-menu-plugin, but probably not any better.

Streams such as `rtmp://` won't load from recents

the script treats them as local files and prepends current directory to the url