Giter Site home page Giter Site logo

Comments (10)

hakimio avatar hakimio commented on June 1, 2024

Does this ever happen when dev tools are not open?
Anyway, you can try to set delayBeforeStepShow to see if that helps.

from ngx-ui-tour.

SebastianStehle avatar SebastianStehle commented on June 1, 2024

It happens while I am on a step and the backdrop is always visible. When I then turn on developer console, the backdrop is not updated. If I resize the window normally it gets updated.

from ngx-ui-tour.

hakimio avatar hakimio commented on June 1, 2024
  • Does this happen when developer console is not open? Yes or No?
  • Have you tried delayBeforeStepShow to see if it helps?
  • Does this happen when using smooth scroll feature?
  • Can you reproduce the issue on Stackblitz without dev console: https://stackblitz.com/edit/angular-wau2z8 ?

from ngx-ui-tour.

SebastianStehle avatar SebastianStehle commented on June 1, 2024

I think you get me wrong. The flow is as followed:

  • You go to a step, then the backdrop renders properly
  • If you then open the developer console, the backdrop is not repositioned, because the resize event is not triggered.
  • Therefore scolling and delayBeforeStepShow has no impact.

from ngx-ui-tour.

hakimio avatar hakimio commented on June 1, 2024

If it's caused only by opening dev console, I don't think that's an issue for normal users.
If you manage to consistently reproduce the issue without dev console open/close, feel free to submit a new issue.

from ngx-ui-tour.

SebastianStehle avatar SebastianStehle commented on June 1, 2024

I can reproduce it here: https://stackblitz.com/edit/angular-wau2z8-lbkisp?file=src%2Fstyles.scss

You need a scroll container for that (see .container class). It also happens when I resize the window with Window + Arrow keys. So it also affects other users.

from ngx-ui-tour.

hakimio avatar hakimio commented on June 1, 2024

That's not a bug with the library. When you are using custom scroll container, you have to specify it using scrollContainer config: scrollContainer: '.container'. Then everything works fine.

from ngx-ui-tour.

hakimio avatar hakimio commented on June 1, 2024

Ok, another issue with your demo is that you have two main content scroll containers (.container and html). Normally you would have only one.

from ngx-ui-tour.

hakimio avatar hakimio commented on June 1, 2024

Here is your reproduction fixed and working as intended: https://stackblitz.com/edit/angular-wau2z8-towkfa

from ngx-ui-tour.

SebastianStehle avatar SebastianStehle commented on June 1, 2024

Thanks. I found the same solution. I think I would probably set the html and body to overflow: hidden dynamically, because I cannot foresee what could actually break, if I change that, but this seems to work.

from ngx-ui-tour.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.