Giter Site home page Giter Site logo

Comments (4)

hakimio avatar hakimio commented on May 18, 2024 1

When you manually provide the services instead of just importing the module, your tests will be prone to breakage on every library update. Either provide a mock implementation of TourService or import the module like you do in your application.

You had to provide TourBackdropService from core library instead of md-menu in your test because backdrop service usage was moved from UI libraries to core. This is not a bug.

from ngx-ui-tour.

hakimio avatar hakimio commented on May 18, 2024

Can you create a reproduction of the issue in a GitHub repo?
Do you have a stack trace of the error?

from ngx-ui-tour.

hakimio avatar hakimio commented on May 18, 2024

Can't reproduce the issue.
Demo project attached. Dependencies have to be installed with yarn.
tour-unit-testing.zip

from ngx-ui-tour.

Shaent avatar Shaent commented on May 18, 2024

Sorry for answering this late. I looked at your demo project which uses jest for unit testing. We are still using karma for unit testing in our project, maybe this is causing the issue.

I will try to reproduce the issue with a project using karma, if I have the time.

Another difference is that we provide the necessary Service to the test by using the providers property:

  beforeEach(async () => {
    await TestBed.configureTestingModule({
      imports: [RouterTestingModule, HttpClientTestingModule],
      declarations: [TourStepTemplateComponent],
      providers: [
        AuthService,
        TourService,
        TourBackdropService,
      ],
    }).compileComponents();
  });

from ngx-ui-tour.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.