halitechallenge/halite-iii

Season 3 of @twosigma's artificial intelligence programming challenge

halite-iii's Issues

Make ship instances persistent in all the languages

Inspired by #80
Will also need to reupload kits to online editor.

Graphs under player stats are cut off (sometimes?) in Firefox

I noticed it particularly in this game: http://halite.io/play/?game_id=717656&replay_class=0&replay_name=replay-20181019-051624%2B0000-1539926174-64-64

Chrome (looks right):

Firefox (huh, didn't Mustcontain win this game?):

It doesn't seem to happen for every game - I think this game is the only example of it I could find, after checking out maybe 10 or so.

additional colorblind theme

Following up on discussion in Discord. We'd like to have a proposal from community on colors that work.

Checklist for new kits

Thoughts for now:

• can take own rng seed as first cmd line arg
• normalization handles negative coordinates
• instances of ship class are reused between turns as needed

The "challenge" button doesn't work

Neither the button on user analysis pages nor the link on the leaderboard. I'm on Firefox 62.0.3 (64-bit).

code in tutorial appears to be indented by single space

Fix inconsistent event timing in visualizer

Spawns are processed at frame start, but collisions are processed at frame end

'--results-as-json' is incompatible with '--no-replay'

To reproduce, run the engine like this:

halite.exe --no-replay --results-as-json my_bot.exe my_bot.exe

Expected JSON output, but it prints nothing.

no-timeout doc vs code inconsistency

Apparently docs mention --no-timeouts but code takes --no-timeout.

Change compiler to set executable bit on install.sh as worker user

Reconcile C# starter kits

These are the known C# starter kits:

1. https://github.com/Jorge1o1/halite3-cs-starter-bot
2. #12
3. #14
4. #23

Add Ruby Starter compile check to CI build.

This should match the other compile check steps.

Starter Kit - Erlang

Process termination in game engine

Currently processes are forcefully terminated at the end of the game.

Halite-III/game_engine/networking/unix/UnixConnection.cpp

Lines 89 to 91 in 7b7deb7

	UnixConnection::~UnixConnection() noexcept {
	kill(-process, SIGKILL);
	}

Halite-III/game_engine/networking/win32/WinConnection.cpp

Lines 99 to 110 in 7b7deb7

	WinConnection::~WinConnection() noexcept {
	if (read_pipe != INVALID_HANDLE_VALUE) {
	CloseHandle(read_pipe);
	}
	if (write_pipe != INVALID_HANDLE_VALUE) {
	CloseHandle(write_pipe);
	}
	if (process != INVALID_HANDLE_VALUE) {
	TerminateProcess(process, 0);
	CloseHandle(process);
	}
	}

The use of SIGKILL inside UnixConnetion.cpp forcibly shuts down the process without giving it a chance to clean up. Thus, atexit handlers, such as the ShutdownHooks inside Log.java of the Java kit, do not have a chance to run. While I am not as familiar with process signalling on Windows, this article form Dr. Dobbs suggests that TerminateProcess in WinConnection.cpp is equally dangerous.

My suggestion would be using a gentler process of sending SIGTERM (and its Windows equivalent) to give the process a chance to clean up, and then using forcible termination after a short delay if the process hasn't exited by then. This allows higher level languages to perform internal cleanup operations and would also allow users to write their own cleanup functions, e.g. to flush log files.

"Efficiency" has conflicting definitions

In the visualiser there's this statistic next to the score, and when you mouseover it it defines efficiency as "current halite / halite collected" (i.e. where collected means 5000 + all deposits ever made).

But this is very different from the concept of efficiency in a player profile, which I believe is something like deposits / non-inspired mining?

My bot can't move...

Examples:

1. https://halite.io/play/?game_id=776803&replay_class=1&replay_name=replay-20181021-065751%2B0000-1540104221-56-56-776803
2. https://halite.io/play/?game_id=773475&replay_class=1&replay_name=replay-20181021-035417%2B0000-1540093306-40-40-773475

And some other 4 player games from v15 of my bot.

I found this odd, because my code is moving the ships from the start...

I downloaded the replay from the example 1 (unzip):
776803.hlt.zip. I'm watching it in https://github.com/fohristiwhirl/fluorine. However I don't see the log of my bot. I found it was run with --width 56 --height 56 -s 1540104221 so I tried to reproduce it locally with run_game.sh:

./halite --replay-directory replays/ -vvv -n 4 --width 56 --height 56 -s 1540104221 "./MyBot" "./MyBot" "./MyBot" "./MyBot"

But this runs game with 4 bots of mine and then everything works.

Accept zip files with only CMakeLists.txt

Java Starter Kit isn't correctly working on Windows

Error:

Turn 1

error: failed to decode bot message: "C" (at position 1)
Last input received was:
Caused by: java.lang.ClassNotFoundException: MyBot

Appears to happen in Windows 10 with the following Java versions installed:
Java 8 (171)
Java 10.0.2

Julia Starter Kit

I am working on a julia starter-kit. Will have a PR ready soon. Shout out to me if anybody wants to join.

Starter kit - C#

Follow this guide to create a new starter kit for C#.

Starter kit - PHP

getSurroundingCardinals missing in some of the kits

Missing in:

• Java
• Go
• Kotlin
• Scala

Problems with halite executable

From https://github.com/HaliteChallenge/Halite-III/blob/master/starter_kits/C%2B%2B/README.md:

Linux users: if you're having problems running the bundled halite executable, you will probably want to build your own from source.

Where is the bundled halite executable?

I also tried to build game_engine (this will produce halite, right?) with:

cmake .
make

with gcc 7.3 and 8.1 on Ubuntu 16.04 compatible OS, but make fails with:

ld: unrecognized option '--push-state--no-as-needed'.

Auth support for forums

Users are unable to login to forums.

stderr is treated as stdout on Windows

To reproduce, run the engine with the following Python bot:

assert False

On Windows, I get the following results:

.\halite.exe "python3 my_bot.py" "python3 my_bot.py"

[info] Map seed is 1539953260
[info] [P0] Launching with command py my_bot.py
[info] [P1] Launching with command py my_bot.py
[info] [P0] Initializing player
[info] [P1] Initializing player
[info] [P0] Initialized player Traceback (most recent call la
[info] [P1] Initialized player Traceback (most recent call la
[info] Player initialization complete
[error] [1] [P1] Communication failed
[error] [1] [P0] Communication failed
[error] [1] [P0] Last input received was:
[error] [1] [P0]   File "my_bot.py", line 1, in <module>
[error] [1] [P0]     assert False
[error] [1] [P0] AssertionError
[error] [1] [P1] Last input received was:
[error] [1] [P1]   File "my_bot.py", line 1, in <module>
[error] [1] [P1]     assert False
[error] [1] [P1] AssertionError
...

This is incorrect. The bot's name clearly isn't "Traceback (most recent call la". And the ending of the diagnostic message is lost!

For comparison, I get much more reasonable results on Linux:

./halite "python3 my_bot.py" "python3 my_bot.py"

[info] Map seed is 1539953470
[info] [P0] Launching with command python3 MyBot.py
[info] [P1] Launching with command python3 MyBot.py
[info] [P0] Initializing player
[info] [P1] Initializing player
[error] [P0] Failed to initialize
[error] [P1] Failed to initialize
[error] [P0] Player's error output was:
[error] [P0] Traceback (most recent call last):
[error] [P0]   File "MyBot.py", line 4, in <module>
[error] [P0]     assert False
[error] [P0] AssertionError
[error] [P1] Player's error output was:
[error] [P1] Traceback (most recent call last):
[error] [P1]   File "MyBot.py", line 4, in <module>
[error] [P1]     assert False
[error] [P1] AssertionError
...

Starter kit - Ruby

Follow this guide to create a new starter kit for Ruby.

naive_navigate shouldn't mark the cell as unsafe

I can't comment for the other starter kits, but I don't think naive_navigate function should mark the cell unsafe (here)[https://github.com/HaliteChallenge/Halite-III/blob/ab9b43add935518734bd16f71e257048b2240ff6/starter_kits/Python3/hlt/game_map.py#L235]. For me, this is an unwanted side effect and I think the direction getting function could be split out.

Can I confirm that the bot compiles with the hlt module included in our projects? If this is the case I'll just change it there.

Update CI badges in README

Enable core dumps on workers

Publish new kits

• PHP
• D
• Ruby
• Julia

Engine incorrectly kills player with 1000 halite

Append game ID to replay file key

ML bot fails because of lacking libs

Error:
error: communication error with bot: read failed, errno was: 0 (Success)
Bot error output was:
/usr/local/lib/python3.6/dist-packages/sklearn/externals/joblib/externals/cloudpickle/cloudpickle.py:47: DeprecationWarning: the imp module is deprecated in favour of importlib; see the module’s documentation for alternative uses
import imp
Traceback (most recent call last):
File “MyBot.py”, line 7, in
import model
File “/home/worker/Halite/apiserver/worker/tmpy76dau6m/496_0_jwjohns/model.py”, line 7, in
from tqdm import tqdm
ModuleNotFoundError: No module named ‘tqdm’

Need to bake these libs into base image

ask for 10x option in replay viewer

Can't delete long entries from leaderboard filter

Reported by Darkproduct on Discord.

Editor doesn't support teams

Incorrectly tries to create a new bot.

Redirect HTTP to HTTPS on website

It would be nice if the halite.io website was available over HTTPS.

Free suggestion:
https://letsencrypt.org/

Improve information density

Challenges: give rank, tier, and %/# of games won. Link to games played.

Visualizer: give tier; move unit selection card to floating window.

Overall: maybe a long press/hover popup widget for quick user info?

rust compiler should not error on warnings

After that we can switch to cargo build, instead of rustc.

[python starter kit] Move class Player out of game_map.py into player.py

If the Python starter kit is intended as the most accessible for aspiring AI developers, it's eventually worth moving the Player class out of game_map.py and into its own file.

At this stage of the competition it may temporarily create some backwards compatibility issues if anyone is importing the Player class from game_map, but that's unlikely to be a significant issue because:

1. There was no need to import Player anywhere in my first 20+ hours on my Python submission. The instance is accessible easily enough via game.Me and there's little reason for developers to actually import it.
2. Considering the above, anyone who 1) has found the Player class hiding in game_map.py, and 2) imports it into one of their files for whatever reason ==> is likely savvy enough with Python to immediately understand and fix the import error in under ~5-10 seconds if they need to shift it in their own code.

ref: https://github.com/HaliteChallenge/Halite-III/blob/master/starter_kits/Python3/hlt/game_map.py#L9

Local and online games play out differently

Two of my ships always collide immediately (upon spawning) when playing games online, leaving me with only 3 ships to start with every game.

However, there was no such problem when I was running games locally. I always successfully resolve their movements without collision and start with 5 ships every time.

Please help look into this, thanks!

add map height/width to constants

Then add "normalize" function to position class.

Install -dev packages

so that people can build extensions, etc

Segfault when issuing commands to nonexistent ships

Found by ChatTor on Discord:

Anyway, I found a seg fault in the halite executable for Linux and am not sure what causes it. I can reproduce it with the following:
Round 1: Send g\n\n 
Round 2: Send g\nm 0 s\n\n 
It seems to seg fault immediately after that

32 bit window version might not actually be 32 bit

Windows build still doesn't show bot names sometimes

Upgrade Lua to 5.3 and enable compilation

Please upgrade the Lua interpreter to Lua 5.3 if possible and enable it in the compiler.py script by differentiating between LuaJIT and Lua 5.3 via an additional file extension, e.g. .lua53 or .luajit.

LuaJIT implements most of Lua 5.2 already, Lua 5.3 is the current standard and has been released over three years ago.

Segmentation fault on Macos

This is hard for me to verify, but I was getting a string of these segfaults this morning. They seemed to happen immediately after statements like this:

[warn] [31] [P1] entity 0 was directed to use 1 halite to move west, but only 0 halite was available [warn] [31] [P0] entity 1 was directed to use 1 halite to move east, but only 0 halite was available [warn] [31] [P0] owned entities 5, 1 collided on cell (9, 16) as the result of moves on this turn [warn] [31] [P1] owned entities 4, 0 collided on cell (22, 16) as the result of moves on this turn run_game.sh: line 6: 18498 Segmentation fault: 11 ./halite --replay-directory replays/ -vvv --width 32 --height 32 "java -jar build/libs/halite3-6.jar" "java -jar build/libs/halite3-6.jar"

I added some more protection around fuel management, and the errors went away.

ERROR: You must upload a .zip file.

The drag and drop upload works fine, but when you use the file selection dialogue, it is validating for
file.type === "application/zip" and browsers sometimes report zips as application/x-zip-compressed.

Tiers are all off by one