halu5071/git-push-hackathon

$ git push hackathon :computer:

git-push-hackathon's Issues

Add dependency of Architecture Components

Overview

• Lifecycle
• VIewModel
• LiveData

and add dependency of android.arch.lifecycle:reactivestreams to convert Observable to LiveData

include auth token on Header

Overview

set auth token on header from NetworkModule

Design of this app

This is my etude.

Design

first I will list up libraries I will use and try to use

• Retrofit
• Rx
• Dagger [try!] => gotcha!!
• Architecture Component [try!]
• Data Binding [try!]
• moshi (&kotshi)
• Stetho
• Leak Canary
• Timber
• Support Library
• Mockito
• PowerMock
• Robolectric

And I adopt Clean Architecture.
usecase package is (probably) my original. In Android-CleanArchitecture repository, usecase is, for example, GetUserDetail.java. I mean the usecase class has a just only one operation. However, in my project, usecase classes are small, and have basic CRUD. So my usecase classes have some operations.

Commit message since 25th Jan

rely on AngularJS DEVELOPERS

Com on kotshi

Overview

try it

Replace OkHttp with Retrofit

Overview

In AuthDataDataRepository, I use OkHttp to fetch access token, but it is consistent.

Add some payloads

Overview

after merging #19

Try paging library

Overview

Just try it.

apply ProGuard

Overview

It is a first time to write ProGuard!!

• Retrofit
• OkHttp
• Glide
  etc

create Login flow

Overview

implement Login flow

• check AuthData on MainActivity
• publish Intent to CustomTab
• get access token

Re-construct Dagger dependencies

Overview

Activity must not know that this app using Dagger injection.

「何によって提供されてるかは、提供される側が考えることじゃない」

— halu5071 (@halu5071) 2018年2月12日

fetch User data

Overview

fetch user data, that's all

Remove AuthDataUseCase

Overview

based on #56 , I will remove AuthDataUseCase.
thus, AuthDataDataRepository has authData

emoji coming

Overview

emoji coming
com.android.support:support-emoji:27.0.2
or
com.android.support:support-emoji-bundled:27.0.2

https://developer.android.com/guide/topics/ui/look-and-feel/emoji-compat.html

[Determined] UseCase&Presenter vs ViewModel

Overview

When I adopt Clean-Architecture, I would have used UseCase to operate Repository. However, after I learned MVVM (and Architecture Component, DataBinding), UseCase classes are redundant I think.

hmmm

TBD

Dependency Injection

Overview

implement a basis of DI, using Dagger2

AppInjector
  |
AppComponent - AppModule
  |- MainActivityComponent - MainActivityModule (Subcomponent)
  |- etc

Some response observable must contains retrofit2.Response

Overview

In some resources, I want to use pagination which needs Link header. So It must contains raw response.

• events
• (repository)

Pagination object must manage in some instance.

• Events which contains Event objects as List have pagination object
• EventUseCase manage pagination object

TBD

[UPDATED 2018/2/5]
After reading this book
Android Architecture Components has android.arch.paging Library (it is alpha version).
I do not know it exactly, but it may be useful. TBD

add Test Dependencies

Overview

add dependencies for test.
For example, the return value from Retrofit must be mocked up without network responses.

Design Activity

Overview

Design

Add Json annotation on enum EventType class

Overview

moshi can create enum class

Add copy right

Overview

Refactor Encryption

Overview

Fix AuthDataDataSource

Overview

when read blank value and convert Json via moshi, app crashed.

moshi can not convert blank to null

Fix AuthDataUseCase and AuthDataRepository

Overview

now AuthDataUseCase convert JSON to AuthData, but this is not desirable. AuthDataRepository (and the implementation class) have a responsibility to generate AuthData.

Solution

NowAuthDataRepository#get() returns String. However, from this issue, AuthDataRepository#get() returns AuthData?

update TestUtil

Overview

can read file from resources

SharedPreference ready

on data layer

• save on SharedPreference
• add Test

Logout flow

Overview

• assign null to authData on AuthDataUseCase
• remove authData from SharedPreferences

Add domain I/F

CRUD on domain Layer

• TokenRepository(I/F)
  • save, get, delete
• EventRepository(I/F)
• UserRepository(I/F)
  • get

Upgrade EventAdapter

Overview

OAuth callback url should be replaced dynamically

Overview

Ooooops!!
OAuth callback url will change when ClientID changes.
So, redirect_host and redirect_schema should be replaced by environment variants

Remove UserUseCase

Overview

After #56

add entity test

Overview

add entity test.
read json from resource directory.

add StringConvertorFactory

Overview

Now I use raw OkHttp to fetch access token, but it is redundant.
Need Retrofit convertor factory to get String data

Refactor Interface

Overview

Fetch feeds from api

Overview

ca-archived#8 (comment)
Roger!!

But I will use event API.

I know that I can fetch event data from https://github.com/:username in atom style after putting Accept: application/atom+xml header, but It is redundant.

because in Android (or iOS) program, atom style xml is not useful but JSON is a common way to represent some data from the server.

/users/:username/received_events

• retrofit interface

come on SwipeToRefresh

Overview

implement SwipeToRefresh

Create custom json adapter for parsing Event payload

Overview

There are various payloads on event data, so moshi can not parse them by default.

I will create a custom json adapter for each payloads.
Fortunately, I have learned to make custom json adapter in my post

• see type field
• determine which instance moshi will convert

Cache event data on EventCache

Overview

cache event data on EventCache.kt of data layer.
It means event data exist Remote and Local.
EventDataRepository decide from which resource should read.

Add dependency of Paging Library

Overview

try it !!!

• https://developer.android.com/topic/libraries/architecture/paging.html
• https://android.jlelse.eu/android-paging-library-make-your-lists-as-efficient-as-possible-literally-in-just-an-hour-5abf797585bd

ready Entity

on domain layer

In this app, data layer does not have entity package, because both data and domain layer will use the same entities, and data layer can use entities on domain layer

• User
• AuthData
  TBD...

Add Test

basis of Dependency Injection

on presentation and data layer

• data layer
  NetworkModule which provides okhttp, retrofit and retrofit service

• presentation layer
  AppModule which provides context and concrete instance of Repository on data layer

Apply Android-KTX

Overview

Android-KTX coming. So I will replace code of SharedPreferences with KTX.
https://android-developers.googleblog.com/2018/02/introducing-android-ktx-even-sweeter.html

Glide coming

Overview

add dependency for Glide

encrypt AuthData

Overview

on AuthDataDataSource

• AES/CBC/PKCS5Padding
• encrypt AuthData
• add Test

[UPDATED]
https://developer.android.com/training/articles/keystore.html#SupportedAlgorithms

• RSA/ECB/OAEPWithSHA-256AndMGF1Padding

call onCleared() on EventViewModel

Overview

ready for fetch Event data

Overview

• add entity Event
• enum EventType
• each EventPayload

I know there is org.eclipse.egit.github.core, but that library use gson and some other redundant class contains, and some field is not enough. So I will not use the library

SharedPreference Test

Overview

Remove unnecessary Inject annotation

Overview

I realized some @Inject annotation is unnecessary. Remove it.