Giter Site home page Giter Site logo

hamidb80 / subtitle-editor Goto Github PK

View Code? Open in Web Editor NEW
35.0 2.0 3.0 5.73 MB

a web based subtitle editor

Home Page: https://hamidb80.github.io/subtitle-editor/

License: MIT License

HTML 2.16% TypeScript 82.41% Sass 14.82% JavaScript 0.61%
subtitle-editor react subtitle web-application

subtitle-editor's Introduction

web based subtitle editor

health and safety are 2 forgotten gifts among people - Muhammad the prophet

ReadMeSupportPalestine

demo

you can see demo here

screenshot image

features

  • shortcuts/mouse
  • undo/redo
  • nice ux/ui [native components - no external UI libraries]
  • loads resources with query params http://APP?video=URL&subtitle=URL where APP is demo url

commands:

npm install yarn if you dont have Yarn:

yarn install install dependencies

yarn start Runs the app in the development mode.

yarn build Builds the app for production to the build folder.

subtitle-editor's People

Contributors

ama-coder avatar hamidb80 avatar

Stargazers

 avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar

Watchers

 avatar  avatar

subtitle-editor's Issues

moving time-ruler is so damn slow

depending on the length of the video, moving time-ruler can become very costly; causing animation and interactions running super slow

Bugs/feature requests

You've done nice work here.

Issues:

  • For whatever reason, most of the zoom values collapses (shrinks) the box containing the transcription.

Suggestions for UI Enhancement:

  • Enlarge the timeline bar (text transcription bar) to ensure complete sentence display.
  • Incorporate a waveform display beneath the text to offer a visual aid for easier transcription.
  • Enable direct editing within the selected box (square with current transcription) instead of a separate editing box.
  • Integrate the progress bar into the timeline bar for streamlined progress tracking.
  • Relocate the "save as file" option to the top navigation bar, freeing space for the timeline and waveform, while dedicating the bottom section solely for editing.

Bugs/feature requests

Two features you added look really good!

I think it's pretty close to being very functional.

I'll add the features that to me are still missing to make it very intuitive:

  1. Spacebar should start/pause video (helps get to the exact point when changing subtitle timings)

  2. Ability to drag the timeline to move the video forward/backwards
    Screen Shot 2023-04-21 at 2 57 05 PM

In this screenshot, if I put my cursor over the 17 second mark it shows a pointer, but I should be able to drag starting at that number and move the timeline backwards or forwards and have it change the video time.

Also, you can see there's a bug, if the video is too long and you zoom in the timeline stacks on top of eachother and it bugs the functionality (I changed the dom manually in that screenshot)

Also, I think you should be able to zoom in past what is currently the limit of 100 to be able to have precision with the timestamps.

Also, I think you should be able to drag to change the start/end timing of the subtitles without selecting the timestamp. Clicking it each time is not very intuitive, I think it would be better to be able to grab the ends without it.

Also, when you are dragging to change the duration, you should be able to see the space that it is filling (or it should show that it's being shortened). It should track with the dotted redline above it when you drag. Same thing with the drag, you should be able to see it as it's moving rather than it jumping (will help to line up ends/beginnings with certain time segments etc)

Also, I think this should be widened. Sometimes the subtitles can be longer and there's extra space around so may as well use it. (I like the feature to click to change from right-to-left text and left-to-right languages!)
Screen Shot 2023-04-21 at 3 01 51 PM

Also, I think a single click should deselect the subtitle the same way a single click selects it. I like how it repeats when it's selected but that will help to quickly unselect it, the escape button is not super intuitive.

Also, clicking anywhere on the video should start/stop it. Spacebar is the best solution but at least that will be much better since the video will have to be stopped/restarted a lot.

Anyways, I think you have a very solid foundation here, it's up to you if you want to implement these but I looked far and wide and there's no real good online subtitle editor solutions so I think this could become the default open source online subtitle editor, it's the only one I'm interested in using at the moment.

Thanks for your work, cheers!

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    ๐Ÿ–– Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. ๐Ÿ“Š๐Ÿ“ˆ๐ŸŽ‰

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google โค๏ธ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.