handsetdetection/php-apikit

Handset Detection v4 API kit for PHP

php-apikit's Issues

Does only work with APC currently

Since i saw the new release, i gave the lib another try to integrate it to https://github.com/ThaDafinser/UserAgentParser

But i could not finish it.

First off, the cache cannot be changed to another then APC

• the Cache instance does not receive parameters

  • php-apikit/src/HDStore.php

    Line 54 in b70691b

    $this->Cache = new HDCache();

  • php-apikit/src/HD4.php

    Line 114 in b70691b

    $this->Cache = new HDCache();

Some methods also have missing parameters, e.g.
https://github.com/HandsetDetection/php-apikit/blob/master/src/HD4.php#L242

php-apikit/src/HDDevice.php

Line 115 in b70691b

function localView($vendor, $model) {

Detection Language Issue preventing Device Detection

Hi,

We are getting errors like *Undefined index: en_us*​ ​_HDExtra.php@117_​ after deploying code using this package. This prevents scripts from completing device detection and results in a fatal error.

Locally, and on our beta server, we never saw this error.
Not sure if this is a permissions issue or something else.

Looping in @artkay

Reuse of instance not possible

If you reuse the same HD4 instance, sometimes the results are from previous detections.

$parser->deviceDetect($headers);
$resultRaw = $parser->getReply();

$parser->deviceDetect($otherHeaders);
$resultRaw = $parser->getReply();
//...the result can be from previous detection

I tried already to set

$parser->reply = [];
$parser->rawreply= [];
$parser->detectRequest = [];

But that seems not enough.

Bot result

If a userAgent is a bot, the result model is populated although it's not a model

Is there any criteria to detect bots?

Array
(
    [general_vendor] => Coc Coc Company Limited
    [general_model] => Spider
    [general_platform] => 
    [general_platform_version] => 
    [general_platform_version_max] => 
    [general_browser] => 
    [general_browser_version] => 
    [general_image] => 
    [general_aliases] => 
    [general_eusar] => 
    [general_battery] => 
    [general_type] => 
    [general_cpu] => 
    [general_virtual] => 0
    [design_formfactor] => 
    [design_dimensions] => 
    [design_weight] => 
    [design_antenna] => 
    [design_keyboard] => 
    [design_softkeys] => 
    [design_sidekeys] => 
    [display_type] => 
    [display_color] => 
    [display_colors] => 
    [display_size] => 
    [display_x] => 0
    [display_y] => 0
    [display_ppi] => 0
    [display_pixel_ratio] => 0
    [display_other] => 
    [memory_internal] => 
    [memory_slot] => 
    [network] => 
    [media_camera] => 
    [media_secondcamera] => 
    [media_videocapture] => 
    [media_videoplayback] => 
    [media_audio] => 
    [media_other] => 
    [features] => 
    [connectors] => 
    [benchmark_min] => 0
    [benchmark_max] => 0
    [general_app] => 
    [general_app_version] => 
    [general_app_category] => 
    [general_language] => 
    [display_css_screen_sizes] => 
)

Detect if userAgent "not found" vs. zip archive not installed

When using this config

$config = [
            'username' => 'something',
            'secret' => 'something',

            'use_local' => true,

            'log_unknown' => false
        ];

And try to detect a userAgent, you may get Not found.

This can be a real "not found" or the filesdir is not correct.

A custom message for not correct installed or something like that would be good.