hapijs/.github

Default organization policies

.github's Issues

Bug with parsing prerelease versions

Support plan

• is this issue currently blocking your project? (yes/no): no
• is this issue affecting a production system? (yes/no): yes

Context

• node version: v16.4.0-pre
• module version with issue: v20.1.4
• last module version without issue: Not sure
• environment (e.g. node, browser, native): Node
• used with (e.g. hapi application, another framework, standalone, ...): Node.js Platform Test Suite
• any other relevant information: N/A

What are you trying to achieve or the steps to reproduce?

When the Node.js release team tests prereleases for Node.js releases, we run the hapi test suite (configured here: https://github.com/nodejs/citgm/blob/main/lib/lookup.json#L2-L5) as part of tests on the Node.js ecosystem. One of the tests fails consistently due to what looks like a bug with how Somever.match() parses the format of the version.

In this test: https://github.com/hapijs/hapi/blob/master/test/server.js#L2793-L2805, the test will fail on prereleases with the format of something like v16.4.0-pre. process.version will always return vx.y.z, and the tests do a lot of testing for prerelease syntax, so this looks like a bug.

What was the result you got?

Failed tests:
   753) Server register() validates node version:
       Expected [Promise] to not reject with an error but got [Error: Plugin test requires node version >=8.x.x but found v16.4.0-pre]

What result did you expect?

I expected .match() to recognize that v16.4.0-pre is within the range of >=8.x.x.