Slide keeps accessing the clipboard for seemingly no reason

[jakehl]

Slide keeps accessing the clipboard for seemingly no reason

[tmjwid]

To replicate, have a fresh item in the clipboard, load an image then swipe back out and it triggers the clipboard. I too was worried when I first saw this as I had just used a password from my password manager so I spent a good hour profiling the app to see if any network traffic happened when clipboard was triggered. Nothing did but still, it's shouldn't be done in the background with no user notification.

[Alexendoo]

It's not a security risk, it's an old feature that offers to open a reddit link if you have one on your clipboard

Slide/app/src/main/java/me/ccrama/redditslide/Activities/MainActivity.java

Lines 1196 to 1220 in 9d72cce

	public void checkClipboard(){
	try {
	ClipboardManager clipboard = ContextCompat.getSystemService(this, ClipboardManager.class);
	if (clipboard != null && clipboard.hasPrimaryClip()) {
	ClipData data = clipboard.getPrimaryClip();
	final String s = (String) data.getItemAt(0).getText();
	if (!s.isEmpty()) {
	if (ContentType.getContentType(s) == ContentType.Type.REDDIT && !HasSeen.getSeen(s)) {
	Snackbar snack =
	Snackbar.make(mToolbar, "Reddit link found in your clipboard",
	Snackbar.LENGTH_LONG);
	snack.setAction("OPEN", new View.OnClickListener() {
	@Override
	public void onClick(View view) {
	OpenRedditLink.openUrl(MainActivity.this, s, false);
	}
	});
	snack.show();
	}
	}
	}
	} catch (Exception e){
	}
	}

Back then there were no indicators for clipboard access, nowadays it may be worth removing because of that

[tmjwid]

There is an api to read clipboard so apps use it to provide features, what the point of having a clipboard if you dont use it? You could have checked the source or searched posts about it in 1 minute instead, also no serious password manager use the clipboard as it's not secure or they offer it as alternative and you have to enable manually + it warn you about using it, they use the autofill framework or in rare cases where autofill isn't working some have a special keyboard to input password, also i'm reading that since android 11 they can integrate with the default keyboard https://developer.android.com/guide/topics/text/ime-autofill but idk if any password manager use it already.

I did check the source as well as profile the app. Nothing wrong with some extra due diligence just in case I missed something and I felt it was warranted at the time as this feature isn't listed anywhere to my knowledge and it was a bit of a shock. I do agree with you about clipboard security and I am now fixing that with autofill like you mentioned.

[jakehl]

This is absolutely a security risk. regardless of the intention, its still reading the clipboard without any consent from the user.

[Alexendoo]

The code is right there... you can see exactly what it does, which is nothing bad

[jakehl]

closing as the maintainer seems to have no interest in addressing the issue. I've moved to infinity instead.

[karate]

I understand that this was build for the iOS version. Is it supposed to work for Android as well? Links in the clipboard don't load automatically for me in Android 12 with Slide 6.7.1.