hasadna / alaveteli Goto Github PK

This project forked from mysociety/alaveteli

Provide a Freedom of Information request system for your jurisdiction

License: Other

Ruby 72.89% Shell 1.82% CSS 3.16% CoffeeScript 0.08% JavaScript 1.43% Perl 0.30% Python 0.05% HTML 20.05% ApacheConf 0.22%

alaveteli's Introduction

Hasadna monorepo

Installation

Install Bazel. That's it!

Build & Test

Build everything: ./compile.sh build
Run all tests: ./compile.sh test

About monorepos

A monorepo is a software development approach where all code is stored in a single repository. Some things are easier to do in a monorepo, such as sharing a proto file across front-end and backend, some things are harder, such as per-repo control over collaborators, email notifications, commit history etc.

Some monorepo etiquette:

Don't store large files in the repo (>500kb), or many small files. Until we figure out a way to deal with them, you can store them in a different repo.
If you use code belonging to another project, talk to the people of that project about it. If you don't, they might accidentally break your code.
If you change code common to multiple projects, do it thoughfully.
Kindly provide a LICENSE file for your project.

Some good reads about the monorepo approach:

Platforms

While Bazel supports Linux, Mac and Windows, this repo supports Linux and Mac. If you're on Windows 10, you can use Windows Subsystem for Linux (WSL). It gives you a Linux environment, without the overhead of a virtual machine.

Installing Windows Subsystem for Linux:

Please follow the guide. Note: You may have to do a Windows upgrade. If you need it, it will ask for it at the beginning of the installation.

Contributing

You're welcome to contribute and in doing so, learn these technologies. You can have a look at the issues list, or at the project milestones.

Happy coding!

alaveteli's People

Contributors

Stargazers

Watchers

Forkers

itayadler

alaveteli's Issues

Hebrew alphabet for the quick search

We need to have the Hebrew alphabet available on the side panel at the authorities page.

Sending timely reminders

We wish to nudge authorities after 14,45 and 70 days after a request was sent, so they'll do their dutiful job.
Alaveteli should have some capability of this sort, need to figure out what's going on there.

RecordNotFound Error

go to http://www.askdata.org.il/request/request_275
click בקשות דומות נוספות
get redirected to http://www.askdata.org.il/similar/request/458 which throws error RecordNotFound:
Couldn't find InfoRequest with url_title = 458

Feed for twitter

Open a user and provide a constant feed of successful ones.
Here is the feed of partial ones:
askdata.org.il/he_IL/feed/search/ (latest_status:successful OR latest_status:partially_successful)

Text still shows as FOI request on an authority page

Couldn't find it in Transifex (English/Hebrew), perhaps it's hardcoded.

http://askdata.org.il/select_authority?query=%D7%9E%D7%A9%D7%A8%D7%93+%D7%94%D7%90%D7%95%D7%A6&bodies=1&commit=%D7%97%D7%99%D7%A4%D7%95%D7%A9

Authorities list only appears under the English version

When accessing the authorities page in the Hebrew (default) language, they are not shown, but under the /en there is no issue.
Accessing the authority directly works fine (e.g. http://www.askdata.org.il/admin/body/edit/41 vs. http://www.askdata.org.il/en/admin/body/edit/41).

Preventing emails from getting to spam folders

Some Gmail box filter emails form the system as spam, probably since emails still contain records of alaveteli.nsa.co.il (the hosting server).
SPF records are in place, and could be changed if needed.

Mails arrive to old email addresses

Nir sent a request to משרד האוצר, but it arrived to my email (yair888), that was previously set for that authority. Do we have some log for outgoing emails?
http://askdata.org.il/admin/body/edit/15

Viewing some requests results in an error

http://askdata.org.il/admin/request/show/113

Error:

RuntimeError in Admin_request#show

Showing app/views/admin_request/show.rhtml where line #42 raised:

internal error, last_event_forming_initial_request gets nil for request 113 outgoing messages count 1 all events: --- []

Extracted source (around line #42):

39:                   <% end %>
40:                   <% if column_name == 'described_state' %>
41:                     <ul>
42:                       <li><strong>Initial request last sent at:</strong> <%= @info_request.calculate_status %></li>
43:                       <li><strong>Initial request last sent at:</strong> <%=@info_request.date_initial_request_last_sent_at.to_date %></li>
44:                       <li><strong>Date response required by:</strong> <%= @info_request.date_response_required_by %></li>
45:                       <li><strong>Very overdue after:</strong> <%= @info_request.date_very_overdue_after %></li>

RAILS_ROOT: /home/alaveteli/alaveteli
Application Trace | Framework Trace | Full Trace

/home/alaveteli/alaveteli/app/models/info_request.rb:693:in `last_event_forming_initial_request'
/home/alaveteli/alaveteli/app/models/info_request.rb:714:in `date_very_overdue_after'
/home/alaveteli/alaveteli/app/models/info_request.rb:615:in `base_calculate_status'
/home/alaveteli/alaveteli/app/models/info_request.rb:607:in `calculate_status'
/home/alaveteli/alaveteli/app/views/admin_request/show.rhtml:42:in `_run_rhtml_app47views47admin_request47show46rhtml'
/home/alaveteli/alaveteli/app/models/info_request.rb:1134:in `for_admin_column'
/home/alaveteli/alaveteli/app/models/info_request.rb:1133:in `each'
/home/alaveteli/alaveteli/app/models/info_request.rb:1133:in `for_admin_column'
/home/alaveteli/alaveteli/app/views/admin_request/show.rhtml:28:in `_run_rhtml_app47views47admin_request47show46rhtml'
/home/alaveteli/alaveteli/app/views/admin_request/show.rhtml:5:in `_run_rhtml_app47views47admin_request47show46rhtml'
/home/alaveteli/alaveteli/app/controllers/application_controller.rb:105:in `record_memory'

Request

Parameters:

{"id"=>"113"}

Show session dump
Response

Headers:

{"Vary"=>"Cookie",
 "Content-Type"=>"",
 "Cache-Control"=>"no-cache"}

Destroying some requests brings up an error

While cleaning up the test requests for the alpha, got three behaviors:

request is deleted with no issues
deleting the request is followed by an error, but still gets deleted
deleting the request is followed by an error, not deleted eventually