hashicorp-modules/consul-aws

consul-aws's Issues

Example links all 404

Links in the following file all 404: https://github.com/hashicorp-modules/consul-aws/tree/master/examples

create_before_destroy and other blue/green params for ASG

I borrowed bits and pieces from your module for my build, but I realized that when I adjusted the instance sizes supplied to the module, it only updated the launch configuration - but not the ASG. I suggest trying this out, which helped me.

https://stackoverflow.com/questions/40985151/auto-scaling-groups-dont-update-on-launch-configuration-change

I can try to submit a PR but if i can't get to it this week then I won't be able to take it on. Hope this helps.

@bensojona :)

tags vs tags_list

consul-aws/variables.tf

Line 149 in e57139b

variable "tags_list" {

I have used the vault-best-practices/operations/provisioning for AWS as a starting point and have been looking to upgrade it (and subsequent modules) to align with 0.12. (0.11 works well)

As you already know, in 0.12 there are reserved variables, for-loops, if statements, and various other changes regarding input variable types and how they are interpreted. I see "TODOs" in the comments.

One change I am trying to understand is rational behind supporting the use of ec2 instance tags?

What is the use of having a list(string) or "tags_list" and map(string) "tags" in consul-aws? Is this just to support re-use in parent projects that may have either? The descriptions are the same, so I'm wondering if vault best practices actually uses them or both in some way?

@bensojona This is more of a general question than a bug/feature needing a PR.