hashicorp/actions-go-build

Define a reproducible Go build.

actions-go-build's Issues

GitHub Actions - deprecated warnings found - action required!

Workflow Name: Test
Branch: main
Run URL: https://github.com/hashicorp/actions-go-build/actions/runs/4048330655

save-state deprecation warnings: 0
set-output deprecation warnings: 0
node12 deprecation warnings: 1

Please review these deprecation warnings as soon as possible and merge in the necessary updates.

GitHub will be removing support for these commands and plan to fully disable them on 31st May 2023. At this time, any workflow that still utilizes these commands will fail. See https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/.

GitHub have not finalized a date for deprecating node12 yet but have indicated that this will be summer 2023. So it is advised to switch to node16 asap. See https://github.blog/changelog/2022-09-22-github-actions-all-actions-will-begin-running-on-node16-instead-of-node12/.

If you need any help, please reach out to us in #team-rel-eng.

v0.1.4 and v0.1.6 fails to build for darwin arm64

The two latest releases (since the bash->go refactoring) fail to build darwin arm64 artifacts properly. Pinning to v0.1.3 (for darwin builds) is a current workaround for this issue. There are a lot of commits from v0.1.3 -> v0.1.6, so this has not been an easy one to troubleshoot or fix. I'm setting aside this aside for now, and will plan to reach out to @samsalisbury or @alvin-huang when they're back to troubleshoot further and provide a fix.

More information from end users is available in https://hashicorp.slack.com/archives/CR024M999/p166629796788295. A link to a failure in crt-core-helloworld is available here: https://github.com/hashicorp/crt-core-helloworld/actions/runs/3296659149.

Add action to install the CLI

A sub action that just installs the CLI would be useful for contexts where we want to just run the CLI tool for other purposes than just building and verifying.

Extract code in pkg/crt/versionfile.go to its own package for reuse.

This look in different places for version files and parses them.

Feature Request: Input to add binary to path

Hi team! Great work on this action. I just started using the action in our testing pipeline to build a binary that we run in acceptance tests.

Because we use the binary in acceptance tests later on, I had to add the binary to PATH in a separate step. I think it would be helpful to have a way to set this as an input flag (e.g. add_to_path: true.

When Makefile is modified `error: stat PWD/Makefile is not a directory`

Example:

tsccr-helper sam$ INSTRUCTIONS='gmake tsccr-helper' actions-go-build build -debug -rebuild 
Resolving buildish "."
dir exists: /Users/sam/src/github.com/hashicorp/security-tsccr/tsccr-helper
Running build using config and source code from /Users/sam/src/github.com/hashicorp/security-tsccr/tsccr-helper
stat tsccr-helper/Makefile: not a directory

Looks like it's part of the clean build detection that's expecting Makefile to be a directory for some reason.

Add action to create a GitHub release using assets built by this action.

For teams not using CRT, it would be useful if this action could directly create GitHub releases, including generating a SHA256SUMS file to bundle with the release, and possibly a homebrew formula as well.

GitHub Actions - deprecated warnings found - action required!

Workflow Name: Test Verify
Branch: main
Run URL: https://github.com/hashicorp/actions-go-build/actions/runs/4048330408

save-state deprecation warnings: 0
set-output deprecation warnings: 0
node12 deprecation warnings: 1

Please review these deprecation warnings as soon as possible and merge in the necessary updates.

GitHub will be removing support for these commands and plan to fully disable them on 31st May 2023. At this time, any workflow that still utilizes these commands will fail. See https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/.

GitHub have not finalized a date for deprecating node12 yet but have indicated that this will be summer 2023. So it is advised to switch to node16 asap. See https://github.blog/changelog/2022-09-22-github-actions-all-actions-will-begin-running-on-node16-instead-of-node12/.

If you need any help, please reach out to us in #team-rel-eng.

Make release on mac throws an error

...
==> Getting release notes...
./dev/release/create: line 37: envsubst: command not found
make: *** [release] Error 1

Running make release on a mac throws this error. Users need to install brew install gettext, delete the tag, and run make release again to fix. We should look into doing this automatically

Extract product/product.go as a separate package to aid with injecting build info via actions-go-build

Actions-go-build knows how to populate those vars already.