haskellari/binary-orphans

Orphan instances for binary

binary-orphans's Issues

Allow tagged 0.8.7

Builds fine and all tests pass here.

binary-instances-1 test suite failure

Citing from https://hydra.nixos.org/build/114007066/nixlog/1:

  CI Text:            FAIL
    *** Failed! Falsified (after 76 tests and 8 shrinks):
    "\43949"
    "\43949" /= "\5085"
    Use --quickcheck-replay=455351 to reproduce.

0.1.4.0 Hackage version was overwritten

It looks like the 0.1.4.0 version of this package was originally published without the change in #13. After #13, the package was re-published with the same version. This is a major issue for package maintainers. Going forward can you please bump up the Hackage version when publishing?

Support GHC 9.8

Test doesn't build with quickcheck-instances 0.3.28

We should probably tighten the bounds to >= 0.3.29

[1 of 1] Compiling Main             ( test/Tests.hs, dist/build/binary-orphans-test/binary-orphans-test-tmp/Main.dyn_o )

test/Tests.hs:30:5: error:
    • No instance for (Test.QuickCheck.Arbitrary.Arbitrary ByteArray)
        arising from a use of ‘testProperty’
      There are instances for similar types:
        instance Test.QuickCheck.Arbitrary.Arbitrary
                   primitive-0.7.4.0:Data.Primitive.ByteArray.ByteArray
          -- Defined in ‘Test.QuickCheck.Instances.Primitive’
    • In the first argument of ‘($)’, namely ‘testProperty "ByteArray"’
      In the expression:
        testProperty "ByteArray" $ roundtrip (Proxy :: Proxy ByteArray)
      In the second argument of ‘testGroup’, namely
        ‘[testProperty "Natural" $ roundtrip (Proxy :: Proxy Natural),
          testProperty "Sum Int" $ roundtrip (Proxy :: Proxy (Sum Int)),
          testProperty "Min Int" $ roundtrip (Proxy :: Proxy (Min Int)),
          testProperty "Solo Int" $ roundtrip (Proxy :: Proxy (Solo Int)),
          ....]’
   |
30 |   , testProperty "ByteArray"       $ roundtrip (Proxy :: Proxy ByteArray)
   |     ^^^^^^^^^^^^^^^^^^^^^^^^ 

Binary instance for Hashed

Same here?

Package broken on nixpkgs

Hey, the Package seems to be broken on nix, where I’m not sure how to fix this:

building '/nix/store/r9nmrf7bfgbnxzk1ab007lx5hczyxnk6-binary-instances-1.drv'...
setupCompilerEnvironmentPhase
Build with /nix/store/8b732fcj71j3mxp99g8104q9r88m5can-ghc-8.6.5.
unpacking sources
unpacking source archive /nix/store/himr2bcx02135f156l4kilcw3yw3gdn0-binary-instances-1.tar.gz
source root is binary-instances-1
setting SOURCE_DATE_EPOCH to timestamp 1000000000 of file binary-instances-1/test/Tests.hs
patching sources
compileBuildDriverPhase
setupCompileFlags: -package-db=/build/setup-package.conf.d -j4 -threaded
[1 of 1] Compiling Main             ( Setup.hs, /build/Main.o )
Linking Setup ...
configuring
configureFlags: --verbose --prefix=/nix/store/vbkfvggqdis6z059z3hhd637psjxn83i-binary-instances-1 --libdir=$prefix/lib/$compiler --libsubdir=$abi/$libname --docdir=/nix/store/qip3qs2gb8njhka5m2f9km19vmfmhvlp-binary-instances-1-doc/share/doc/binary-instances-1 --with-gcc=gcc --package-db=/build/package.conf.d --ghc-option=-j4 --disable-split-objs --enable-library-profiling --profiling-detail=exported-functions --disable-profiling --enable-shared --disable-coverage --enable-static --disable-executable-dynamic --enable-tests --disable-benchmarks --enable-library-vanilla --disable-library-for-ghci --ghc-option=-split-sections --extra-lib-dirs=/nix/store/wl1xil3z3x06pi5xc3r29vzgbfvf5ckj-ncurses-6.1-20190112/lib --extra-lib-dirs=/nix/store/0f1dhbhnxmm6yc2msmxy7bwsyq6xcvvb-libffi-3.2.1/lib --extra-lib-dirs=/nix/store/wdqvks4hvnvrx842rwv4sagx55smy5n1-gmp-6.1.2/lib
Using Parsec parser
Configuring binary-instances-1...
CallStack (from HasCallStack):
  die', called at libraries/Cabal/Cabal/Distribution/Simple/Configure.hs:950:20 in Cabal-2.4.0.1:Distribution.Simple.Configure
  configureFinalizedPackage, called at libraries/Cabal/Cabal/Distribution/Simple/Configure.hs:460:12 in Cabal-2.4.0.1:Distribution.Simple.Configure
  configure, called at libraries/Cabal/Cabal/Distribution/Simple.hs:596:20 in Cabal-2.4.0.1:Distribution.Simple
  confHook, called at libraries/Cabal/Cabal/Distribution/Simple/UserHooks.hs:67:5 in Cabal-2.4.0.1:Distribution.Simple.UserHooks
  configureAction, called at libraries/Cabal/Cabal/Distribution/Simple.hs:178:19 in Cabal-2.4.0.1:Distribution.Simple
  defaultMainHelper, called at libraries/Cabal/Cabal/Distribution/Simple.hs:115:27 in Cabal-2.4.0.1:Distribution.Simple
  defaultMain, called at Setup.hs:2:8 in main:Main
Setup: Encountered missing dependencies:
QuickCheck >=2.13.1 && <2.14,
binary-orphans >=1.0.1 && <1.1,
quickcheck-instances >=0.3.21 && <0.4,
time-compat >=1.9.2.2 && <1.10

builder for '/nix/store/r9nmrf7bfgbnxzk1ab007lx5hczyxnk6-binary-instances-1.drv' failed with exit code 1

WDYT?

Semigroup instances

See kolmodin/binary#114 (comment)

What is going on with the versions of binary-instances and binary-orphans?

Something really strange is going on with the versions of these two hackage packages. Why do they both point at this repo, and why are the most recently published versions lower than previous versions?

Add instance for Natural