Giter Site home page Giter Site logo

Comments (7)

sinclairpaul avatar sinclairpaul commented on June 3, 2024 1

So maybe provide a suggestion, i.e. should all community addon's be prefixed with "community", how does that scale exactly.

Either way, the code base for generating the URL's is within the supervisor code, wish you luck with your feature request.

from addon-log-viewer.

frenck avatar frenck commented on June 3, 2024

Feel free to suggest that to Home Assistant as a feature request. This is not something an add-on can do anything about.

../Frenck

from addon-log-viewer.

532910 avatar 532910 commented on June 3, 2024

so why does the terminal has clean url?

from addon-log-viewer.

frenck avatar frenck commented on June 3, 2024

🤷 Because HA decided too.

from addon-log-viewer.

532910 avatar 532910 commented on June 3, 2024

https://community.home-assistant.io/t/log-viewer-addon-please-make-url-clean/713393

from addon-log-viewer.

sinclairpaul avatar sinclairpaul commented on June 3, 2024

Just to add some context, the URL isn't "clean", it is prefixed with "core", which as you can see at https://github.com/home-assistant/supervisor/blob/c3c17b2bc30f24a6940523fad743bf57321705de/supervisor/store/__init__.py#L137 is what is hardcoded in the Supervisor for any HA specific addons.

I'm going to assume that your concern is that the URL may change, which it won't as the hash is based on the repo.

from addon-log-viewer.

532910 avatar 532910 commented on June 3, 2024

Nope, my concern is not that the URL may change, my concern is that the URL is not clean. I wouldn't like to see garbage in my address bar. Moreover, I'm against the fact that some "good" addons like ssh are allowed to have clean url, but "bad" addons are not. I believe all hassio-addons should be considered "good" with a clean url.

from addon-log-viewer.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.