hawtio/hawtio-jmx

JMX, JVM and tree plugins for hawtio 2.x

hawtio-jmx's Issues

jmx-plugin - Tidy up JMX attribute dialog

The layout of this dialog could use some work, might just be a matter of switching it to the form2 plugin. Also perhaps using hawtio-editor instead of the textarea for any json that shows up would be good.

Consider using hawtio-oauth and removing ConnectOptions.token support

@tadayosi @akieling I wonder whether we should depend on hawtio-oauth directly in hawtio-jmx as it is used in hawtio v2 and hawtio-online. If that is the case, then we may consider removing ConnectOptions.token which is redundant.

That follows #47 up. Actually in the OpenShift console, the user stays in the same window and in hawtio-online the token is passed in the URL hash. So we may use the session store instead of the local store. We still need ConnectOptions.token if we want to open a new window.

I would tend to think end-users may want to have multiple windows opened. So that leaves us with the following options:

• Use hawtio-oauth and store the token in the local store
• Pass the token in the URL hash and rely on ConnectOptions.token stored in the session store
  The former would allow to logout from any window using the hawtio-logout extension and would allow using the token throughout its entire lifespan, while the later might be more secure.

Sort diagnostics class histogram table by bytes column

From a diagnostics perspective, I think it'd be better to have the class histogram table sorted by the 'Bytes' column instead of the class name.

Discovery of jolokiaUrl broken with jquery 2.1.*

The interrogation of the jolokiaUrl is incorrect. If the url returns a 403 or 401, on the jquery.$ajax() call, around line 607.....the code is incorrect for jquery 2.1.*. Currently the code probably only works if jolokiaUrl is in the query params.

The doc here: http://api.jquery.com/jquery.ajax/, indicates the 2nd parameter is probably the only way to discriminate for the .always() method.

Possibly the clearest approach will be to chain these together:

$.ajax({})
  .done(fn)
  .error(fn)

Login dialog - excessive invocation of checkCredentials function

On the login dialog, the password field ng-change binds to checkCredentials(). This means for every character entered, a request is sent to the target Jolokia instance. If a long password is entered, this results in many requests being sent in a potentially very short period of time.

Maybe it's best to just call checkCredentials when the login button is clicked.

Replace remote connection login dialog box with a full page

When connecting to a remote endpoint that requires username/password authentication, show a full login page instead of the currently shown dialog box.

JMX plugin - incorrect Jolokia URL in Attribute dialog

The Jolokia URL shown in Attribute dialog is something like this:

http://localhost:2772/undefined/read/org.apache.activemq:type=Broker,brokerName=amq-broker,destinationType=Queue,destinationName=TEST/Name

On the other hand, the Copy Jolokia URL menu in Operations tab generates the URL correctly:

http://localhost:2772/proxy/http/localhost/8181/hawtio/jolokia/exec/org.apache.activemq:type=Broker,brokerName=amq-broker,destinationType=Queue,destinationName=TEST/browse()

Connect options token is not used anymore

It breaks hawtio-online integration. Seems related to e9377fd.

@tadayosi what's the target integration you recommend? Should that be articulated with the Core.AuthService?

Port optimized Jolokia list call to hawtio-jmx

Let's port these to hawtio-jmx. See also hawtio/hawtio#2097.

Move hawtio-log to hawtio-jmx

More intuitive feedback on connecting to other JVM

Maybe some responsibility falls on hawtio-core or other components, in that case please split the issue as you see fit (if the request seems sensible).

1. Is it possible to show the PID in the page title like in 1.5 ? I think that would be very valuable. Additionally there used to be some preference to use different color labels for different connection patterns? I got the impression that it was never in fact completely implemented, but I think the idea was quite promising. Does anyone know why it was dropped and if its worth picking up?
2. When connecting to a local/discovered process and this for some reason fails, the new tab is then actually connected to the original Java process, and no warning is given. This can cause confusion. Is it possible to detect this situation give and error message and close the new tab immediately, so that the user does not get confused and waste time introspecting the wrong process?
3. Alternatively I could port the runtime plugin from 1.x and we could open that path by default on these ad hoc connections. That would immediately show the PID, uptime, host and other information helpful in verifying that the connection is indeed to the intended destination.

Add support for front end tests in build

I would like to include some regression tests, preferrably in typescript. Could someone experienced with front end set it up, or advise on how to best do it?
Cheers!

Move code to hawtio-integration

With the intent of reducing the number of Hawtio projects, move the code from this project to hawtio-integration.

Connect plugin - Preference dont work

It shows no connect preference but keep showing the last page.

As from the screenshot then the last was AMQ

Port fix #1900 from V1 to V2

Git commit b766d97cf61ac1392a69b3457ee939ea8e54f5b6 from v1 to fix an issue in the dashboards

Error callback is always ignored in JolokiaService

I've been testing some functionality over in the hawtio-integration project, and I expected to see some error messages being displayed when Jolokia returns an error response. However, this never happens.

I think the syntax defining the success / error callbacks is wrong in each of the JolokiaService methods. E.g we have:

      return this.$q((resolve, reject) => {
        this.jolokia.request(
          { type: 'read', mbean: mbean, attribute: attribute },
          { success: response => resolve(response.value) },
          { error: response => {
              log.error(`JolokiaService.getAttribute('${mbean}', '${attribute}') failed. Error: ${response.error}`);
              reject(response.error);
            }
          });
      });

The success and error callbacks are within separate objects. I think they should be part of the same object, else the error option will get ignored.

Various shortcomings in jvm/connect compared to 1.x

• icons not displayed in 2.x:
  • discover : connect icon is not displayed
  • local : start / stop icons are not displayed
• connect to local discover does not work properly
  • new tab shows the same process, not the one connected to. (similar to hawtio/hawtio#2339)
  • all new connections show in same tab, instead of opening new ones
• local start / stop not reflected in same refresh cycle: (similar to hawtio/hawtio#2355)
• discover jvm icon size not constrained :
  

Have some fixes in progress and plan to submit a PR shortly.

Connect plugin - Update Instructions

Some parts (like that mentioning Fabric8) are outdated.

Improve Diagnostics UI

Improve Diagnostics UI using PatternFly and Angular PatternFly.

A few things to improve:

• Java Flight Recorder
  • Stop showing the warning alert after the user closes it.
  • What's the information alert for? When you open the page, it doesn't show any valuable information. Would make sense hiding it at that point?
  • Replace use of hawtio-forms with HTML form based on PatternFly Forms
  • Would be great to redesign the tape recorder image.
• Heap Use
  • Use the tab title as page title
  • Stop showing the warning alert after the user closes it.
  • Use the pfTableView with toolbar so they look integrated (pfTableView - with Toolbar)
• JVM Flags
  • Use the tab title as page title
  • Use pfTableView - with Toolbar

Set up unit testing with Karma, Jasmine, and CircleCI 2.0

https://docs.angularjs.org/guide/unit-testing

Refactor jolokiaService.ts into multiple files

Create a jolokia folder and move parts of jolokiaService.ts to separate files.

JMX plugin - JMX tree not visible initially after page reload

After my work on RBAC support, now the JMX tree is not visible immediately after reloading the page. Moving tabs around you can still see the JMX tree showing up.

JMX Plugin - Invoke JMX operation shows result in tiny window

On the java lang threading mbean, there is a thread info operation you can get details for thread id 1, and then it returns

And after manually resizing the window you can see the details

JMX Plugin - Edit Charts has no buttons

There is no buttons to save the edit which used to be there in 1.x

jmx-plugin - tidy up JMX operation page

The JMX operation page could use a bit of layout work. Perhaps some descriptive text for starters explaining what the page does, maybe improve the list layout of the operations, etc.

Also the buttons that do stuff (execute, reset etc) for the form should maybe go underneath the form. And the "Back" button could maybe just be a list icon.

Bower warning about the "main" field

When installing hawtio-jmx using Bower, the following message is printed:

bower hawtio-jmx#~2.0.50 invalid-meta The "main" field has to contain only 1 file per filetype; found multiple .js files: ["dist/dangle.js","dist/dagre.js","dist/jolokia.js","dist/cubism.v1.js","dist/jolokia-simple.js","dist/jolokia-cubism.js","dist/hawtio-jmx.js"]

Bower expects only one main JavaScript file. A solution would be concatenating the files into one.

JMX plugin - Title doesn't show up when immediately coming from other plugin

Normally we can see the title About.

But coming from other plugin, e.g. Threads, About doesn't show up. It reappears just by clicking around the JMX tree in the sidebar.

Request 'X-Authorization' as allowed header in a CORS preflight check

In order to be able to use the new header X-Authorization header in a CORS request it must be white listed by a preflight CORS request as described here. I wonder, why Authorization works because this is also not a simple header and hence must be white listed, too.

@cmoulliard ran into this issue first:

Log - Filtering doesn't seem to work

Even if I set Level=ERROR filtering it still shows INFO level logs:

Other categories don't work either.

Reference to window.opener needs a guard against nullity in handling ajax errors

Refer to code here:

the code:

hawtio-jmx.js, line 826:

                        delete window.opener["passUserDetails"];

Needs a null guard when user is auto-logged out by server. It is not always the case that window.opener is non-null: https://developer.mozilla.org/en-US/docs/Web/API/Window/opener

JMX Connection Warning Modal Malformed

Not sure if this is the appropriate project to log this issue or not, because the CSS interfering may be elsewhere (like hawtio/openshift-jvm)

Modal style is malformed:

happens during unauthorized requests..

Versions affected:
origin v1.5.0+031cbe4
repro chrome 58.0.3029.110

Repro steps:
1.) Open up two tabs via "Open Java Console" on a pod that exposes a jolokia port
2.) In first tab, log out
3.) Reload 2nd tab to get pod request authorization to fail

JVM plugin - Connect redirects to root context '/?con=<name>'

It causes 404 error (or something else) when hawtio is deployed on other than the root context (e.g. /hawtio).

Show a proper error dialog if the connection to jolokia fails

For openshift/origin#4612

We used to have this for 1.x, probably just wasn't brought over.

Connection details dialog allows duplicate names

I think we should prevent users from adding connections with duplicate names. It can have some weird side affects given that the name is used as the con URL parameter when you connect to a JVM.

Spring Boot runtime metrics card remains in loading state

To avoid duplicate data being displayed on the Runtime > Metrics page, the Spring Boot metrics card only displays metrics that are relevant to the Spring Boot application.

However, when no such metrics are found, the card remains in the loading state indefinitely.

Allow jolokiaParams service factory to override ajaxError() fn handler

Allow jolokiaParams service to be overridden by $provide() delegation, giving consumer the chance
to install their own ajaxError() handler to jolokia

Diagnostics - Hotspot Diagnostics: use pfTableView with toolbar

Use the pfTableView with an integrated toolbar.
https://www.patternfly.org/angular-patternfly/#/api/patternfly.table.component:pfTableView%20-%20with%20Toolbar

Connect: move Remote instructions to popover

Move the instructions shown in the Remote page to a popover.
The popover can be shown when the user clicks on a question mark icon located after the page title.

Stop injecting 'workspace' in the hawtio-ui tree component

The workspace resource from hawtio-jmx is being injected in the hawtio-ui tree component with the intention of being notified about node selections. The correct way for hawtio-jmx to be notified about node selections is via the onSelect callback.

index.html has no closing meta tag

This tag has no closing tag
https://github.com/hawtio/hawtio-jmx/blob/master/index.html#L7

I assume it should just be <meta ... />

And it would be the same fix in the other hawtio modules?

@gashcrumb - would that be right?

Diagnostics - Class Histogram: use pfTableView with toolbar

Use the pfTableView with an integrated toolbar.
https://www.patternfly.org/angular-patternfly/#/api/patternfly.table.component:pfTableView%20-%20with%20Toolbar

Move jolokia preference to hawtio-jmx

[15:19:00] davsclaus: hmm, now that I think about it, the jolokia preference page would probably be best suited to be in hawtio-jmx if you fancy porting that over
[15:19:19] the one that lets you tweak the jolokia settings

Log entry modal dialog displays HTML encoded data for message field

JMX plugin - add 'copy Jolokia URL to clipboard' button in Attribute dialog

Attribute dialog already has the Copy value to clipboard button. I'd like to have Copy Jolokia URL to clipboard button in the dialog as well.