hayden-fr/comfyui-model-manager

Manage models: browsing, donwload and delete.

comfyui-model-manager's Issues

AttributeError: 'str' object has no attribute 'get' and more

Hello, I have problems:

When I click Load From → Local Source and Refresh in the Model List tab

ERROR:aiohttp.server:Error handling request
Traceback (most recent call last):
  File "X:\Portable-ComfyUI-dev\python_embeded\lib\site-packages\aiohttp\web_protocol.py", line 433, in _handle_request
    resp = await request_handler(request)
  File "X:\Portable-ComfyUI-dev\python_embeded\lib\site-packages\aiohttp\web_app.py", line 504, in _handle
    resp = await handler(request)
  File "X:\Portable-ComfyUI-dev\python_embeded\lib\site-packages\aiohttp\web_middlewares.py", line 117, in impl
    return await handler(request)
  File "X:\Portable-ComfyUI-dev\ComfyUI\server.py", line 46, in cache_control
    response: web.Response = await handler(request)
  File "X:\Portable-ComfyUI-dev\ComfyUI\server.py", line 58, in cors_middleware
    response = await handler(request)
  File "X:\Portable-ComfyUI-dev\ComfyUI\custom_nodes\ComfyUI-Model-Manager\__init__.py", line 70, in load_download_models
    model_types = os.listdir(model_uri)
FileNotFoundError: [WinError 3] The system cannot find the path specified: 'X:\\Portable-ComfyUI-dev\\models'

When I click Load From → Web Source

ERROR:aiohttp.server:Error handling request
Traceback (most recent call last):
  File "X:\Portable-ComfyUI-dev\python_embeded\lib\site-packages\aiohttp\web_protocol.py", line 433, in _handle_request
    resp = await request_handler(request)
  File "X:\Portable-ComfyUI-dev\python_embeded\lib\site-packages\aiohttp\web_app.py", line 504, in _handle
    resp = await handler(request)
  File "X:\Portable-ComfyUI-dev\python_embeded\lib\site-packages\aiohttp\web_middlewares.py", line 117, in impl
    return await handler(request)
  File "X:\Portable-ComfyUI-dev\ComfyUI\server.py", line 46, in cache_control
    response: web.Response = await handler(request)
  File "X:\Portable-ComfyUI-dev\ComfyUI\server.py", line 58, in cors_middleware
    response = await handler(request)
  File "X:\Portable-ComfyUI-dev\ComfyUI\custom_nodes\ComfyUI-Model-Manager\__init__.py", line 57, in load_source_from
    model_type = item.get("type")
AttributeError: 'str' object has no attribute 'get'

When i click Install for download models

temp file is X:\Portable-ComfyUI-dev\models\vae\sd_vae.safetensors.download
Start download X:\Portable-ComfyUI-dev\models\vae\sd_vae, file size: 334641190
ERROR:aiohttp.server:Error handling request
Traceback (most recent call last):
  File "X:\Portable-ComfyUI-dev\python_embeded\lib\site-packages\aiohttp\web_protocol.py", line 433, in _handle_request
    resp = await request_handler(request)
  File "X:\Portable-ComfyUI-dev\python_embeded\lib\site-packages\aiohttp\web_app.py", line 504, in _handle
    resp = await handler(request)
  File "X:\Portable-ComfyUI-dev\python_embeded\lib\site-packages\aiohttp\web_middlewares.py", line 117, in impl
    return await handler(request)
  File "X:\Portable-ComfyUI-dev\ComfyUI\server.py", line 46, in cache_control
    response: web.Response = await handler(request)
  File "X:\Portable-ComfyUI-dev\ComfyUI\server.py", line 58, in cors_middleware
    response = await handler(request)
  File "X:\Portable-ComfyUI-dev\ComfyUI\custom_nodes\ComfyUI-Model-Manager\__init__.py", line 167, in download_file
    download_model_file(download_uri, file_name)
  File "X:\Portable-ComfyUI-dev\ComfyUI\custom_nodes\ComfyUI-Model-Manager\__init__.py", line 130, in download_model_file
    with open(dl_filename, "ab") as f:
FileNotFoundError: [Errno 2] No such file or directory: 'X:\\Portable-ComfyUI-dev\\models\\vae\\sd_vae.safetensors.download'

Are you interested in merging my fork?

I forked this repo a while ago and made some large changes to the codebase. I think it's finally reached a "1.0" for core features. I'm curious if you're interested in merging the changes?

The change that I think may be most relevant to your use case is installing models. I added support to downloading from Civitai and HuggingFace, but in theory "index.json" files should still work if given a valid link, although I haven't tested it enough. Any input on how the index files are practically used is welcome.

I may still make changes to the code base, but if you're interested, I can submit a PR. Otherwise, I can register the fork with the ComfyUI-Manager instead.

Download models thumbnails

I would like to see the thumbnails in the model list tab too, if possible.