hdoria/hntool

Hardening Tool for *nixes

hntool's Issues

sshd_config file setting a complex time value can cause a program error

if sshd_config have set the value GraceClientAlive is complex value like 2m the program crash, because program use int() function convert this complex string value, thus cause the program error.

Docker plugin

Should be great create a plugin to check docker security host.

We can use this document as reference: https://docs.google.com/viewer?a=v&pid=forums&srcid=MTM5NjUxMzkxMTQ4MjY1MDUxOTYBMDc4NTQ0OTA3MTYwMzYyMjA3NDIBamRaRHBSelJodDRKATAuMQEBdjI

Test only one requirement

Return true if only one file is valid.

def requirements_met(pfile):
'''This method should check if all the requirements (files)
are met (one or more files can be found on the system)'''

for f in pfile:
    if os.path.isfile(f):
        return True  # <---------------------

return False

update package on PyPI

and add install instructions using pip in the readme.

https://pypi.python.org/pypi/HnTool/0.1

setup.py with --prefix option: module not found errors (Debian-based distros)

The recommended install method:
python setup.py install --prefix /usr/ --root /
Installs packages to /usr/lib/pythonx.x/site-packages. Debian (and its derivatives) stopped putting site-packages in their sys.path, and now uses dist-packages instead, so you'll get module not found errors for all of the required modules. the --prefix option overrides Debian's default path for installing modules.

Running setup.py like this works fine:
python setup.py install

incorrect-fsf-address

Due https://fedoraproject.org/wiki/Common_Rpmlint_issues#incorrect-fsf-address I need to tell upstream that hntool should fix this issue.

List of afftected files:
hntool.noarch: E: incorrect-fsf-address /usr/lib/python2.7/site-packages/HnTool/modules/apache.py
hntool.noarch: E: incorrect-fsf-address /usr/lib/python2.7/site-packages/HnTool/modules/remote.py
hntool.noarch: E: incorrect-fsf-address /usr/lib/python2.7/site-packages/HnTool/modules/ssh.py
hntool.noarch: E: incorrect-fsf-address /usr/share/doc/hntool/LICENSE
hntool.noarch: E: incorrect-fsf-address /usr/lib/python2.7/site-packages/HnTool/modules/util.py
hntool.noarch: E: incorrect-fsf-address /usr/lib/python2.7/site-packages/HnTool/modules/ports.py
hntool.noarch: E: incorrect-fsf-address /usr/lib/python2.7/site-packages/HnTool/modules/vsftpd.py
hntool.noarch: E: incorrect-fsf-address /usr/lib/python2.7/site-packages/HnTool/modules/init.py
hntool.noarch: E: incorrect-fsf-address /usr/lib/python2.7/site-packages/HnTool/modules/postgresql.py
hntool.noarch: E: incorrect-fsf-address /usr/lib/python2.7/site-packages/HnTool/modules/proftpd.py
hntool.noarch: E: incorrect-fsf-address /usr/lib/python2.7/site-packages/HnTool/modules/php.py
hntool.noarch: E: incorrect-fsf-address /usr/lib/python2.7/site-packages/HnTool/modules/filesystems.py
hntool.noarch: E: incorrect-fsf-address /usr/lib/python2.7/site-packages/HnTool/modules/authentication.py
hntool.noarch: E: incorrect-fsf-address /usr/bin/hntool
hntool.noarch: E: incorrect-fsf-address /usr/lib/python2.7/site-packages/HnTool/modules/system-wide.py
hntool.noarch: E: incorrect-fsf-address /usr/lib/python2.7/site-packages/HnTool/output/terminal.py
hntool.noarch: E: incorrect-fsf-address /usr/lib/python2.7/site-packages/HnTool/core.py
hntool.noarch: E: incorrect-fsf-address /usr/lib/python2.7/site-packages/HnTool/output/init.py
hntool.noarch: E: incorrect-fsf-address /usr/lib/python2.7/site-packages/HnTool/output/html.py
hntool.noarch: E: incorrect-fsf-address /usr/lib/python2.7/site-packages/HnTool/modules/rule.py

Another question, I'm maintaining hntool package in Fedora, but upstream looks dead, do you have plans to keep hntool development or should I retire it from Fedora?
Thanks,

Filipe R.

There is running error if sshd_config have not set Protocol item

if sshd_config have not set Protocol config item, the program crash, because program can't get the lines['Protocol'] value.
CentOS Linux release 7.4.1708 (Core)