somecompany-test-assignment's People
somecompany-test-assignment's Issues
somecompany ревью
owner-edit: убрано название компании, слишком легко гуглится и руинит тест
-
https://github.com/HeavyOranJS/somecompany-test-assignment/blob/master/assignment/views.py#L50
Может упасть если username пустой. Есть смысл обернуть в try...except User.DoesNotExist. -
https://github.com/HeavyOranJS/somecompany-test-assignment/blob/master/assignment/models.py
К моделям и к полям моделей следует указывать verbose_name -
https://github.com/HeavyOranJS/somecompany-test-assignment/blob/master/best_data_base.png
А что такое family_name у employee? -
https://github.com/HeavyOranJS/somecompany-test-assignment/blob/master/somecompany-testTest/settings.py#L44
ALLOWED_HOST тоже нужно задавать в json файле -
https://github.com/HeavyOranJS/somecompany-test-assignment/blob/overtime/assignment/forms.py#L81
тут тоже не хватает обработки исключений. Для сетевых запросов советую https://github.com/not-kennethreitz/requests (ты только глянь на количество звезочек!)
В целом неплохо, молодец.
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.