Giter Site home page Giter Site logo

Comments (9)

cpsauer avatar cpsauer commented on June 10, 2024 1

Thanks for the friendly heads, guys. I'm so sorry about that--I'd intended to support bzlmod and realized I had a bug in my test setup ๐Ÿคฆ๐Ÿป

I've been experimenting with fixes for the past bit. I think I've got something. I'll get back to you soon.

from bazel-compile-commands-extractor.

cpsauer avatar cpsauer commented on June 10, 2024 1

Should be fixed--but please test and let me know! Again, sorry guys, and thanks for letting me know.

Luke, thanks also for your offer of help. Please know that if you see something like this, I'd always love your help fixing and really appreciate your great bzlmod setup and contributions. I will, of course, try my best to not let more of these get through in the future.

from bazel-compile-commands-extractor.

cpsauer avatar cpsauer commented on June 10, 2024 1

Definitely! Thanks for your good care on maintenance tools; I know I've spent many an evening working on fixing things there. Also set up lots of automation to help keep everything up-to-date by default; not sure if there's an equivalent.

from bazel-compile-commands-extractor.

lalten avatar lalten commented on June 10, 2024

Funny enough I ran into a similar thing with rules_appimage the other day, and asked in Bazel Slack: https://bazelbuild.slack.com/archives/CA306CEV6/p1704300901665709
One workaround seems to be something like lalten/rules_appimage#115

from bazel-compile-commands-extractor.

Attempt3035 avatar Attempt3035 commented on June 10, 2024

No worries, will give it a go tonight! Thanks for such a quick development turnaround! Sorry I didn't have a chance to jump in and help, been preoccupied trying to get bazelbuild/bazel-central-registry#1280 working๐Ÿ˜

from bazel-compile-commands-extractor.

cpsauer avatar cpsauer commented on June 10, 2024

I saw that you'd created something there! Will that obsolete rules_boost, do you think?

from bazel-compile-commands-extractor.

Attempt3035 avatar Attempt3035 commented on June 10, 2024

That's the idea๐Ÿ˜œ It will be far more modular and maintainable, and should be a faster and more efficient solution as only required deps will be downloaded and built. Still working on a transition solution for everyone using the workspace boost rules (which are great, and a lot of the code for the new bzlmod modules comes from). Trying to implement all the original boost tests into it too, so it should be a bit more thorough and complete. Also working on some maintenance tools at https://github.com/dynacondev/boost.rules.tools for bumping versions, creating the patch files and calculating integrity as it's a pain to do manually while developing every time something changes!

from bazel-compile-commands-extractor.

Attempt3035 avatar Attempt3035 commented on June 10, 2024

Good point! Will look into automations a bit further down the line๐Ÿ‘

from bazel-compile-commands-extractor.

Attempt3035 avatar Attempt3035 commented on June 10, 2024

Confirmed bzlmod support is fixed in newest commit, thank you!
Also got the warning:
DEBUG: /private/var/tmp/_bazel_lukea/b010c5e57725766be1c569e8ff75e29e/external/rules_python~0.28.0/python/private/bzlmod/python.bzl:44:10: WARNING: Ignoring toolchain 'python_3_11' from module 'rules_python': Toolchain 'python_3_11' from module 'hedron_compile_commands' already registered Python version 3.11 and has precedence
Which shouldn't be an issue, we do indeed want the already registered one from bzlmod to take precedence if I understand correctly ๐Ÿ‘

from bazel-compile-commands-extractor.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    ๐Ÿ–– Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. ๐Ÿ“Š๐Ÿ“ˆ๐ŸŽ‰

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google โค๏ธ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.