Metrics are wrong on Linux

[probonopd]

Metrics are wrong on Linux

[probonopd]

We need to do something in styleplugin/basestyle.cpp

m.topMargin = 2; // static_cast<int>(fontHeight * MenuItem_VerticalMarginsFontRatio);
m.bottomMargin = 2; // static_cast<int>(fontHeight * MenuItem_VerticalMarginsFontRatio);

This seems to fix the menu item height.
Although we might want to hardcode the menu item height to an exact number of pixels instead of calculating it based on the font size; especially if we hardcode the absolute pixel height of the MainWindow that contains the menu. However, keep in mind that for non-global menus different font sizes and hence different menu item heights may be desirable.

For the menu(bar) height we need to change:

    case CT_MenuBarItem: {
        return QSize(size.width() + 10, 22);
    }

This hardcodes the height to 22px. Note that this value should always be kept the same as the height of the MainWindow of the Menu application. Can we make the MainWindow of the Menu application find out the height of the CT_MenuBarItem and just use that?

Text is still not centered.

[probonopd]

Addressing this in 8db9bf2 and in helloSystem/Menu@6619aed

[probonopd]

Defined by:

1. QtPlugin CT_MenuBarItem (in helloSystem, we want 22px)
2. QtPlugin
3. QtPlugin CT_MenuBarItem (in helloSystem, we want 22px/2)
4. QtPlugin MenuBar_ItemSpacing (in helloSystem, we want close to 0px)
5. QtPlugin MenuItemMetrics totalHeight (in helloSystem, we want this depending on the font size; for the main menu we want 22px)
6. Menu MainWindow height

[probonopd]

Turns out we get different rendering of text in Debian vs. FreeBSD; the reason for this is not clear yet. Using an ugly ifdef for now: 02361ce

[probonopd]

Also noteworthy: The Nimbus Sans in Debian/Ubuntu (fonts-urw-base35) behaves very differently than the Nimbus Sans from https://github.com/ArtifexSoftware/urw-base35-fonts/archive/20200910.zip. When using the latter in both places, I get consistent results. Hence closing.