hellosystem/qtplugin

Qt platform plugin and style, required for Qt applications to export their menus over D-Bus in the required format

QtPlugin

Qt platform plugin and style. Exports windows to KDE-style global menus via D-Bus.

Dependencies

On Alpine Linux:

apk add qt5-qtbase-dev libqtxdg-dev extra-cmake-modules libdbusmenu-qt-dev xcb-util-wm-dev cmake musl-dev alpine-sdk clang

On Arch Linux:

sudo pacman -S gcc extra-cmake-modules qt5-base qt5-tools qt5-x11extras libqtxdg libdbusmenu-qt5 libxcb

On FreeBSD:

sudo pkg install -y curl zip cmake pkgconf libfm qt5-core qt5-x11extras qt5-widgets qt5-qmake qt5-buildtools qt5-linguisttools kf5-extra-cmake-modules libqtxdg libxcb libdbusmenu-qt5 kf5-kwindowsystem

Build

mkdir build
cd build
cmake ..
make
sudo make install

Usage

export QT_QPA_PLATFORMTHEME=panda
export QT_STYLE_OVERRIDE=fusion # Optional if you want another Qt style, e.g., the Qt default one
(start Qt applciation)

License

panda-qt5-plugins is licensed under GPLv3.

qtplugin's Issues

Do not hardcode the font size for buttons

To allow for, e.g.,

Also, the "About This Computer" screen has a button with smaller text, which is currently ignored for the same reason.

Also, we should set the fixed height for buttons only if the default font size is not changed; once that size is changed, we should not fix the button height anymore.

Reference:

• helloSystem/Utilities#189

Get rid of extra line around non-selected list item

Qt seems to draw a line around "the non-selected list item that would be selected if an item was selected" (I have no better way of puting this).

Does anyone know what this Qt UI element is called?
How can we get rid of it?

Causes Falkon rendering issues

Causes Falkon rendering issues on the second window opened, and on subsequent windows

• helloSystem/ISO#60

This does not happen with the Qt default theme for Unix.

To reproduce:

killall falkon
unset QT_QPA_PLATFORMTHEME
falkon

Implement Candy style buttons

https://www.informit.com/articles/article.aspx?p=1405556

Text looks too high

Visual suggestion

Missing icons in second and subsequent Falkon windows

Missing icons in second and subsequent Falkon windows.

Only then QtPlugin is used and QT_QPA_PLATFORMTHEME=panda is set. Maybe the issue is there.

Metrics are wrong on Linux

On Debian Sid with Qt version 5.15.2, text is not vertically centered.

Menu items have too large height.
Unlike on FreeBSD, using the exact same fonts.

Why the difference?

This is not caused by /etc/xdg/stylesheet.qss because the effect is there even without it.
The Qt Unix default theme does not have this issue.

Make button selected via keyboard visible by changing its outline color

Follow-up to #10.

Now that we do not display PE_FrameFocusRect anymore, we have no way of seeing when a button has the focus by pressing the tab key.

What we would like is the button border to get a different color when it has the focus, just like with drop-down menus and with QLineEdit.

Good:

    case PE_FrameLineEdit: {
        QRect r = option->rect;
        bool hasFocus = option->state & State_HasFocus;
        bool isEnabled = option->state & State_Enabled;
        const qreal rounding = Ph::LineEdit_Rounding;
        auto pen = hasFocus ? S_highlight_outline : S_window_outline;

The problem is that no case PE_PushButton exists. Why?

Do not show icons in menus except if specifically requested

In QtPlugin:

    QCoreApplication::setAttribute(Qt::AA_DontUseNativeMenuBar, false);
    QCoreApplication::setAttribute(Qt::AA_DontShowIconsInMenus, true); // probono: need to use myAction->setIconVisibleInMenu(true); for menu items that shall get the icon nevertheless

In Menu:

                        action->setIcon(QIcon(IconCand));
                        action->setIconVisibleInMenu(true); // So that an icon is shown even though the theme sets Qt::AA_DontShowIconsInMenus

Slows down menus when switching between Falkon windows

Slows down menus when switching between Falkon windows.

It is much faster with the Qt default theme for Unix.

To reproduce:

killall falkon
unset QT_QPA_PLATFORMTHEME
falkon

Give the window a thin border

Let the window have thin borders so that the screen will not stick to other windows when there is no shadow effect.

Add accessibility features

Make the handicapped have a good experience.

(If it is difficult to implement, start with invert color)

Consider switching to "proper" scroll bars

The scroll bars in Falkon are different from the ones in the system-wide theme, and they are more usable and more in line with the HIG. We should consider using them everywhere.

Enable MacKeyboardScheme, make QKeySequence::StandardKey behave like on the Mac

Currently we have the clearly Windows-inspired "F3" for Find Again, whereas we want Command-G.

Supposedly we can get this for all Qt applications by setting QPlatformTheme::MacKeyboardScheme. How?

Command-G is mentioned in the early Macintosh Human Interface Guidelines:

Source: Apple Computer, Inc. 1992. Macintosh human interface guidelines. Addison-Wesley Publishing Company, USA. https://dl.acm.org/doi/book/10.5555/573097

Animate progress bars and default buttons

• Progress bars should be animated like on Windows or on the Mac to show that something is going on
• The default button should be "breathing"/slightly pulsating to draw more attention to it (like https://twitter.com/probonopd/status/1272140217412091904)

According to https://stackoverflow.com/questions/58248659/ this cannot be done with a QSS style sheet alone but requires the use of QXAnimation/QVariantAnimation.

filer-qt --desktop segfaults when stylesheet.qss exists and is not empty

Why?

Is it a fault of https://github.com/helloSystem/Filer or a fault of QtPlugin?

Make Qt behave more like on the Mac

• Make Wizards use MacStyle by default
• Flash/blink selected menu items (would be nice if we could let them blink more than once)
• Do not fade out menus after something has been selected (unsure on this one)

    case SH_WizardStyle:
        return QWizard::MacStyle; // probono
    case SH_Menu_FlashTriggeredItem:
        return 1; // probono
    case SH_Menu_FadeOutOnHide:
        return 0;  // probono

Port to Qt6

In order to get Qt6 applications (e.g., Qt Creator in 2024Q1 packages) to use our theme and work correctly, we need to build a version of QtPlugin for Qt6.

Issues:

• Needs https://www.freshports.org/x11/qt5-x11extras/ but there doesn't seem to be a qt6-x11extras. Looks like the Qt X11 Extras module was removed in Qt 6. Argh! This type of change causes extra work and (for me) takes the fun out of development. See https://doc.qt.io/qt-6/extras-changes-qt6.html#changes-to-qt-x11-extras for a suggested migration path. Also see Zren/material-decoration#60
• https://www.freshports.org/devel/libqtxdg/ only contains qt5xdgiconloader but not qt6xdgiconloader
• sudo pkg install libdbusmenu-qt6 works but CMake can't find Qt6ThemeSupport

Darken window background color

The color of the window is still too bright and it will still be uncomfortable if you look at it for a long time. I wish it could be darker.

pagination bar design

Make the paging bar design look better.

e.g. image

[CMake] Get it to build for Qt6, too

Get it to build for Qt6, too.

My attempts in af0157e ++ so far were not successful -- looks like doing this in CMake in a way that works on both FreeBSD and Ubuntu is way more complicated than it should be...

'make install' should also install stylesheet.css

'make install' should also install stylesheet.css

Shadow/glowing border for buttons

https://stackoverflow.com/questions/20866193/create-a-glowing-border-in-qss

Shrink PanelButtonTool

Shrink these things and make them less ugly:

How can it be done? I think it has to do with PE_PanelButtonTool somehow?

Defective progress bar CSS

UI fonts are vertically not centered in Qt/Gtk widgets

UI fonts are vertically not centered in Qt/Gtk widgets.

Blocked by:
ArtifexSoftware/urw-base35-fonts#25 (comment)

Video playlist: Solutions for Styling Qt Widgets

Note to self and to everyone interested in working on styling.
Check out this video playlist:

Solutions for Styling Qt Widgets

Also check out QStyledItemDelegate https://www.youtube.com/watch?v=R9MstFOcVnU