hemantsonu20/json-merge

A light weight library to merge two json objects into a single json object.

Hi 👋, I'm Hemant Patel

My Skills

Languages	Backend Development	Frontend Development	Devops

My Github Stats

 

json-merge's Issues

Validation of input json string in the main merge method

The main merge method accepts two json strings (JsonMerge.merge(srcJsonStr, targetJsonStr);). There is no input validation for non correct values like null or "" or " ". For example invocation with null produces following error: java.lang.IllegalArgumentException: argument "content" is null

I suggest to validate input strings and throw a corresponding exception like IllegalArgumentException with a clear error message.

@hemantsonu20 what do you thing about it? If it's ok for you, I will create a pull request.

Add test cases for this lib

This lib merges two json objects into a single json object. Few test cases with multi level and complex json will test the robustness of this lib.

Add some complex test cases for this lib

A sample test file:

[
  {
    "name": "json-merge"
  },
  {
    "age": 18
  },
  {
    "name": "json-merge",
    "age": 18
  }
]

Every test file will contain three json objects. First one is the src json, second one is target json, third one is expected output.

So just create some complex test cases in same pattern and define expected output.

Note: Adding just json file in test folder will be picked by junit test. No additonal code is required for running the test case.