hendrysadrak/firestore-store

express-session store for Firebase Cloud Firestore

firestore-store's Issues

I am struck at [email protected] dependency.

I think there is some dependency in firestore-store that is not allowing me to update firebase-admin dependency in my project. So I am struck at [email protected]. Please update all dependencies in firestore-store to latest. Thanks 👍

Storing the session as an object

Hi,

I've been using the store for a while and I recenty noticed that the sessions are stored as a single string field instead of a structured object.

I'm aware I can implement my own doc parser which would do effectively nothing.
Before I go that way, I would like to know why you chose to store the session as a single string field containing the string of the json serialization of the session object instead of storing a more structured session object.

Thanks

Comment code

Does it clean the collection of expired sessions?

Could a cron task be added to clean expired sessions on an interval? The interval could be an option the user passes in

Compatible with @google-cloud/firestore?

Is this compatible with @google-cloud/firestore?

Using default session name for cookie using express session for firebase firestore

I am developing an application and hosting on firebase. I used express-session for firebase firestore. The documentation recommends default cookie name as __session as mentioned here https://www.npmjs.com/package/firestore-store#usage-in-cloud-functions-or-cloud-run. But, Express module recommends not to use default name for security reasons as here https://expressjs.com/en/advanced/best-practice-security.html#use-cookies-securely . any thoughts or suggestions?

Create tests

Session lookup does not work in Cloud Functions when running behind Firebase Hosting

I had some issues using this in Cloud Functions for Firebase, i.e. running Cloud Functions behind Firebase Hosting and think this should be documented.

See https://firebase.google.com/docs/hosting/manage-cache#using_cookies

The name should be set to __session in order for the cookie to be made available to the app.

Changing saved data to maps

Hi, I mean no harm but I changed the package a little bit and got this code going on the doc parser. I was able to save the session info as a map instead of a string. Don't really know what problems this might introduce but maybe you can add it to the project.

module.exports = {
	read (doc) {
		return doc;
	},

	save (doc) {
		return JSON.parse(JSON.stringify(doc));
	}
};

Here is a screenshot of what the data looks like on firestore. Your proyect save me from having to change the whole db BTW.

Custom sessions fields are not saved

I'm using express-session 1.16.2, with firestore-2.0, firebase-admin 8.2.0 and passport 0.4.0.
I initialize it like this:

app.use(session({
    secret: 'very secret',
    resave: true,
    rolling: true,
    saveUninitialized: true,
    store: new FirestoreStore({ database: require(path.join(__dirname, 'modules', 'firestore'))})
}))
app.use(passport.initialize());
app.use(passport.session());

This gives me a persisted session object like this, so the logged in user is kept when node is restarted. Below is a typical output from console.log('current session:', req.session).

current session: Session {
cookie:
{ path: '/',
_expires: null,
originalMaxAge: null,
httpOnly: true },
passport: { user: '... a firestore id ...' } }

But then I want to save some more data, and have a post() handler where I set req.session.my_field = value;

However, in the firestore database, this field does not appear. Therefore, it can't be restored for the new request. With the default MemoryStore this works fine, but then the logged in user is of course cleared on restarts.

Is there something more I need to do to get the other fields in req.session to also be persisted?

Compatible with Firebase Realtime DB?

Can this session store also be used for the Firebase Realtime database? 😊

thanks in advance!

Action required: Greenkeeper could not be activated 🚨

🚨 You need to enable Continuous Integration on all branches of this repository. 🚨

To enable Greenkeeper, you need to make sure that a commit status is reported on all branches. This is required by Greenkeeper because it uses your CI build statuses to figure out when to notify you about breaking changes.

Since we didn’t receive a CI status on the greenkeeper/initial branch, it’s possible that you don’t have CI set up yet. We recommend using Travis CI, but Greenkeeper will work with every other CI service as well.

If you have already set up a CI for this repository, you might need to check how it’s configured. Make sure it is set to run on all new branches. If you don’t want it to run on absolutely every branch, you can whitelist branches starting with greenkeeper/.

Once you have installed and configured CI on this repository correctly, you’ll need to re-trigger Greenkeeper’s initial pull request. To do this, please delete the greenkeeper/initial branch in this repository, and then remove and re-add this repository to the Greenkeeper App’s white list on Github. You'll find this list on your repo or organization’s settings page, under Installed GitHub Apps.