herculesws/fluxcp

Flux Control Panel (FluxCP) for Hercules

fluxcp's Issues

lang pt-br

https://github.com/JulioCF/itens-gerais/blob/master/CPs/Flux/Fluxcp_br/lang/pt_br.php

FluxCP Size

how come hercules' fluxcp is 58.7mb while rathena's fluxcp is just 10mb?

Hi

When I try to edit the birthday for an account, It didn't work!

Need to update item module

Dunno if anyone is doing anything with Flux CP? Anywho, the Item DB SQL structure has changed, so Flux source needs to be updated.

To reproduce, install FluxCP, put error exceptions to true and turn debug mode on.
Try to view an item. You'll not be able to, as view column does not exist (it is now view_sprite).

Exception error

Please confirm this error in latest version of Hercules. I dont know whats wrong with that exeption error. Thank you

Exception Details

Error: Flux_Error

Message: Failed to import/replace rows from table 'ragnarok_main.item_db2'

File: /home/alliance/public_html/lib/Flux/TemporaryTable.php:230

File Line Function/Method
/home/alliance/public_html/lib/Flux/TemporaryTable.php 81 Flux_TemporaryTable::raise()
/home/alliance/public_html/modules/account/view.php 16 Flux_TemporaryTable::__construct()
/home/alliance/public_html/lib/Flux/Template.php 337 include()
/home/alliance/public_html/lib/Flux/Dispatcher.php 170 Flux_Template::render()
/home/alliance/public_html/index.php 178 Flux_Dispatcher::dispatch()
Exception Trace As String
#0 /home/alliance/public_html/lib/Flux/TemporaryTable.php(81): Flux_TemporaryTable::raise('Failed to impor...')
#1 /home/alliance/public_html/modules/account/view.php(16): Flux_TemporaryTable->__construct(Object(Flux_Connection), 'ragnarok_main.i...', Array)
#2 /home/alliance/public_html/lib/Flux/Template.php(337): include('/home/alliance/...')
#3 /home/alliance/public_html/lib/Flux/Dispatcher.php(170): Flux_Template->render()
#4 /home/alliance/public_html/index.php(178): Flux_Dispatcher->dispatch(Array)
#5 {main}

Reset Look Bug

When character is wearing a Eddga Card and use Reset Look in Control Panel, the Endure effect stacked in the player even if you relog, wear another Shoes with any cards. It will only removed if you wear and unwear the Shoes with Eddga Card.

Cannot view accounts or characters as ADMIN/Group # 99

I left a post here.
http://hercules.ws/board/topic/1901-flux-control-panel-for-hercules/page-7#entry30991

Redirect after a succesful paypal donation

I am talking about the intended redirect to the "?module=donate&action=complete page.

It seems to not work no matter what. Adding the page to paypal's automatic redirection does nothing either.

After a donation is made, you're just sent to ?module=main, there isn't any attempt to reach the intended page.

I've played around for a bit and I think the issue might be coming from this bit in preprocess.php:

if ($params->get('merchant_return_link')

It seems like merchant_return_link isn't being sent by paypal during the IPN confirmation, although even removing that check doesn't help either.

Upgrade to Google reCaptcha V2

Google has dropped support of reCaptcha V1. While V1 is still functional, it is not as effective as the improved Google reCaptcha V2.

Password Issue

I am having an error in creating a new account.
Password doesn't match to the server sql.
For example...
I created an account like this:
password: qwert12345

After creating it, i tried to login but i cannot so i check my sql and the registered password is : 88ca80df2d72dbebcef83a756c323da1

How to fix this?

'bindonequip' missing from item module

Functionality in the item module for viewing, editing, adding, and copying items with the 'bindonequip' field is nonexistent. Additionally, there aren't any fields for 'bindonequip' in either of our current themes.

CHECKBOXES ARE NOT WORKING!

Hello,

The checkboxes to select dates when searching in item list page, monsters list page, are not working.

Hope someone can solve it!

Ampersand in $this->url causes markup validator fails

The W3C validator finds any "&" symbol as markup errors. Using just "&" in URLs is a bad practice as something like "&copy=3" can make the browser interpret it as "©=3".

My suggestion: Change every "&" character under "public function url ()" in Template.php to its HTML equivalent:
& amp;
That solves the problem and doesn't break stuff. Howerver, the preg replace in:
return $serverProtocol.preg_replace('&/{2,}&', '/', "$serverAddress/$url");
May be redefined.

Localization

There are lots of strings that are not yet added to the lang files that should be added, and also we may move localization to pot files just as we did in hercules!

PS: and fix all encoding issues, because since like the start, everyone that translated lang files or edited the default files (since like I said there are strings missing in the lang file that needed to be edited directly) we came across lots of "????" because the page could not display latin1 characters (áéçõû etc)

Item database table structure updates

The modules that read from the item_db/item_db2 table need to be updated to match the new table structure, or it'll break. Focus points:

• Pre-RE and RE tables now have the same structure.
• Some fields can now be NULL, and NULL means that the server decides their default values.

Table structure is (item_db2, but it's the same for item_db and item_db_re)

CREATE TABLE `item_db2` (
  `id` smallint(5) unsigned NOT NULL DEFAULT '0',
  `name_english` varchar(50) NOT NULL DEFAULT '',
  `name_japanese` varchar(50) NOT NULL DEFAULT '',
  `type` tinyint(2) unsigned NOT NULL DEFAULT '0',
  `price_buy` mediumint(10) DEFAULT NULL,
  `price_sell` mediumint(10) DEFAULT NULL,
  `weight` smallint(5) unsigned DEFAULT NULL,
  `atk` smallint(5) unsigned DEFAULT NULL,
  `matk` smallint(5) unsigned DEFAULT NULL,
  `defence` smallint(5) unsigned DEFAULT NULL,
  `range` tinyint(2) unsigned DEFAULT NULL,
  `slots` tinyint(2) unsigned DEFAULT NULL,
  `equip_jobs` int(12) unsigned DEFAULT NULL,
  `equip_upper` tinyint(8) unsigned DEFAULT NULL,
  `equip_genders` tinyint(2) unsigned DEFAULT NULL,
  `equip_locations` smallint(4) unsigned DEFAULT NULL,
  `weapon_level` tinyint(2) unsigned DEFAULT NULL,
  `equip_level_min` smallint(5) unsigned DEFAULT NULL,
  `equip_level_max` smallint(5) unsigned DEFAULT NULL,
  `refineable` tinyint(1) unsigned DEFAULT NULL,
  `view` smallint(3) unsigned DEFAULT NULL,
  `script` text,
  `equip_script` text,
  `unequip_script` text,
  PRIMARY KEY  (`id`)
) ENGINE=MyISAM;

Discussion of each field, and their default values:

• id No changes from before.
• name_english No changes
• name_japanese No changes
• type No changes
• price_buy If NULL, defaults to price_sell * 2 (zero if both are NULL)
• price_sell if NULL, defaults to price_buy / 2 (zero if both are NULL)
• weight if NULL, defaults to zero
• atk if NULL, defaults to zero
• matk if NULL, defaults to zero (in pre-renewal it exists but it shall be ignored and not displayed)
• defence if NULL, defaults to zero
• range if NULL, defaults to zero
• slots if NULL, defaults to zero
• equip_jobs if NULL, defaults to "All Jobs" (0xffffffff)
• equip_upper if NULL, defaults to "No Restrictions" (0x63)
• equip_genders if NULL, defaults to "No Restrictions" (2)
• equip_locations if NULL, defaults to zero
• weapon_level if NULL, defaults to zero
• equip_level_min if NULL, defaults to zero
• equip_level_max if NULL, defaults to the server's MAX_LEVEL, in both renewal and pre-renewal
• refineable if NULL, defaults to true (for weapons and gears, type == 4 || type == 5 - it can be ignored for other items)
• view if NULL, defaults to zero
• script if NULL, defaults to no script
• equip_script if NULL, defaults to no script
• unequip_script if NULL, defaults to no script

Unreliable fopen call

a reported by Kas in http://hercules.ws/board/topic/1901-flux-control-panel-for-hercules/?p=14071

Warning: fopen(data/tmp/ConfigServers.cache.php) [function.fopen]: failed to open stream: Permission denied in /home/admin/www/cp/lib/Flux.php on line 275

In lib/Flux.php:

            if ($cache) {
                $fp = fopen($cachefile, 'w');
                fwrite($fp, '<?php exit("Forbidden."); ?>');
                fwrite($fp, $s=serialize($cf), strlen($s));
                fclose($fp);
            }

apparently the server is unable to write, and since the result of $fp isn't checked boom it screams php errors instead of one of these green flux error messages

ipv6 issue

More and more players are on ipv6 and for some reasons, flux is not detecting the ip address of the player that is running on ipv6, thus bypassing ip checks, including addons. Thanks!

Plagiarized translation of my FluxCP

I wanted to solve a problem. My translation of fluxcp was added in FluxCP hercules by JulioCF moderator without my permission, I spoke with gepard and even said he would give credit, the more he disappeared.

I believe it would be fair to give credit to me not? Because JulioCF simply copied.

my Flux: https://github.com/Megasantos/Fluxcp/blob/master/lang/pt_br.php

Flux Herc: https://github.com/HerculesWS/FluxCP/blob/master/lang/pt_br.php

Incorrect/useless UsernameAllowedChars check

The check for UsernameAllowedChars is incorrect, making it completely useless.

See lib/Flux/LoginServer.php:

if (preg_match('/^[^' . Flux::config('UsernameAllowedChars') . ']$/', $username)) {
    throw new Flux_RegisterError('Invalid character(s) used in username', Flux_RegisterError::INVALID_USERNAME);
}

The regex will never match, unless the username is exactly one character long.

This is likely to be present in all FluxCP forks, including the original project (Google Code).

Our repository has lost track of the originating commit due to missxantara's mis-handling of upstream merges (i.e. merge of over 200 commits at once at 3427dbb), but it was in Paradox924X's SVN revision 1106 (diff at https://code.google.com/p/fluxcp/source/diff?spec=svn1133&r=1106&format=side&path=/branches/fluxcp-1.0/lib/Flux/LoginServer.php while Google Code is still alive).
It's clear from that commit that Modified patterns for username and email address validation during registration to employ start-of-string and end-of-string anchors. is probably a bad idea, unless one understand regex properly.

Captcha

GD2/FreeType2, Google Captcha

Both aren't working.

server status always offline

why the server status always offline? and the players online is not updating?

Item modules Error

hi i recently downloaded the latest fluxcp and installed latest hercules emulator ive seen issue on item modules item list not displaying and upon checking error logs.

Notice: Trying to get property of non-object in /home/rosevices/public_html/modules/item/index.php on line 264

http://ro-services.com/prev/herculesCP/?module=item

Addon theme name

Flux::config('ThemeName') doesn't work on addons.

Donation Module Broken?

Downloaded the current github version and been running some donation tests through sandbox (and real paypal).

Had absolutely no luck getting in-game (cp accounts) to be credited once the donation goes through. The donation itself is accepted, but the account doesn't get credited any donation credit.

lang es_es.php

Did exist any spanish version of the language file?

Installation Error

Warning: array_key_exists() expects parameter 2 to be array, string given in C:\Xampp\htdocs\her\trunk\lib\Flux\Config.php on line 113

Add Item Description Field

While helping someone I noticed the Item database for FluxCP does not actually pull anything for an item description. You would think this would be one of the main things to pull for the item database, yet it seems to be missing even though it pulls many of the other items properties that seem less vital.