Giter Site home page Giter Site logo

firefox-theme-vscode's Introduction

Hi there 👋 I'm Heron

About Me

I'm currently working as a Software Engineer.

Tech Stack

Node.JS Typescript C# Postgres MySQL MongoDB Amazon Web Services (AWS) Google Cloud (GCP) Linux

Get in touch

firefox-theme-vscode's People

Contributors

heronsilva avatar metamas avatar

Stargazers

 avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar

Watchers

 avatar  avatar

firefox-theme-vscode's Issues

Making italics consistent in light and dark themes

Hi! Thanks for creating these themes! ❤️
I found the light and dark themes are inconsistent in how they handle italics.
If that's not too much to ask, would be great if there are no-italic and italic versions for both themes. Personally, I prefer not having code in italics (comments are fine), even if my font supports italics.

image
image

Missing link and inline code styles in Markdown Preview

Link and inline code style aren't differentiated from plain text in Firefox Dark when viewing a Markdown Preview.

A link's style is only visibly different from plain text if you hover over it. Then it matches the Firefox Dark (Classic) style.

The inline code is monospace, but still difficult to spot without any other style difference.

I've looked at dark.yml, and it does appear that differnt text colors have not been set for these elements. I've just forked and fixed them to match the settings for Dark (Classic). I will submit a PR now.

Light:
image

Dark
image

Dark (Classic)
image

Text highlighting seems wrong

Would it be possible to change it so that when you highlight part of a word, only the selected characters gets highlighted? This theme seems to be the only one to highlight the whole word regardless of what you select. For example in the attached screenshot, I only selected the text "UniqueID" but all of "generateUniqueID" is highlighted.
screenshot 59

Otherwise, great theme!

Question about file structure for theme configs

Hi again @heronsilva. Btw, thanks for making this theme. It's by far my favorite for VS Code :)

While I was fixing #19, I couldn't help but wonder why the configs for theme variants differed in location and file format:

Dark: src/dark.yaml
Dark (Classic): themes/dark-classic.json
Light: themes/light.json

Is this structure necessary for how VS Code interprets themes?

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.