herumi/ecdsa-motoko

ECDSA for Motoko

Under construction

License

Apache 2.0 with LLVM Exception

Author

MITSUNARI Shigeo([email protected])

Sponsors welcome

GitHub Sponsor

ecdsa-motoko's Issues

Where should putPoint and putJacobi be defined?

I made putPoint and putJacobi in src/test_util.mo. Those functions are useful for a debug.
But I try to import it from src/curve.mo to use toHex for a debug, it causes an error.
If I move those functions to curve.mo, then it must include test_util.mo, so I think it is easy that toHex is defined in src/util.mo.
How about it?

Benchmark verify

A benchmark for verify would be the most relevant for the application in canisters.

Makefile is OS specific

The option in the time command time -f %U seems to be OS specific. It doesn't exist for example on MacOS.

How do I get the v-value of a signature?

the signature seems to contain only r and s. Can you provide a function to convert signature to r, s, and v?

Why is there a memory leak?

>make bench
time wasmtime bench-gen.wasm
start
RTS error: Cannot grow memory
Error: failed to run main module `bench-gen.wasm`

Caused by:
    0: failed to invoke command default
    1: wasm trap: unreachable
       wasm backtrace:
         0:  0x499 - <unknown>!rts_trap
         1: 0xe993 - <unknown>!motoko_rts::trap_with_prefix::h7f101abc2caab38e
         2: 0xd067 - <unknown>!motoko_rts::rts_trap_with::h1fdf0be2ac35ef35
         3: 0xd2e8 - <unknown>!motoko_rts::memory::ic::grow_memory::h7cf2cf3cf2e82fde
         4: 0xece4 - <unknown>!mp_calloc
         5: 0x2d31 - <unknown>!mp_init
         6: 0xc3ed - <unknown>!bigint_sub
         7: 0x19c8 - <unknown>!B+sub
         8: 0x1980 - <unknown>!extGcd
         9: 0x1858 - <unknown>!invMod
         10: 0x1841 - <unknown>!divMod
         11: 0x1830 - <unknown>!fpDiv
         12: 0x1b78 - <unknown>!dbl
         13: 0x15f9 - <unknown>!mul
         14:  0x60e - <unknown>!getPublicKey
         15:  0x55c - <unknown>!benchGen
         16:  0x525 - <unknown>!init
         17: 0x25d4 - <unknown>!_start