TypeError: invalid_argument

[herumi]

TypeError: invalid_argument

[herumi]

I've fixed mcl.js to check type(9c61b5a)

[herumi]

Thank you for your report.

TypeError: invalid_argument sometime occurs while initializing this library.

I could not reproduce the bug. How do you call mcl.init()?

hashAndMapToG1 is not called in mcl.init().

[jkawamoto]

Ah, that's true. The error occurred while calling hashAndMapToG1.

I did some unusual things to use this library from jest. Here is the essence of the code:

const mcl = require('../mcl')
const fs = require('fs')

describe('mcl-wasm module', () => {

  beforeAll(() => {
    global.fetch = async req => {
      const buf = fs.readFileSync(req)
      return {
        ok: true,
        arrayBuffer: async () => Uint8Array.from(buf).buffer,
      }
    }
  })

  test('initialize and hashAndMapToG1', async () => {
    await mcl.init()
    mcl.hashAndMapToG1(1)
  })

})

And, I got the output:

TypeError: invalid_argument
    at Int8Array.set (native)
    at /Users/junpei/src/github.com/jkawamoto/mcl-wasm/mcl.js:128:21
    at exports.G1._setter (/Users/junpei/src/github.com/jkawamoto/mcl-wasm/mcl.js:216:19)
    at exports.G1.setHashOf (/Users/junpei/src/github.com/jkawamoto/mcl-wasm/mcl.js:326:14)
    at Object.exports.hashAndMapToG1.s [as hashAndMapToG1] (/Users/junpei/src/github.com/jkawamoto/mcl-wasm/mcl.js:538:9)
    at Object.test (/Users/junpei/src/github.com/jkawamoto/mcl-wasm/__test__/test.js:18:21)
    at <anonymous>
    at process._tickCallback (internal/process/next_tick.js:182:7)

[herumi]

mcl.hashAndMapToG1(1)

hashAndMapToG1() accepts only string or Uint8Array.
Please use hashAndMapToG1("1") or hashAndMapToG1(new Uint8Array([1])).
These values are not same.

I will write document of mcl later.

[jkawamoto]

Thanks! Converting the number to a string works for me.

I'll close this issue.