Giter Site home page Giter Site logo

flock's People

Contributors

cdornan avatar eelis avatar hesselink avatar himura avatar maoe avatar niklasb avatar ocheron avatar tvh avatar

Stargazers

 avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar

Watchers

 avatar  avatar  avatar

flock's Issues

Inaccurate version bounds in .cabal file

Specifically, throwErrnoPathIfMinus1Retry_ wasn't exported by System.Posix.Error before unix-2.5.0.0, and compilation fails with e.g. unix-2.4.2.0:

[1 of 1] Compiling System.Lock.FLock ( dist/dist-sandbox-69b443ad/build/System/Lock/FLock.hs, dist/dist-sandbox-69b443ad/build/System/Lock/FLock.o )

System/Lock/FLock.hsc:26:38:
    Module
    `System.Posix.Error'
    does not export
    `throwErrnoPathIfMinus1Retry_'

Suggestion: Create file if it does not exist

The flock utility in the util-linux-ng, when given a file path, calls open with file mode 666 to create the file if it does not exist.

I can't think of a reason why we would not want to create the lockfile if it does not exist, and this behavior would be more consistent with user expectation (my expectation, anyway).

Can't lock directories exclusively

I tried to lock a directory exclusively using lock "/home" Exclusive Block. Unfortunately it didn't work an failed with this exception:

*** Exception: /home: openFd: inappropriate type (Is a directory)

This happens because openFd can open directories only ReadOnly. Opening directories with ReadOnly is sufficient for locking them exclusively with flock as shown with this code:

lockDirectoryExample = do
  fd <- openFd "/home" ReadOnly Nothing defaultFileFlags
  l <- lockFd fd

I guess to fix this lock would have to check if the given path is a directory and if so, open it with ReadOnly.

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    ๐Ÿ–– Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. ๐Ÿ“Š๐Ÿ“ˆ๐ŸŽ‰

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google โค๏ธ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.