heyitsarpit/react-hooks-library

A collection of hooks and utilities for modern React

react-hooks-library's Issues

[docs] Make the website a PWA

[docs][packages] Build failure due to SSR not working

Various errors related to document and window being undefined. Happended after merging #13 .

Issues encountered in these functions -

• BreakPointHooks
• useActiveElement
• useClickOutside
• useEventListener
• useKeyStroke
• useMediaStream
• useMutationObserver
• useRouter
• useScroll
• useTitle
• useWindowSize

[Docs] Add details for shared/utils page

[docs] SEO tags do not render on the server

Server side rendering is not working for SEO tags. Related to #8

[docs, bug] On useStateHistory page reset button can break the example.

Tested on IOS Chrome. If you click reset button while nothing is in history, it is breaking the example. It should be disabled like redo button.

[docs] Design and Performance Improvements

• Add button to open sidebar on mobile
• make sidebar autocollpsible
• close sidebar by clicking outside it
• Make logo smaller on mobile, hide text logo on mobile
• Higher margin y for code blocks
• Lower x padding for body on mobile
• Optimise font loading, use same origin font and caching via swr

[bug] Typescript error on build "ConnectionType"

Hello , I use your library for its BreakPointHooks and I have an issue when trying to build my app :

npm run build                  

> [email protected] build
> tsc && vite build

node_modules/@react-hooks-library/core/index.d.ts:627:21 - error TS2304: Cannot find name 'ConnectionType'.

627     readonly type?: ConnectionType;
                        ~~~~~~~~~~~~~~

node_modules/@react-hooks-library/core/index.d.ts:649:11 - error TS2304: Cannot find name 'ConnectionType'.

649     type: ConnectionType | undefined;
              ~~~~~~~~~~~~~~


Found 2 errors in the same file, starting at: node_modules/@react-hooks-library/core/index.d.ts:627

What could I do to fix it ? I'm using Typescript 5.3.3 on my app btw.

Thanks !

[docs] Add export size for each package

[hooks] Hooks don't return stable functions

Hooks don't currently return stable functions, i.e. the function is recreated on each render and cannot be properly used by user code inside an effect.

Solution - wrap all internal function with useCallback.

[docs] useHasMounted links to wrong page

useHasMounted Source links go to useScroll source/demo/docs
https://react-hooks-library.vercel.app/core/useHasMounted

[docs] Fix styling (eg. top-bottom margins) on /design page

[docs] Write a contribution guide.

[hooks] useEffectAfterMount does not return clean up function

useEffectAfterMount does not currently return clean up function, i.e. user passed clean up function will not run.

Solution - return user passed clean up function.

useMediaQuery returns updated value after 15px

i am using the useMediaQuery hook.
My code:

   const isDesktopScreen = useMediaQuery('(min-width: 1552px)')

the isDesktopScreen return false at 1537px instead of 1552px.
The useMediaQuery returns updated value after 15px is decreased or increased.

[hooks] useEffectAfterMount does not in React 18's strict mode in development environment

useEffectAfterMount does not in React 18's strict mode in development environment, because react first mounts component, which sets isMounted.current to true, then unmounts component and mounts again. The problem is that isMounted.current is true on second mount.

Solution - reset isMounted.current on unmount.

[docs] ⛱ Umbrella issue for SEO improvements

[meta] Add dynamic versioning across all packages