hhvm/hack-router

Request routing for HackLang

hack-router's Issues

Create and use a Hack alternative to PSR-7 and Diactoros

This should be done before 1.0. Motivation:

• PSR-7 doesn't fit nicely with the hack type system: https://github.com/fredemmott/psr7-http-message-hhi#notes
• Given HHVM's long-term plans, PHP dependencies should be avoided as they'll eventually be unsupported

However, until we drop PHP support, keeping some interoperability (e.g. conversion functions) would be reasonable.

cc @usox, @RyanGordon, @asuth, @acrylic-origami, @bobertforever for feedback

Hack

spam

• deleted spam -

Migrate from Hack Collections to Hack Arrays

Be smarter about regexp patterns when generating the URI map

For example, https://gist.github.com/fredemmott/38865631ec219f2643d94f33d1af7aaf has a load of (hhvm|hack) regexps. It could be smarter about:

• foo|bar regexps: expanding them may be helpful
• repeated regexps: it may be possibel to group

Add script to generate build script

In simple cases, projects using this are going to want a bin/build-router.php or similar. A working starting point can be generated.

Examples do not work on hhvm 4.111: Found top-level code in BaseRouterExample.php

Hi folks,

I was trying to run examples with recent hhvm and got errors:

$ hhvm --version
HipHop VM 4.111.0 (rel)
Compiler: 1621979252_828765612
Repo schema: d1ae8e21bf3419a65f12a010527485564e719d07

$ hhvm BaseRouterExample.php 

Fatal error: Found top-level code in <path>/hack-router/examples/BaseRouterExample.php on line 17

Could this be addressed? What is the best way to avoid it?

Add support for non-path query parameters in URIBuilder

Migrate away from nikic/fast-route

• the HHI is not valid for 3.23 (or 3.22 with shapes changes); to fix this, it should be split out to a separate project
• however, that's probably not worthwhile, given that long-term we need to migrate away from PHP dependencies

Biggest risk is messing up pattern parser compatibility; this won't be an issue with hack-router-codegen, but will if using things directly.

remove HEAD/GET rewrite

https://github.com/hhvm/hack-router/blob/master/src/router/BaseRouter.php#L36