Comments (7)
It looks like it was added in 2019 and not touched since then, so I wouldn't expect it to change any time soon. I don't think it's necessary to preemptively fix HHAST or other projects, we can always do that if/when someone wants to change the default.
from hhast.
That said, if you want to enable this option in some of your projects but the HHAST dependency is preventing you, I certainly wouldn't be opposed to fixing it here.
from hhast.
That said, if you want to enable this option in some of your projects but the HHAST dependency is preventing you, I certainly wouldn't be opposed to fixing it here.
If I knew what this setting did, I could make an informed decision. I don't understand the error it creates either. If others want to turn this feature on, please comment below.
from hhast.
It seems like this area is being explored again.
facebook/hhvm@e72c9ef
from hhast.
The current state/plan is now documented here: https://github.com/facebook/hhvm/blob/master/hphp/hack/doc/HIPs/converging_constants.md
from hhast.
Thanks for publishing the HIP. I have given it a read, but I couldn't take it all in at once. I'll read this again tomorrow. (With a hh_client, hhvm, and pen and paper in hand 😄.)
from hhast.
This issue has been resolved. The type constant does not have a default value anymore.
from hhast.
Related Issues (20)
- Drop support for the `@` error suppression operator HOT 1
- [ Regression ] Mismatched configuration for a linter should fail the lint run HOT 2
- Suppression comments for HHClientLinter don't mesh well with /**/ comments HOT 3
- Known bad HHClientLinters need to be automatically unconditionally suppressed HOT 5
- Delete HHAST linters that duplicate good HHClientLinters HOT 6
- Support readable aliases for HHClientLinter rules HOT 4
- Linter to check if the result of the new operator is silently discarded
- Support HHAST_IGNORE_ALL for hhclientlinter codes HOT 2
- Disable some lint rules by default HOT 2
- hh_client lints are slow and unreliable in IDE HOT 1
- Overrides are not respected with recent update HOT 1
- [ RFC ] Adding an optional allow list to hhast-lint.json HOT 1
- Fix attribution for schema update commits HOT 4
- HHAST crashes with nightly HHVM
- GitHub Actions are not triggered for the pull request to update schema
- DontSuppressLintErrorsLinter
- DontReassignParametersLinter
- DontReturnFromCloneLinter
- Remove use of the XHProf profiler
- If present `async` should be to the immediate left of `function` HOT 1
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from hhast.