Giter Site home page Giter Site logo

gyp-generator-output-bug's Introduction

For https://bugs.chromium.org/p/gyp/issues/detail?id=508

Problem: the --generator-output option in gyp causes weirdness

This is a problem because tools like node-gyp depend on this option. The core error in GYP is that it calculates relative paths before switching to the generator-output directory, at which point its relative paths are wrong.

The result is output generated in the wrong directories; this causes a variety of issues such as garbage in the file tree, or failures (as GYP tries to work outside the home directory in some case).

The behavior is visible when you use dependencies to other gyp files.

I've made a minimal test case with two projects, one that uses the other. They are at the same level. So, the path to the 2nd gyp file is ../world/project.gyp. This is what GYP calculates and uses (even if we specify full, absolute paths). However when we specify --generator-output=build (for instance), GYP switches to that directory and THEN generates the makefiles for world. These end up in build/../world/, which is wrong.

Solution: if user specifies --generator-output, then GYP must calculate its relative paths FROM THIS DIRECTORY and not from the location of the gyp file.

gyp-generator-output-bug's People

Contributors

hintjens avatar

Stargazers

Grayson Lang avatar

Watchers

 avatar James Cloos avatar  avatar

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    ๐Ÿ–– Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. ๐Ÿ“Š๐Ÿ“ˆ๐ŸŽ‰

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google โค๏ธ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.