hitherejoe/githubtrending

An Android project for the Caster.io course on clean architecture

githubtrending's Issues

Running tests throws Process finished with exit code 1 Class not found EmptyTestSuite

I'm trying to run test included in the domain layer but all of them fails with this error
Process finished with exit code 1 Class not found: "co.joebirch.domain.interactor.bookmark.BookmarkProjectTest"Empty test suite.

Test failing at ProjectCacheImplTest isProjectCacheExpired

GithubTrending/cache/src/test/java/co/joebirch/cache/ProjectsCacheImplTest.kt

Line 98 in da09a1d

testObserver.assertValue(false)

java.lang.AssertionError: Expected: false (class: Boolean), Actual: [] (latch = 1, values = 0, errors = 0, 
completions = 0)

at io.reactivex.observers.BaseTestConsumer.fail(BaseTestConsumer.java:162)
at io.reactivex.observers.BaseTestConsumer.assertValue(BaseTestConsumer.java:327)
at com.nygma.cache.ProjectsCacheImplTest.isProjectsCacheExpiredReturnsNotExpired(ProjectsCacheImplTest.kt:99)
at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
at sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62)
at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
at java.lang.reflect.Method.invoke(Method.java:498)
at org.junit.runners.model.FrameworkMethod$1.runReflectiveCall(FrameworkMethod.java:50)
at org.junit.internal.runners.model.ReflectiveCallable.run(ReflectiveCallable.java:12)
at org.junit.runners.model.FrameworkMethod.invokeExplosively(FrameworkMethod.java:47)
at org.junit.internal.runners.statements.InvokeMethod.evaluate(InvokeMethod.java:17)
at org.robolectric.RobolectricTestRunner$HelperTestRunner$1.evaluate(RobolectricTestRunner.java:497)
at org.junit.rules.TestWatcher$1.evaluate(TestWatcher.java:55)
at org.junit.rules.RunRules.evaluate(RunRules.java:20)
at org.robolectric.internal.SandboxTestRunner$2.evaluate(SandboxTestRunner.java:228)
at org.robolectric.internal.SandboxTestRunner.runChild(SandboxTestRunner.java:110)
at org.robolectric.internal.SandboxTestRunner.runChild(SandboxTestRunner.java:37)
at org.junit.runners.ParentRunner$3.run(ParentRunner.java:290)
at org.junit.runners.ParentRunner$1.schedule(ParentRunner.java:71)
at org.junit.runners.ParentRunner.runChildren(ParentRunner.java:288)
at org.junit.runners.ParentRunner.access$000(ParentRunner.java:58)
at org.junit.runners.ParentRunner$2.evaluate(ParentRunner.java:268)
at org.robolectric.internal.SandboxTestRunner$1.evaluate(SandboxTestRunner.java:64)
at org.junit.runners.ParentRunner.run(ParentRunner.java:363)
at org.junit.runner.JUnitCore.run(JUnitCore.java:137)
at com.intellij.junit4.JUnit4IdeaTestRunner.startRunnerWithArgs(JUnit4IdeaTestRunner.java:68)
at com.intellij.rt.execution.junit.IdeaTestRunner$Repeater.startRunnerWithArgs(IdeaTestRunner.java:47)
at com.intellij.rt.execution.junit.JUnitStarter.prepareStreamsAndStart(JUnitStarter.java:242)
at com.intellij.rt.execution.junit.JUnitStarter.main(JUnitStarter.java:70)
at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
at sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62)
at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
at java.lang.reflect.Method.invoke(Method.java:498)
at com.intellij.rt.execution.application.AppMainV2.main(AppMainV2.java:131)

Inept stubbing in ProjectsDataRepositoryTest

GithubTrending/Data/src/test/java/co/joebirch/data/ProjectsDataRepositoryTest.kt

Line 96 in 02ae6cd

private fun stubBookmarkProject(completable: Completable) {

Issue: 2 tests were failing

1. bookmarkProjectCompletes

You should be using factory.getCacheDataStore().setProjectAsBookmarked(any()) instead of cache.setProjectAsBookmarked(any())

private fun stubBookmarkProject(completable: Completable) {
       whenever(factory.getCacheDataStore().setProjectAsBookmarked(any())).thenReturn(completable)
}

2. unbookmarkProjectCompletes

Same

Where should I handle Rxjava disposables?

Where should I handle Rxjava disposables in domain layer usecase "interactors" or ViewModels? What is better ?

I know that you can dispose when onCleared method on viewModel is called.

cannot read property indexof of undefined

版本： 3.1.3

assertion error

GithubTrending/cache/src/test/java/co/joebirch/cache/ProjectsCacheImplTest.kt

Line 47 in da09a1d

testObserver.assertValue(projects)

java.lang.AssertionError: Expected: [com.data.model.ProjectEntity@57fbc06f] (class: SingletonList), 
Actual: [com.data.model.ProjectEntity@51a18b21] (class: ArrayList) (latch = 1, values = 1, errors = 0, 
completions = 0)

at io.reactivex.observers.BaseTestConsumer.fail(BaseTestConsumer.java:162)
at io.reactivex.observers.BaseTestConsumer.assertValue(BaseTestConsumer.java:331)
at com.nygma.cache.ProjectsCacheImplTest.getProjectsReturnsData(ProjectsCacheImplTest.kt:48)
at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
at sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62)
at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
at java.lang.reflect.Method.invoke(Method.java:498)
at org.junit.runners.model.FrameworkMethod$1.runReflectiveCall(FrameworkMethod.java:50)
at org.junit.internal.runners.model.ReflectiveCallable.run(ReflectiveCallable.java:12)
at org.junit.runners.model.FrameworkMethod.invokeExplosively(FrameworkMethod.java:47)
at org.junit.internal.runners.statements.InvokeMethod.evaluate(InvokeMethod.java:17)
at org.robolectric.RobolectricTestRunner$HelperTestRunner$1.evaluate(RobolectricTestRunner.java:497)
at org.junit.rules.TestWatcher$1.evaluate(TestWatcher.java:55)
at org.junit.rules.RunRules.evaluate(RunRules.java:20)
at org.robolectric.internal.SandboxTestRunner$2.evaluate(SandboxTestRunner.java:228)
at org.robolectric.internal.SandboxTestRunner.runChild(SandboxTestRunner.java:110)
at org.robolectric.internal.SandboxTestRunner.runChild(SandboxTestRunner.java:37)
at org.junit.runners.ParentRunner$3.run(ParentRunner.java:290)
at org.junit.runners.ParentRunner$1.schedule(ParentRunner.java:71)
at org.junit.runners.ParentRunner.runChildren(ParentRunner.java:288)
at org.junit.runners.ParentRunner.access$000(ParentRunner.java:58)
at org.junit.runners.ParentRunner$2.evaluate(ParentRunner.java:268)
at org.robolectric.internal.SandboxTestRunner$1.evaluate(SandboxTestRunner.java:64)
at org.junit.runners.ParentRunner.run(ParentRunner.java:363)
at org.junit.runner.JUnitCore.run(JUnitCore.java:137)
at com.intellij.junit4.JUnit4IdeaTestRunner.startRunnerWithArgs(JUnit4IdeaTestRunner.java:68)
at com.intellij.rt.execution.junit.IdeaTestRunner$Repeater.startRunnerWithArgs(IdeaTestRunner.java:47)
at com.intellij.rt.execution.junit.JUnitStarter.prepareStreamsAndStart(JUnitStarter.java:242)
at com.intellij.rt.execution.junit.JUnitStarter.main(JUnitStarter.java:70)
at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
at sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62)
at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
at java.lang.reflect.Method.invoke(Method.java:498)
at com.intellij.rt.execution.application.AppMainV2.main(AppMainV2.java:131)

Add to bookmark not working first time the app run

When clicking on bookmark project for the first time the app run the bookmark icon don't change , when I clicked on bookmarked projects action menu then return or launch app for second time it's working because it retrieves data from cache,and the first time app runs it call the server twice and don't return data

The complete source

hi @hitherejoe , Thanks for your course!
So, is this completed source?
Cloned this repository and can't see the response data in UI of the app. (Only show loading forever)
Please help me how to run the right way to show the UI as your tutorial.

Thanks in advance!

No parameter for isBookmarked

Project Entity has an "isBookmark" param in it's constructor

GithubTrending/Data/src/main/java/co/joebirch/data/model/ProjectEntity.kt

Lines 3 to 6 in fd79a57

	class ProjectEntity(val id: String, val name: String, val fullName: String,
	val starCount: String, val dateCreated: String,
	val ownerName: String, val ownerAvatar: String,
	val isBookmarked: Boolean)

The mapFromModel doesn't have it

GithubTrending/Remote/src/main/java/co/joebirch/remote/mapper/ProjectsResponseModelMapper.kt

Lines 10 to 12 in fd79a57

	return ProjectEntity(model.id, model.name, model.fullName,
	model.starCount.toString(), model.dateCreated, model.owner.ownerName,
	model.owner.ownerAvatar)

mockito exception

org.mockito.exceptions.base.MockitoException:
Cannot mock/spy class com.nygma.data.store.ProjectsCacheDataStore
Mockito cannot mock/spy because :

• final class

  at com.nygma.data.store.ProjectsRemoteDataStoreTest.(ProjectsRemoteDataStoreTest.kt:30)
  at sun.reflect.NativeConstructorAccessorImpl.newInstance0(Native Method)
  at sun.reflect.NativeConstructorAccessorImpl.newInstance(NativeConstructorAccessorImpl.java:62)
  at sun.reflect.DelegatingConstructorAccessorImpl.newInstance(DelegatingConstructorAccessorImpl.java:45)
  at java.lang.reflect.Constructor.newInstance(Constructor.java:423)
  at org.junit.runners.BlockJUnit4ClassRunner.createTest(BlockJUnit4ClassRunner.java:217)
  at org.junit.runners.BlockJUnit4ClassRunner$1.runReflectiveCall(BlockJUnit4ClassRunner.java:266)
  at org.junit.internal.runners.model.ReflectiveCallable.run(ReflectiveCallable.java:12)
  at org.junit.runners.BlockJUnit4ClassRunner.methodBlock(BlockJUnit4ClassRunner.java:263)
  at org.junit.runners.BlockJUnit4ClassRunner.runChild(BlockJUnit4ClassRunner.java:78)
  at org.junit.runners.BlockJUnit4ClassRunner.runChild(BlockJUnit4ClassRunner.java:57)
  at org.junit.runners.ParentRunner$3.run(ParentRunner.java:290)
  at org.junit.runners.ParentRunner$1.schedule(ParentRunner.java:71)
  at org.junit.runners.ParentRunner.runChildren(ParentRunner.java:288)
  at org.junit.runners.ParentRunner.access$000(ParentRunner.java:58)
  at org.junit.runners.ParentRunner$2.evaluate(ParentRunner.java:268)
  at org.junit.runners.ParentRunner.run(ParentRunner.java:363)
  at org.junit.runner.JUnitCore.run(JUnitCore.java:137)
  at com.intellij.junit4.JUnit4IdeaTestRunner.startRunnerWithArgs(JUnit4IdeaTestRunner.java:68)
  at com.intellij.rt.execution.junit.IdeaTestRunner$Repeater.startRunnerWithArgs(IdeaTestRunner.java:47)
  at com.intellij.rt.execution.junit.JUnitStarter.prepareStreamsAndStart(JUnitStarter.java:242)
  at com.intellij.rt.execution.junit.JUnitStarter.main(JUnitStarter.java:70)

Works after changing ProjectsCacheDataStore and ProjectsRemoteDataStore to open class

GithubTrending/Data/src/test/java/co/joebirch/data/store/ProjectsDataStoreFactoryTest.kt

Line 9 in 02ae6cd

private val cacheStore = mock<ProjectsCacheDataStore>()

Some ProjectsDataRepositoryTest tests are failing

Tests sometimes pass and some times don't.