hoeencoder/wavelength

The github repository for the Wavelength server on Pokemon Showdown.

wavelength's Issues

Dice Log

Currently Economy.logDice does nothing and is not viewable in moneylog nor is there a command to view it? Should we merge it in moneylog or new command?

SGGame AI TODO:

I'm basically going to play around with the trainer AI in SGGame and report anything we should improve.

List of Checks needed:

• Dream Eater check

Possible Implementation:

• Use Potions?

The SSBFFA revamp

Hi so. I wish to greenlight SSBFFA but I have decided (along with HoeenHero) that there are certain things that should be changed to give more freedom to people, give less wait time for trying out something new, and gives us developers to not get us swamped with work. So here is what we decided. Feel free to discuss

Instead of getting access to a custom tailored move after a 1 time purchase, we have decided to use a tier system that gradually gives you stronger stuff as you go higher.

here is what we have for moves:
Standard: use 1 move† that the pokemon cant learn normally
Advanced: Standard + access to some powerful pre-coded custom moves
Ultimate: Advanced + Server programmers work with you to add 1 move just for you†.

abilities:
Standard: nothing special
Advanced: access to an ability that the pokemon cant have normally†
Ultimate: Advanced + Server programmers work with you to add a custom ability just for you†

items:
Standard: nothing special (access to normal items or no item)

† We reserve the right to change/remove/reject it if there are issues regarding balance, code, or something else.
__

Let me know what you think :)

random reference to #239

SGgame - USUM Pokemon Catch Rates & Base EXP values

Catch rates/ Base EXP values currently aren't avaliable for the new USUM pokemon.
I've set temporary rates & values for them atm, but true data is wanted ASAP.

The future of the "WL" global utility variable

Alot of side servers, including Wavelength, have a global varaible that acts as a holder for utility functions. This can be useful, though these variables are also used for other things at times that could be self contained in their chat-plugin files.

What I want to do with "WL" in this refactor is either A. replace it with a "Tools" global for utility functions that are used all over the server only or B. merge these utilities into Chat (or another appropriate variable like Dex).

You may be wondering, "Why not use Dex if we aren't going to use WL anymore?". Dex is more for sim ("pokedex") based tools, Dex.getTemplate gets a pokemon template, Dex.getAbility gets an ability, ect. Things like WL.nameColor don't make much sense there, especially since Dex is loaded in the battle processes and nameColor isn't used there (waste of memory).

I'm open to other suggestions and ideas, please reply and let me know what you think we should do.

SGgame - Reimplement Type Script

Typescript was disabled for the SGgame branch temporarly, until i can learn it and implement things for wavelength. This is mostly a note so I don't forget to re-add it.

"scripts": {
    "start": "node pokemon-showdown",
    "test": "eslint --rulesdir=dev-tools/eslint --cache . && tsc && mocha"
  },

Idea: Show Faction & Level in profile

It kinda goes without saying

Refactor and re-add existing formats

Formats that are approved for refactoring and re-addition

• Desometa - Contact Desokoro for details
• Digimon (Digimon Dev Team)
• WLSSB (force)
• SSBFFA (force)

Formats pending approval for refactoring and re-addition (may be cut, refactor at your own risk)

• Pokemon Mystery Dungeon
• Tsumeta
• LU
• Stacked
• Doubles Monotype
• Weather Wars

(If any custom formats are missing let me know).

Leaving Forrce incharge of this for the most part. Basically, feel free to vouch for or against any of the above pending formats staying on Wavelength. For those that are approved and unclaimed (no parens after the format name) feel free to post here to claim it and then refactor it. This includes any mod code or chat-plugins needed to make these work.

Chat Plugins Refactor

Chat Plugins are probably the area that needs to most work as they are the most modified.
To consider:

• Should we merge all plugins into chat-plugins and drop support for the alternate folder?
  • Pros: Reduced possibility of errors, especially when main changes anything to do with chat-plugin folder functionality.
  • Cons: Folder becomes bigger since it has more plugins (bloat).
• Should we try to merge some related plugins together such as custom colors, avatars, and icons?
  • Pros: Less bloat in the number of files.
  • Cons: Possible bloat in the file instead.

Please try to keep plugins self contained (they stay inside their own file and code in other files is NOT needed)
Please ensure all commands have a /help entry

Chat Plugins approved for refactoring and re-adding

• Custom Colors [colors.js]
• Custom Avatars [customavatar.js]
• Dice [dice.js]
• Digimon Info Plugin [digimon.js] (Digimon Dev Team)
• Emotes [emoticons.js]
• Github [github.js] Not currently in the plugin folder so hotpatch chat dosent reload it, maybe we can get around that?
• Icons [icons.js]
• Economy Plugin [economy.js] (@Dragotic-PS)
• News [news.js] Honestly just remove the whole "subscribe" thing and just show it in a PM box when they connect/type a command. (@Mystifi)
• Permalock/ban Plugin [perma.js]
• PSGO [psgo.js]
• Shop Plugin [shop.js formerly eShop.js] (@HoeenCoder)
• SSBFFA [ssb.js] Fate of this depends on the fate of SSBFFA in #239
• Surveys [survey.js]

Chat Plugins pending approval before refactoring and re-adding. Refactor at your own risk.

• Ambush [ambush.js #230 ] Not yet added plugin that is a game thats often hosted by bots.
• Badges [badges.js] Not really used
• Drafts [drafts.js] Not really used
• EXP [exp.js] Unsure about an EXP system at this point, may be better to just give dust for stuff
• Factions [factions.js] Not really used
• Freinds List [friends.js] Main has one coming "soon" (a while) and idk how I feel about ours atm.
• Gen Requests [genrequests.js] ???
• Lottery [lottery.js] If users want this, it can stay
• Misc Plugins [misc.js] Was used as a catch all file, potentially this would be better done in other files. Needs research.
• Modified Plugins/Commands from Main [modified.js] We should potentially just modify them where they originally were from, even if it causes conflicts we can fix them and its important to know when the base code changes for these. Modify the command in its original file.
• Ontime Plugin [ontime.js] Just records ontime for people
• Profiles [profile.js] Has always been a pain to maintain and work with, if were keeping it try not to overload it with features and make editing it intuitive.
• Room Request Plugin [roomrequest.js] Fate of this depends on how we chose to handle rooms in the future.
• Room Shop [roomshop.js] Idk maybe this has a useful purpose. Merged into shop (supports both with less code)
• Shadow Bans [shadowban.js] Do we even use these? /gban works just as well.
• Splatoon [splatoon.js] I'm a fan of the game but idt it has enough draw here.
• Staff Help [staffhelp.js] Basically a giant list of staff commands, might be better to automate this rather than making it all hardcoded or just drop it.
• Tsumeta [tsumeta.js] Fate of this depends on the fate of Tsumeta in #239

If I missed something, or you have opinions on what to keep/remove reply to this. For those that are approved and unclaimed (no parens after the plugin name) feel free to post here to claim it and then refactor it.

Battles randomly Crash

SGgame (Alpha 2.0) Bug Tracker

PLEASE READ THIS POST BEFORE REPORTING A BUG

Thanks for your interest in helping with SGgame development, either through reporting bugs, or fixing them. Both are appreciated!

This issue is for tracking bugs with SGgame Alpha 2.0, NOT Alpha 1.0.
The code for 2.0 can be found in the v2 branch

If you are reporting a bug:
Please make sure the bug has not already been reported, we are already aware if it has been.
Please be specific about what happened, "It crashed" isn't useful. Specifically:

• What exactly crashed/broke/isn't working as intended
• What steps did you take leading up to the issue?
• If theres a stack trace, please post the whole stack trace in your report.
• What server did the crash occur on? (wavelength, local test server, other (give the name!))
• Any other info about the crash that you might have. (save data maybe)

We may ask you for further details, if you don't check github often leave your PS username and what server I can find you on (main, wavelength, other (give the name!)). Thanks for the help again!

SGgame bug master list

Since there isnt really one ill just be the first to do so!

• Clicking a pokeball if there is no mons on your side of the field results in the game freezing

• move learning on evolution doesnt work

• Whenever a mon levels up in the middle of an SGgame battle its stats are buffed uncontrollably

• %Arrays: if a mon levels up mid match it stops gaining exp and doesnt level midmatch || %Arrays: but it does level outside the match

Update Super Staff Bros.

Main TODO:

• Remove former auth for SG

• Update Ranks

• Import Tsunami's Auth

• Add wgc (Nothing i can do rn so i just left a message on the txt file)

• New Descriptions

---

Also if thou must, This is probably a good time to update any staffmons if you feel like it!

Polls: Rename Interaction

If a user switches from their name to another, and switches back appears to cause a crash.

Achievements

Achievements

Achievements would be another way of getting stardust and a way to get badges: which give effects if you have them. Right now I have ideas for achievements for coming on daily, winning/losing battles, uno matches, and probably ambush, PSGO cards, and ontime. (if we keep/fix it).

Badges give certain effects similar to how something on Spacial Gaze worked (It gave more stardust for tours and uno wins but I don't actually remember if it was badges or something else) The effects range from adding a stardust for the daily stardust to getting more stardust from winning tours and games right now. There may be some badges that do nothing but show that you got a really big (or even secret) achievement.

Some things that may change because of this may be Profiles and the Daily Stardust because of this.

Global Leader Bug

Global Leader are being able to promote anyone to admin and demote admin to regular user while being global leader.

TODO

Lottery:

• Display Command (/lottery display)
• Check Time Remaining Command
• Modify Timer Command
• Show Current Lottery Prize on display (updates every join silently)

Surveys:

• Support Shadow Bans filtering answers
• Support emoticons in surveys

SSBFFA:

• Command that sets/removes the user's custom move/ability/item (so HoeenHero doesn't have to eval it every time)

PSGO:

• Support a /psgo addpack (addcard, etc) and create a joinable storage for so to be shown alongside the cards in config/cards.json

SGgame Branch: Crash

1st crash:

The server needs to restart because of a crash: TypeError: this.room.log.push is not a function
at CommandContext.parse (C:\Users\Administrator\Desktop\Impulse-Server\chat.js:313:20)
Please restart the server.

2nd Crash:

~Wavelength Server: The server has crashed: Error: Obsolete command; use room.sendMods. at BasicChatRoom.sendModCommand (C:\Users\Administrator\Desktop\Impulse-Server\rooms.js:122:27)

Both crashes occur after last night's update from main.