holger-will/code-128-encoder

code-128-encoder's Issues

Uncaught TypeError when used in 'use strict' mode

Very nice app! It works really well when I reference the file as instructed.

I thought it would be nice to use it as a module but ran into issues when doing so. I think it's because ES6 javascript modules enforce strict mode.

When imported with import './code-128-encoder.min.js'; I get this error code-128-encoder.min.js:3 Uncaught TypeError: Cannot use 'in' operator to search for 'String' in undefined at Object.$jscomp.polyfill.

How can I encode control codes such as 'FUNC 1'

I want to encode GS1-128, which requires 'FUNC 1' as the 1st code.

When rendering a code in the browser, is there a minimum recommended font size?

I see that you use 50px in your examples. Is that the minimum size we should use?

Using in React Native TypeError: undefined is not an object (evaluating 'root.Code128Generator')

I'm trying to use this library in React Native but when I import code-128-encoder and use "new Code128Generator()" I have the error TypeError: undefined is not an object (evaluating 'root.Code128Generator')

Font glyph of FNC1 has unnecessary space on left side

Left side space must be removed because FUNC1 should be able to be placed middle of code.

Problems that code number can not be generated properly

Hi,

I found your Code 128 font and encoder.
I generated a barcode with Code C for a code composed only of numerical values, but it did not work properly.
The cause is ascii [0] when multiple ascii are allocated in Code 128 Generator.codes
It is necessary to encode with ascii [1] with error.

In your library, you can change the getASCIIFromCode () method with options.mapping, but this does not work properly. If only one ascii is allocated, undefined is returned. You understand?

getASCIIFromCodeC () is fixedly called in optimize (), and ascii [0] is permanently specified in it. This does not call ascii [1], is it?

Therefore, the font you defined is useful, but the library of this project could not be used.

Requesting support for Google's barcode font

Hi,
Great project.

Would it be good to consider adding support for Libre Barcode 128(Google font) and similar fonts?

Somehow the encoded output from code-128-encoder does not work, which can you check here.

Is it about standard/conventions? Is it possible to make it work with other barcode fonts?

Thanks

Wrong checksum glyph

Encoding 1hnL9wrba2JYA3xxYGGcGq results in Ì1hnL9wrba2JYA3xxYGGcGq Î, when it ought to be Ì1hnL9wrba2JYA3xxYGGcGqÂÎ.

Repro:

describe('Code128Encoder', () => {
    const code128Encoder = new Code128Encoder()

    it('encodes a problematic ID', () => {
        const encoded = code128Encoder.encode('1hnL9wrba2JYA3xxYGGcGq', { output: 'ascii' as any })
        expect(encoded).toBe('Ì1hnL9wrba2JYA3xxYGGcGqÂÎ')
    })
})

Changelog?

I didn't find a change log and also noticed their weren't tags/releases for later versions that are published to NPM.